From patchwork Wed Mar 27 19:26:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Folker Schwesinger X-Patchwork-Id: 13607381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C104ECD1283 for ; Wed, 27 Mar 2024 19:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qL23mkA6Lzrt1z7pybo7Nqbg2lNmq5jvoECN+XMW8xA=; b=fzW7LHORfmoMzu BvadGkfAKbGJnolY7r9oHpmHPecqRsnCb/ERCk8JiftZhsOg5CufsMaQ2S6Blbcz0XVabD1QLMM/x 7udMwU4uTphtqIb38Dqyk7UeFKaYArySI4t7Wz0v5NlhP7BTTZe9odlDpjsQFxJTIuCMZrri+NgGV O+T1uz3q7bgylksO6P24pUBrQP/5gZiJnuNy88LRND0OWhYicTXOeV1w71fcUfaYFM3nqJCY9Xicz hY6ATya9zvxxyjc93z98TCKLEDx0vdVUEXlpGpq39NhfCdAqPDPJL+yGEjIkx9wGXfbAzrcyizq94 NYAazMtgTHuaao84dg0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpZO9-0000000Asys-49qY; Wed, 27 Mar 2024 19:56:46 +0000 Received: from www522.your-server.de ([195.201.215.122]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpZO5-0000000Asxu-1lZ0; Wed, 27 Mar 2024 19:56:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=folker-schwesinger.de; s=default2212; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=PbW/dVoNioC9H6nvXtciGc7SM7HI15MyzienCfKIkR4=; b=VR8kDsBcDbAEnaXTexmEIWas1t b2KR+fJi/XsXdOE1V5MMnZVMxq+8uMaUz04wzmN+wb13IgLK02yZtNeDGVjG4pQ4+iBemvahrXXOK a/xmDMbSeXX0Yk6BIByz4W0CW7/q17x1DsyiZ0cm3FVdQ4PC16h7Y09OoYOfY19fi6Y7aDtSX5eFZ GE+u8lB2OrlJRt4fHmCWrFTJxLwXjnfRFFmmk9R14VMxi8vsH0qTPEAVsfnN49ILe0VQqDUYjC5mO GSpfupQcYcfrrzfGw2j3qWsENzLylLIXG0vNrUkEsfp+VhUcE2LlHSjKbXnNC2QDJzSVRC+Anc4nD Tu8HyuKw==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www522.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpYvT-000Isr-4F; Wed, 27 Mar 2024 20:27:07 +0100 Received: from [185.209.196.215] (helo=homedev.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpYvS-000Iyc-EA; Wed, 27 Mar 2024 20:27:06 +0100 From: Folker Schwesinger To: Vinod Koul , Yogesh Hegde , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Folker Schwesinger , Dragan Simic , Christopher Obbard , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/2] arm64: dts: rockchip: Add enable-strobe-pulldown to emmc phy on ROCK 4C+ Date: Wed, 27 Mar 2024 20:26:38 +0100 Message-ID: <20240327192641.14220-3-dev@folker-schwesinger.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327192641.14220-1-dev@folker-schwesinger.de> References: <20240327192641.14220-1-dev@folker-schwesinger.de> MIME-Version: 1.0 X-Authenticated-Sender: dev@folker-schwesinger.de X-Virus-Scanned: Clear (ClamAV 0.103.10/27227/Wed Mar 27 09:33:27 2024) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_125642_237849_0239F22F X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8b5c2b45b8f0 disabled the internal pull-down for the strobe line causing I/O errors in HS400 mode for various eMMC modules. Enable the internal strobe pull-down for the ROCK 4C+ board. Also re-enable HS400 mode, that was replaced with HS200 mode as a workaround for the stability issues in: 2bd1d2dd808c ("arm64: dts: rockchip: Disable HS400 for eMMC on ROCK 4C+"). Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") Signed-off-by: Folker Schwesinger Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts index 7baf9d1b22fd..972aea843afd 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts @@ -151,6 +151,7 @@ &cpu_b1 { }; &emmc_phy { + rockchip,enable-strobe-pulldown; status = "okay"; }; @@ -549,7 +550,8 @@ &saradc { &sdhci { max-frequency = <150000000>; bus-width = <8>; - mmc-hs200-1_8v; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; non-removable; status = "okay"; };