| Message ID | 20240402094200.4036076-1-s-vadapalli@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: k3-am62p-main: use eFuse MAC Address for CPSW3G Port 1 | expand |
On 02/04/24 15:12, Siddharth Vadapalli wrote: > Assign the MAC Address programmed in the eFuse registers as the default > MAC Address for CPSW3G MAC Port 1. Utilize the "ti,syscon-efuse" > device-tree property to do so. > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > --- > > This patch is based on linux-next tagged next-20240402. > > Regards, > Siddharth. > > arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > index 7337a9e13535..eb126f4a04dd 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > @@ -696,6 +696,7 @@ cpsw_port1: port@1 { > label = "port1"; > phys = <&phy_gmii_sel 1>; > mac-address = [00 00 00 00 00 00]; > + ti,syscon-efuse = <&wkup_conf 0x200>; Sorry, how does this work? wkup_conf is not marked as "syscon" compatible? > }; > > cpsw_port2: port@2 {
On Tue, Apr 02, 2024 at 03:25:41PM +0530, Vignesh Raghavendra wrote: > > > On 02/04/24 15:12, Siddharth Vadapalli wrote: > > Assign the MAC Address programmed in the eFuse registers as the default > > MAC Address for CPSW3G MAC Port 1. Utilize the "ti,syscon-efuse" > > device-tree property to do so. > > > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > > --- > > > > This patch is based on linux-next tagged next-20240402. > > > > Regards, > > Siddharth. > > > > arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > index 7337a9e13535..eb126f4a04dd 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > @@ -696,6 +696,7 @@ cpsw_port1: port@1 { > > label = "port1"; > > phys = <&phy_gmii_sel 1>; > > mac-address = [00 00 00 00 00 00]; > > + ti,syscon-efuse = <&wkup_conf 0x200>; > > Sorry, how does this work? wkup_conf is not marked as "syscon" compatible? Sorry I failed to realize that. So this will also require adding a custom property similar to: https://github.com/torvalds/linux/commit/cc1965b02d6cb18d9220dae06f7e2e0b0ebbea48 followed by adding a new sub-node within wkup_conf corresponding to the MAC Address CTRL_MMR registers. Thank you for reviewing the patch and pointing this out. Regards, Siddharth.
On Tue, Apr 02, 2024 at 04:02:07PM +0530, Siddharth Vadapalli wrote: > On Tue, Apr 02, 2024 at 03:25:41PM +0530, Vignesh Raghavendra wrote: > > > > > > On 02/04/24 15:12, Siddharth Vadapalli wrote: > > > Assign the MAC Address programmed in the eFuse registers as the default > > > MAC Address for CPSW3G MAC Port 1. Utilize the "ti,syscon-efuse" > > > device-tree property to do so. > > > > > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > > > --- > > > > > > This patch is based on linux-next tagged next-20240402. > > > > > > Regards, > > > Siddharth. > > > > > > arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > > index 7337a9e13535..eb126f4a04dd 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi > > > @@ -696,6 +696,7 @@ cpsw_port1: port@1 { > > > label = "port1"; > > > phys = <&phy_gmii_sel 1>; > > > mac-address = [00 00 00 00 00 00]; > > > + ti,syscon-efuse = <&wkup_conf 0x200>; > > > > Sorry, how does this work? wkup_conf is not marked as "syscon" compatible? > > Sorry I failed to realize that. So this will also require adding a > custom property similar to: > https://github.com/torvalds/linux/commit/cc1965b02d6cb18d9220dae06f7e2e0b0ebbea48 > followed by adding a new sub-node within wkup_conf corresponding to the > MAC Address CTRL_MMR registers. > > Thank you for reviewing the patch and pointing this out. I have posted the v2 patch at: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240404081845.622707-1-s-vadapalli@ti.com/ verifying that the MAC Address present in the CTRLMMR_MAC_IDx registers is assigned to the network interface corresponding to CPSW3G MAC Port 1. Regards, Siddharth.
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi index 7337a9e13535..eb126f4a04dd 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi @@ -696,6 +696,7 @@ cpsw_port1: port@1 { label = "port1"; phys = <&phy_gmii_sel 1>; mac-address = [00 00 00 00 00 00]; + ti,syscon-efuse = <&wkup_conf 0x200>; }; cpsw_port2: port@2 {
Assign the MAC Address programmed in the eFuse registers as the default MAC Address for CPSW3G MAC Port 1. Utilize the "ti,syscon-efuse" device-tree property to do so. Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> --- This patch is based on linux-next tagged next-20240402. Regards, Siddharth. arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 1 + 1 file changed, 1 insertion(+)