| Message ID | 20240402193355.2333597-1-tharvey@gateworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8m*-venice-gw7: Fix TPM schema violations | expand |
Hi Tim, On Tue, Apr 2, 2024 at 4:34 PM Tim Harvey <tharvey@gateworks.com> wrote: > > Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS > bindings"), several issues are reported by "make dtbs_check" for arm64 > devicetrees: > > The compatible property needs to contain the chip's name in addition to > the generic "tcg,tpm_tis-spi". > > tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short > from schema $id: > http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml# > > Fix these schema violations. > > Gateworks Venice uses an Atmel ATTPM20P: > https://trac.gateworks.com/wiki/tpm Thanks for the fix. Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Tue, Apr 02, 2024 at 12:33:55PM -0700, Tim Harvey wrote: > Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS > bindings"), several issues are reported by "make dtbs_check" for arm64 > devicetrees: > > The compatible property needs to contain the chip's name in addition to > the generic "tcg,tpm_tis-spi". > > tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short > from schema $id: > http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml# > > Fix these schema violations. > > Gateworks Venice uses an Atmel ATTPM20P: > https://trac.gateworks.com/wiki/tpm > > Cc: Lukas Wunner <lukas@wunner.de> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi index 41c966147b94..429be2bab8a2 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi @@ -57,7 +57,7 @@ &ecspi2 { status = "okay"; tpm@1 { - compatible = "tcg,tpm_tis-spi"; + compatible = "atmel,attpm20p", "tcg,tpm_tis-spi"; reg = <0x1>; spi-max-frequency = <36000000>; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts index 5e2cbaf27e0f..35ae0faa815b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts @@ -297,7 +297,7 @@ flash@0 { }; tpm@1 { - compatible = "tcg,tpm_tis-spi"; + compatible = "atmel,attpm20p", "tcg,tpm_tis-spi"; reg = <0x1>; spi-max-frequency = <36000000>; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi index e7bf032265e0..2f740d74707b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -68,7 +68,7 @@ &ecspi2 { status = "okay"; tpm@1 { - compatible = "tcg,tpm_tis-spi"; + compatible = "atmel,attpm20p", "tcg,tpm_tis-spi"; reg = <0x1>; spi-max-frequency = <36000000>; };
Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS bindings"), several issues are reported by "make dtbs_check" for arm64 devicetrees: The compatible property needs to contain the chip's name in addition to the generic "tcg,tpm_tis-spi". tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml# Fix these schema violations. Gateworks Venice uses an Atmel ATTPM20P: https://trac.gateworks.com/wiki/tpm Cc: Lukas Wunner <lukas@wunner.de> Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 +- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)