| Message ID | 20240408125506.1594257-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: mtk-socinfo: select CONFIG_SOC_BUS | expand |
Il 08/04/24 14:55, Arnd Bergmann ha scritto: > From: Arnd Bergmann <arnd@arndb.de> > > This is needed to avoid a link failure: > > ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > > Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hi, On Mon, Apr 08, 2024 at 02:55:00PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This is needed to avoid a link failure: > > ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > I've tried to take care of this in the exact same way a long time ago. Don't ask me why it didn't find it's way into stable yet https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/ Cheers Daniel > Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/soc/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index 50c664b65f4d..1b7afb19ccd6 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -72,6 +72,7 @@ config MTK_SOCINFO > tristate "MediaTek SoC Information" > default y > depends on NVMEM_MTK_EFUSE > + select SOC_BUS > help > The MediaTek SoC Information (mtk-socinfo) driver provides > information about the SoC to the userspace including the > -- > 2.39.2 > >
Il 08/04/24 14:59, Daniel Golle ha scritto: > Hi, > > On Mon, Apr 08, 2024 at 02:55:00PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> This is needed to avoid a link failure: >> >> ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! >> ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! >> > > I've tried to take care of this in the exact same way a long time > ago. Don't ask me why it didn't find it's way into stable yet > > https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/ > > Sorry, went out of my radar for reasons. Your commit should take precedence. Angelo > Cheers > > > Daniel > >> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/soc/mediatek/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig >> index 50c664b65f4d..1b7afb19ccd6 100644 >> --- a/drivers/soc/mediatek/Kconfig >> +++ b/drivers/soc/mediatek/Kconfig >> @@ -72,6 +72,7 @@ config MTK_SOCINFO >> tristate "MediaTek SoC Information" >> default y >> depends on NVMEM_MTK_EFUSE >> + select SOC_BUS >> help >> The MediaTek SoC Information (mtk-socinfo) driver provides >> information about the SoC to the userspace including the >> -- >> 2.39.2 >> >>
diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig index 50c664b65f4d..1b7afb19ccd6 100644 --- a/drivers/soc/mediatek/Kconfig +++ b/drivers/soc/mediatek/Kconfig @@ -72,6 +72,7 @@ config MTK_SOCINFO tristate "MediaTek SoC Information" default y depends on NVMEM_MTK_EFUSE + select SOC_BUS help The MediaTek SoC Information (mtk-socinfo) driver provides information about the SoC to the userspace including the