From patchwork Wed Apr 10 11:24:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D21EDCD11C2 for ; Wed, 10 Apr 2024 11:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1GkHu73AfB1Y0ZDv2sNIdn1FAbhu2RMwp0wB/MX8siU=; b=b8XBDSICSTt4OG 8Cqy8n/jj8bXUqRJOAUHV3F4igLqnXc2ES9EKBLVOKM7rcXHM+tHXLvXfiUFgcXi+rZqyblt4JgM7 8/BBMPwX7USAIyQrZcrbRL1yPKSBgk+WVJbFIMCqCfCSAuB8caYEe+uzuiFAOVUbau7GLP8E0y/g4 gjiubrmUBBhWHSG1DNDDQ9xa/1esZk/PaBZdh58i9nZ0reMnbWtLlbs5tMrrUk7FvPacq8ROmrUIf lNmrFr9xn55CTamWhSnSvvetZnM+hi6eJt4azloV/NQ5dT6ZZRcjMRFIZ2QIAPWOTRKp/t1/2sIXP 0LOhUvlecK/W3OA4cQbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5F-00000006bVB-2hZY; Wed, 10 Apr 2024 11:25:41 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4m-00000006bDG-1c2J for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=hD8uz8cN1ScOd8WPchdst4mxCACdD20Wmh45ImGI/X8=; b=a6oVtx Bh1gvv6bITBD1Cz3DUhfELjmFMxhEhR+AHoeksfm5KrUSRVeoTQikoU/us2SJR36 rqhzW6yJBUHl7MfBms5eST+3Y5CC5UJ1MuHezo3gp8VXpRwwjOOg/8rhgsMCskuF 4kgy7RaL4OCO2tK/P8srJT2kFViURleSD/lh+JjCUqSVLQCTDpHLB0ve+pzwFifE Pyz8EWOzPRxhwJj0gt3aNTVOi+tPxvtNMLR9t/vS/RZmprV/kWIG/G7cE4I5fTp5 gzwrWLO2uV0sO78yYo2yAFoG6TXLqyFhb2BMuq7eorRE5aoF/PYcKhXZzZXokYVg 61UO01t9i8Cf5lpQ== Received: (qmail 521473 invoked from network); 10 Apr 2024 13:25:02 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:02 +0200 X-UD-Smtp-Session: l3s3148p1@iO4iSrwVDyBtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Michal Simek , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/18] i2c: cadence: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:18 +0200 Message-ID: <20240410112418.6400-24-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042513_216205_FD72AF6F X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Acked-by: Michal Simek --- drivers/i2c/busses/i2c-cadence.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index 4bb7d6756947..1b0006e3b95c 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -789,8 +789,6 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg, time_left = wait_for_completion_timeout(&id->xfer_done, msg_timeout); if (time_left == 0) { cdns_i2c_master_reset(adap); - dev_err(id->adap.dev.parent, - "timeout waiting on completion\n"); return -ETIMEDOUT; }