From patchwork Wed Apr 10 11:24:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B6BDCD11C2 for ; Wed, 10 Apr 2024 11:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZxNZxfL/m1lO2lpm+ezsRBQWXdaGdwiHfMaQUa0vi8w=; b=Thjto8EoFseELa +gPJUkWiVcMSEJtgoD+iQZ7x+E/J5VeyaGYCx0a8r51tcyju8nyoeXGlrNwhHpH1rHzeK93fS1e7m rZbzTvvRtkMXqZrCCJHJtTTEP8DHmLLH2mAllHn+ygI55Rx3UllAShNe8lu1EomSRAj6xdynEXUc7 bKtKHplLzTKpBNI9EVqrtQtfmuTAP1Bylkvz2xMnVS5U//djMbVAAxYdkGjlFi5mjpUXeoCapAiZv et5BRTw8NM5GCswPT37H1PDpf1SOtLnkGYDii6rBbOeTibdMt4UIXD8t1oEV7lT/32B6pYtkcmIE9 UFnW7eZV91nKN1+7NqlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5L-00000006ba9-1H8p; Wed, 10 Apr 2024 11:25:47 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4q-00000006bFL-0BEz for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=3esuL+DU1erk/gYHtm2gF1OBGVxFNyh1r/SypUa9yCM=; b=Vr6qAr 8iFkO2wOh0d1gYTcxzNKRyDBqot/1ghiSOBRenx8UjsO+5PnOwwgoljk8Bs/UjIQ kbTetXqSgGkGWju9mEG5XkPttMpOltFo8bPzQwTAte/ly+rE108AWwHLP8sAtiZj diJblVIrmuAlp9n2ASvIDo9yY7FXDSOFWXfHqJ4sNFcPO3D/2OiY4q+t4uqm0e/f q8QmDwWXO42uR8VA1W5j5/WFcbOq6LzMSrn3wvZ5jYrLQM+c1XQhE3zlg2+bLwYP zgG8WxIPhfFPh0+uULC/GQpyFKVXQQUW+QiQkzK3WqGAGQ4YeBeVzrIJJ6N8Woqp N96as7wrkefpS4xA== Received: (qmail 521590 invoked from network); 10 Apr 2024 13:25:08 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:08 +0200 X-UD-Smtp-Session: l3s3148p1@YCV+SrwVeGJtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Linus Walleij , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/18] i2c: nomadik: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:23 +0200 Message-ID: <20240410112418.6400-29-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042516_436173_F0A9323A X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Linus Walleij --- drivers/i2c/busses/i2c-nomadik.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 4f41a3c7824d..45c6df26fcbf 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -542,12 +542,9 @@ static int read_i2c(struct nmk_i2c_dev *priv, u16 flags) xfer_done = nmk_i2c_wait_xfer_done(priv); - if (!xfer_done) { - /* Controller timed out */ - dev_err(&priv->adev->dev, "read from slave 0x%x timed out\n", - priv->cli.slave_adr); + if (!xfer_done) status = -ETIMEDOUT; - } + return status; }