From patchwork Mon Apr 15 16:05:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 13630256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55941C00A94 for ; Mon, 15 Apr 2024 16:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SFlSsAYyLEBfb1HEroK/yyQP1sLYcJ2A8nTfHMOYwXU=; b=FgHdQVAX1iqYcq FesleJqBM2F6QpmR5SzjfLTO6M69cnJWMP9WWoVvDlzAVV3wfi+JAUwU6Q200b+/D8YaXvtLQVNHI WiB5BKlggpQh+HGFRQyqKIdJJdLHwRPnB1j3BYQqavjtkAmzZ5AA0SgdRbFCG+QLEOtsxu0Y7mmMP a/IUMSKs3bw3Bil57IjiOWhJ3lKysk6Oua6sbpjExVTFQqT5VYCRJM22j67rLO7UVTVaOs/Cpp8VT i3+z6x0CL9m6eT1NcrZJV/9uWXWJvzNy3w53mqHKf1b07JuM1SHuF+FZIDjvhfkJgC0rGbUz7k/NU mNvADTr3i4qWXuBWYe4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOqB-00000008zSA-3rsL; Mon, 15 Apr 2024 16:05:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOq1-00000008zOu-1KIc for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 16:05:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37B1E150C; Mon, 15 Apr 2024 09:06:13 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D84743F64C; Mon, 15 Apr 2024 09:05:43 -0700 (PDT) From: Sudeep Holla Date: Mon, 15 Apr 2024 17:05:24 +0100 Subject: [PATCH 3/4] firmware: arm_ffa: Check if receiving notifications are supported before sending MIME-Version: 1.0 Message-Id: <20240415-ffa_msg2_support-v1-3-a28c964b1b3f@arm.com> References: <20240415-ffa_msg2_support-v1-0-a28c964b1b3f@arm.com> In-Reply-To: <20240415-ffa_msg2_support-v1-0-a28c964b1b3f@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: Marc Bonnici , Olivier Deprez , Lorenzo Pieralisi , Bertrand Marquis , Jens Wiklander , Sudeep Holla X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1663; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=9mGNZxQu9HhTBRnPpfJ5d+3rs2D7y9hofOuhi+wmp+4=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBmHVBUJaM6cwbumPIkVczmTxsz5pkfZ+5S+7wXi LC8MnyKFrGJAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZh1QVAAKCRAAQbq8MX7i mA8uD/9nEZjZZz4/ZBfBIorFdNWSpWnjNP1p/s/fjUIxyQ5pG8SECb0cORc3sDagM5WzJPjd2ok p4EyDN/Bh28xbcQaI3bbCKaOcqcX83ZZUR1zQOjFwBeEninJHqSclTZOqFM9YcAU2MKteUPo6VH rE/fEx2fS4HeTqZThOxbW/eXjM2hxSqKqPczETmwuakRnTv8LfywlUmpwsvjjH6LsS5WbVG6bg/ dmLsvUv84D9hlJSeevN0Rd3T/IZT5zyj+hoUmp9FvxkNtN0LOCGmu43erbEf7qkI2aEAfZUnTGP u6D0V3OEMSOfySCsGimlb7obtrXnuZm7YCoeyvbuHdTwmsZ+DBaSHfRr24NVjvznDDkKc9Atez/ Ois6+mPKsQq3xVoOPC95YVKFSEyPkb3+p08u5gw56/WnhKLyUIrDjX4Sb0NuJIUpAVwBErwlytK 46fhVJ2wWDEwCwoHpf/iZnCbDVR1eKYAvWNjCZNtKlkWvnDJlRHbPqOhxH8Jlec6/f001tJd8qx xzntd22fP9N7LmRrv3zlkcU/vuMakyY/bQMZM55ZF1TAD6UsUHn8j49Sy1BasQSbAXk2Zl3JbXY TfrxjWVu+3yt183FtzcRcQuiudojQ+R9YXllmTUgBPNA3JfGoJL9EDozYSUBaV7IFMO9V3YA8E8 DAaTkyQI0YuP67A== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_090545_431840_1AC6F9B7 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add check to see if the target partition can receive the notifications before sending any notifications to the partition. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 6 +++++- include/linux/arm_ffa.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 52379885a403..d5087e4f6d35 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1092,12 +1092,16 @@ static int ffa_notify_request(struct ffa_device *dev, bool is_per_vcpu, return rc; } +#define ffa_partition_supports_notify_recv(dev) \ + ffa_partition_check_property(dev, FFA_PARTITION_NOTIFICATION_RECV) + static int ffa_notify_send(struct ffa_device *dev, int notify_id, bool is_per_vcpu, u16 vcpu) { u32 flags = 0; - if (ffa_notifications_disabled()) + if (ffa_notifications_disabled() || + !ffa_partition_supports_notify_recv(dev)) return -EOPNOTSUPP; if (is_per_vcpu) diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index c906f666ff5d..13830be5851d 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -221,6 +221,8 @@ struct ffa_partition_info { #define FFA_PARTITION_DIRECT_SEND BIT(1) /* partition can send and receive indirect messages. */ #define FFA_PARTITION_INDIRECT_MSG BIT(2) +/* partition can receive notifications */ +#define FFA_PARTITION_NOTIFICATION_RECV BIT(3) /* partition runs in the AArch64 execution state. */ #define FFA_PARTITION_AARCH64_EXEC BIT(8) u32 properties;