From patchwork Mon Apr 15 16:05:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 13630252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB175C00A94 for ; Mon, 15 Apr 2024 16:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9ZNkfp5Ms7PCdjaw26Hb9K/npkkdBYAP1dYSDXBkhQ=; b=0RzD2przO2tjf1 IeFseBd4QUneqCHHo+AuUUflL4VpqjbGqPyvTuyJAt1XubwDhcASw2QziyDZ5hllSEW4ZOu69GyAx wWRhd0M13tYF1PRSX5j+wcKjo4KAjeyRX69AJrUAMF2ubUyAH8pSlaPUwY5yS0uxgAXQSsE+GBTaC eUaZt5kYvEwv3MpR+MUtwTUweTBCdk7xrVZkJNwah+W7KV+/ErLJFbl0g2rwfNWFpGb8cfMAnlMOt nzg4CdXIgtT0+HV3cQ1c5gEKKAuKYjfxGSwieXoPjCf7m71JAZFTroFnCSfX10VPgXqcG1vJXvmdF N/vVISUu/CCs4zYgUOEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOqC-00000008zSb-2t5y; Mon, 15 Apr 2024 16:05:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOq5-00000008zQ8-2t2k for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 16:05:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B82C1515; Mon, 15 Apr 2024 09:06:14 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB19D3F64C; Mon, 15 Apr 2024 09:05:44 -0700 (PDT) From: Sudeep Holla Date: Mon, 15 Apr 2024 17:05:25 +0100 Subject: [PATCH 4/4] firmware: arm_ffa: Add support for FFA_MSG_SEND2 MIME-Version: 1.0 Message-Id: <20240415-ffa_msg2_support-v1-4-a28c964b1b3f@arm.com> References: <20240415-ffa_msg2_support-v1-0-a28c964b1b3f@arm.com> In-Reply-To: <20240415-ffa_msg2_support-v1-0-a28c964b1b3f@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: Marc Bonnici , Olivier Deprez , Lorenzo Pieralisi , Bertrand Marquis , Jens Wiklander , Sudeep Holla X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3720; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=j0t2yCqDDE/TbLnCOqfhb8D15PznKfc/QqPqYhCdXTY=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBmHVBUeAiaeTCY0HZFe/n+K0sm4u4YBJwo/f9f3 8XVo+bdyJ6JAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZh1QVAAKCRAAQbq8MX7i mEjlEACMgLhF3MP7FWlgMLbnf9IZjjXxWO5JfqUaxbJZk46n+en+fTmrOj7S48sEcMShdJN/fMR rCjR3j0ujBAHNCgvf8NqTFmmggFVtgQl+6lPeDVWMhk/ZEnirL9o1dCgESnXpIVaD19pGR59M1m k0P6u3FaKZxOImdrcSIls2r39DnON+bPMByPEx2wQzNiETxr1b55pf/o1Ia2136SWph+IMqItWz ynSnFwFVCbO+hbK0Oego+FW72n1KpWp9FeWOf5m9WkJ1P3N+H/sOoMgJLvJcRzhncThkxdVY4MY IvBl9J/TKMplhbu6dsuBkXBvHm7K+m6g4Vmm9L6lXaWkWoTe9+HUzpXh1QTx6wL6naqrw4fDujD fP0+FxvGOjE8egBZK5bVsB+wtMUXPoEljFfnTaIFrztM6DkX8Kh1BTtR0n65iIW5MtB+xKse2Xh jNI3UA3IYoCMJYHc6fghVIlBso2haqrDkqa189X5A/U+t2PK8isbIjsanxDwiV+zOA2sks7I6XP RhEcZ66+2G16GIVzMJ6uCaUJVYWkZXmSNVpIgg0ZAjyg74Iyma+aO/5OLf/icHK+SMchunHSOmN WDkcyB8XjFsn2305UHbXR+YvHXsx780GVSXuycQ0OLpklg4VTOQ7c7Kq/5hXsReFMn+jz0EbPMc 7box5PfavMjq1Pw== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_090549_859998_12715408 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The FFA_MSG_SEND2 can be used to transmit a partition message from the Tx buffer of the sender(the driver in this case) endpoint to the Rx buffer of the receiver endpoint. An invocation of the FFA_MSG_SEND2 transfers the ownership to the receiver endpoint(or any intermediate consumer). Completion of an FFA_MSG_SEND2 invocation transfers the ownership back to the sender endpoint. The framework defines the FFA_MSG_SEND2 interface to transmit a partition message from the Tx buffer of the sender to the Rx buffer of a receiver and inform the scheduler that the receiver must be run. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 40 +++++++++++++++++++++++++++++++++++++++ include/linux/arm_ffa.h | 9 +++++++++ 2 files changed, 49 insertions(+) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index d5087e4f6d35..6c2602f7e7cc 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -344,6 +344,34 @@ static int ffa_msg_send_direct_req(u16 src_id, u16 dst_id, bool mode_32bit, return -EINVAL; } +static int ffa_msg_send2(u16 src_id, u16 dst_id, void *buf, size_t sz) +{ + u32 src_dst_ids = PACK_TARGET_INFO(src_id, dst_id); + struct ffa_indirect_msg_hdr *msg; + ffa_value_t ret; + + mutex_lock(&drv_info->tx_lock); + + msg = drv_info->tx_buffer; + msg->flags = 0; + msg->res0 = 0; + msg->offset = sizeof(*msg); + msg->send_recv_id = src_dst_ids; + msg->size = sz; + memcpy(msg + msg->offset, buf, sz); + + /* flags = 0, sender VMID = 0 works for both physical/virtual NS */ + invoke_ffa_fn((ffa_value_t){ + .a0 = FFA_MSG_SEND2, .a1 = 0, .a2 = 0 + }, &ret); + + if (ret.a0 == FFA_ERROR) + return ffa_to_linux_errno((int)ret.a2); + + mutex_lock(&drv_info->tx_lock); + return 0; +} + static int ffa_mem_first_frag(u32 func_id, phys_addr_t buf, u32 buf_sz, u32 frag_len, u32 len, u64 *handle) { @@ -888,6 +916,17 @@ static int ffa_sync_send_receive(struct ffa_device *dev, dev->mode_32bit, data); } +#define ffa_partition_supports_indirect_msg(dev) \ + ffa_partition_check_property(dev, FFA_PARTITION_INDIRECT_MSG) + +static int ffa_indirect_msg_send(struct ffa_device *dev, void *buf, size_t sz) +{ + if (!ffa_partition_supports_direct_recv(dev)) + return -EOPNOTSUPP; + + return ffa_msg_send2(drv_info->vm_id, dev->vm_id, buf, sz); +} + static int ffa_memory_share(struct ffa_mem_ops_args *args) { if (drv_info->mem_ops_native) @@ -1167,6 +1206,7 @@ static const struct ffa_info_ops ffa_drv_info_ops = { static const struct ffa_msg_ops ffa_drv_msg_ops = { .mode_32bit_set = ffa_mode_32bit_set, .sync_send_receive = ffa_sync_send_receive, + .indirect_send = ffa_indirect_msg_send, }; static const struct ffa_mem_ops ffa_drv_mem_ops = { diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index 13830be5851d..d61a6df397f6 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -238,6 +238,14 @@ struct ffa_send_direct_data { unsigned long data4; /* w7/x7 */ }; +struct ffa_indirect_msg_hdr { + u32 flags; + u32 res0; + u32 offset; + u32 send_recv_id; + u32 size; +}; + struct ffa_mem_region_addr_range { /* The base IPA of the constituent memory region, aligned to 4 kiB */ u64 address; @@ -398,6 +406,7 @@ struct ffa_msg_ops { void (*mode_32bit_set)(struct ffa_device *dev); int (*sync_send_receive)(struct ffa_device *dev, struct ffa_send_direct_data *data); + int (*indirect_send)(struct ffa_device *dev, void *buf, size_t sz); }; struct ffa_mem_ops {