From patchwork Mon Apr 15 19:34:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81084C00A94 for ; Mon, 15 Apr 2024 19:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oZsBZVwyuZNFt5oy/bIrkQB1eClNiib2DqKmCNPhJQU=; b=A3jIT/h5o650lY CO9RVtBTY3WzmZ+ahV/gGOETqCaC70gLr7uzT+eCgWkO1BtThtbV3dg8hbferhxYdfpSkbweReP8v JPpT3oouugsPQ8VVDDty/age6U6zNORs+BQOg3xsHiEWmQZUwldKBs0iCG6NMcKM8zqvVlYmgEvWV KzhK8g4L0MiO+6/x5ORrNV2g/DhMyYiTlSFQvPg4y6YJpOnkaz8vCWE8XLvTNac+V2QXUHjQNsn8c dg8hnwOSP3rDSM31W8yl00rn/qKv7owcHuGBxc0zabfwzAWIdzclXzpWslz0BUawp3Df0GuGHOiqb iHowDRj84cgMyiyKv//w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSBD-00000009f4z-0Fk5; Mon, 15 Apr 2024 19:39:51 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6S-00000009cAN-31cZ for linux-arm-kernel@bombadil.infradead.org; Mon, 15 Apr 2024 19:34:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=VYb6g5i4FA16yMs6Dul0lviXONeB+8pR0V9zyRVb51o=; b=gQAXb5zNTNnMUNNL9bTaVY/iM+ pQOAdkD9FTZkwjbuvQHN6uwj9IX9jMGtJ7EyJaygCQDe/vqkqbgdr7bzgLklEQZtXQTj7zVmSx9Tr 84cqzQurwrOjUk6YqNd9r7P2M5T8fg53GJL8xsjba85YMbvXZtspFxQ9JlsIKzIEQtBx+gU4eEd69 BXEararuggPTnLObtmzY0jHVUFv0S0BcoEYFxT9FJZcMgYbkcqaTgoBlAsEZenXwFq3O0s8NE1Yh9 QbcXkht2Lsx/bdMbwdfVB40iDcIXQ+7tYGj0YPTzQrCUErcbC5cEEJHgM8gcxUEBL9PseSRFPuSUd Nn7csqOg==; Received: from mail-yw1-x1129.google.com ([2607:f8b0:4864:20::1129]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6O-0000000GMte-2vle for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:34:55 +0000 Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-61816fc256dso31275877b3.0 for ; Mon, 15 Apr 2024 12:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209688; x=1713814488; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VYb6g5i4FA16yMs6Dul0lviXONeB+8pR0V9zyRVb51o=; b=eAALKokadjNbcLW5OcmvZcKpBWsVNS8BEZNKVdlQgbOQBbaSG7TFsQKwZ46+y7lRzW BnSgx3MEFPhxN2UGNm0ObINNesyObzbSQJvFCUuvJ4aELVnhYyPuUo1qRQsY4vx5s+to 8UOypdehnuZS9SzKOux8wD7D6xPJztFywKB0Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209688; x=1713814488; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VYb6g5i4FA16yMs6Dul0lviXONeB+8pR0V9zyRVb51o=; b=KGo/IPtvpuDcBVUEzkwhkdpqQsA7MrqiLnT7uvzvqp3AGh/BshwWAyMv27lt5s9VYi cwfVs3/Iuj0MhkzDkXR/eK2i9fsLKvdrVt8x2+f07WbTZYJNGUeyVUcc2poqjHaexIAu g2H5rLlYV6uWuICYG6aRGjRopUS9G1mPAkqWx4iuh16Dxshm+XCj2J8tk1gLzMpGglgN vk8zqJWJB0a6tZXBde/r/eVtk3+HkQc+5QZHlbHGEosWiBdQJBz5hREHN/2eSOFcxLan hORh5jKsqY3khpr1sPGFz+s+G0Csapx64ge5leszCiT9QuwizWIxPc923gVHZZdpW32V UuuA== X-Forwarded-Encrypted: i=1; AJvYcCW/83X1b2jvDBvMhs58dzhLyEn9LdHjfFhVAWqTzqjuuoXmT4QjFiHK1YlUTeXVKGW89zZkEHUN1ziBbx6Q9VTwxP+KwiXTCt9dlwcgZNmU8NPTbhU= X-Gm-Message-State: AOJu0YzcquB5vDVSroGRNIP+ebhkmc4mEi4n1q0+KgkgjwpShqbP/4nF OoFvf3pD7ZSc5wm3CT48OkvJPJs/Qx9pYHnvVKWSoSrwJ0M39VazpEF1pEp3Dg== X-Google-Smtp-Source: AGHT+IHXF7TrtarHgpunekvNDs6nvd1JJs+Lc0bh8dwb/yJrFpFk4KNuzD4FvIVwGteAAQA7ZBlIRw== X-Received: by 2002:a0d:cd01:0:b0:618:875e:2bc1 with SMTP id p1-20020a0dcd01000000b00618875e2bc1mr8806798ywd.21.1713209686523; Mon, 15 Apr 2024 12:34:46 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:34:46 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:33 +0000 Subject: [PATCH 16/35] media: au0828: Use min macro MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-16-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_203452_791932_240D40C9 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplifies the code. Found by cocci: drivers/media/usb/au0828/au0828-video.c:605:11-12: WARNING opportunity for min() Signed-off-by: Ricardo Ribalda --- drivers/media/usb/au0828/au0828-video.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index fd9fc43d47e0..2ec49ea479d5 100644 --- a/drivers/media/usb/au0828/au0828-video.c +++ b/drivers/media/usb/au0828/au0828-video.c @@ -602,10 +602,7 @@ static inline int au0828_isoc_copy(struct au0828_dev *dev, struct urb *urb) vbi_field_size = dev->vbi_width * dev->vbi_height * 2; if (dev->vbi_read < vbi_field_size) { remain = vbi_field_size - dev->vbi_read; - if (len < remain) - lencopy = len; - else - lencopy = remain; + lencopy = umin(len, remain); if (vbi_buf != NULL) au0828_copy_vbi(dev, vbi_dma_q, vbi_buf, p,