From patchwork Mon Apr 15 19:34:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48523C00A94 for ; Mon, 15 Apr 2024 19:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0TdHgSaDiCs1c4K/m/8T+9BFpj6G3W3jx8k8PPuc7ko=; b=B/yv5ykQEH4ECB xz6r3djB3/DaiIpOOZMn8XaFoalDgoakQitr+7ZnRg+oOibLyG2nF2EuPBDLBAyjdEus97Eo7lbJy Nw4GDKOkN+v4ZiRTE3c0EgZmgJXwIyxoyAS0x+ZxRTFlfs1/goPxTP4K01mqM0sbfZyd+ZOIzw2qw d8sxEAYkUT1V4c5fEAlwyMvpNlrqxS8k+YyoYUkyNz+gR919NYy+ETAt6twnTvyjkW9lrW+IUSJ2g lJZnp5bOZM2XgnjRGiZE88ppvIB4E5BgfNyifdDnKrZshP5F2tR7h0aezME9em7eQwnHrC0fXaM23 UDoQlXrlydZNEeHK1kJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSBF-00000009f6e-1xCI; Mon, 15 Apr 2024 19:39:53 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6T-00000009cA7-0trS for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:34:59 +0000 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6eb7d1a5d39so1007943a34.2 for ; Mon, 15 Apr 2024 12:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209695; x=1713814495; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QeRLp7zsOtUSdDFmgCUblI9njYJR1iKxSTZ/4ILbF+w=; b=BiH0OFMokANpupNxOxnsbd/u/XWAKQHEli9550JBHXJNGF65nVeWf0922ErwXNUoF6 Iyn/5qFQBpmpB2iZhJbS2kNZJ5XQPYpXF6qEg92pwYDG+NMNDYwsgAgFcXZ7NYREVMdY qkCl420YfcfuTZjeI75wop9l1LW2DQ8GAdDLI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209695; x=1713814495; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QeRLp7zsOtUSdDFmgCUblI9njYJR1iKxSTZ/4ILbF+w=; b=KO64HviabNBaRI7QfiRSLMkBhpmPf5GwUExSpa+xJbOTjIJuIXIW0OyRi8Q1sry4oW V5luJulCcioPkQpIwC1/8En4pNirM6OEmUu4SI5u6cUG2S71tdt3ZP+kiGLgfK8uFBD+ ZvGfuRGaJSyWapBNmW9g0G7iHp0uQkyzkTsQWlbm2ItGeAQhR1kscrQipznijjjjRuKx raLCkh3XFlSmT/ZlNur6yM5SZ8baDr98gmWxqCvbH9UEmgNbmULjoy+9OnP0APazecD4 boSE9cIxhLugt4uhXFpDreLIF6jABtpNHSEkL5DQMAwavYvb71vYuXom9/DjxcpVn2dy zFdw== X-Forwarded-Encrypted: i=1; AJvYcCVQxxbyM1xIMemEhgIwNiTqvSXTXOVBqrC+85NAVwNIdf44s1ijSWK+zulh6DC5X4Ru0GJg+VEiYWk+L0D8nEAZAIMyxHzzD7bkNiiD5zUR4adxqFs= X-Gm-Message-State: AOJu0Yy4ud75vSpWXhvlaLylh2E0u02RarV4f4498B8KEtQsT4RmbTv5 GyMwdoZdCVRqQJuIwv1ce4meTunxtbmKEgCmp7JIvOl0L8DIsHyUPXyt/0IxtQ== X-Google-Smtp-Source: AGHT+IFsqXR5fSRZnzm1Kf6aaPblaNqmPYRQpJrXNEFCJBpTElAi4AncAaUAPBA9CFnD3PK/w6M+nA== X-Received: by 2002:a9d:748b:0:b0:6eb:7d1c:f793 with SMTP id t11-20020a9d748b000000b006eb7d1cf793mr4227322otk.31.1713209695186; Mon, 15 Apr 2024 12:34:55 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:34:54 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:41 +0000 Subject: [PATCH 24/35] media: tc358746: Use the correct div_ function MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-24-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_123457_324674_673FCD98 X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org fin does not fit in 32 bits in some arches. Found by cocci: drivers/media/i2c/tc358746.c:847:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/tc358746.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c index d676adc4401b..edf79107adc5 100644 --- a/drivers/media/i2c/tc358746.c +++ b/drivers/media/i2c/tc358746.c @@ -844,8 +844,7 @@ static unsigned long tc358746_find_pll_settings(struct tc358746 *tc358746, continue; tmp = fout * postdiv; - do_div(tmp, fin); - mul = tmp; + mul = div64_ul(tmp, fin); if (mul > 511) continue;