From patchwork Mon Apr 15 19:34:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E02C04FF9 for ; Mon, 15 Apr 2024 19:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgbAnhJq3yHqLDiATJzdHp8Z0F1LrpW+p+agS19/c7Y=; b=RUzYxV3HrTPFse ZaltT5uLb9beTLjbFCpeKjMFISYTvnTd8FzBiXmGov3MTD2T2Ee/6Hi+8FpnOpxbEZgfCHQOjeEAa KwfKAXamYYnmqCY9kAJ6l0vUBKmQvIkm2a7q1wZl9YVlvmg+9HJiGSATlssN6q5WZ61SYvNJzfh1e ec+FN6Yy9pMiWe87wgJIZaaqviZ1YkKYVBbP7okz65/NykC+tzOdXx2R6HgFzfwfHHiDOeVgJEMAH i20B9MiupsikA2bR980Y6bFzqidHSoxyM7zOr4FnR/EKN7iRWNAjl4nxoURXpwQKnBckSJlE+ZXYP IycTRi6pp/ErUQ+dS8Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS9o-00000009eF0-0Zwa; Mon, 15 Apr 2024 19:38:24 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6X-00000009cGH-2Was for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:35:04 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-78d77b309f2so322302885a.2 for ; Mon, 15 Apr 2024 12:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209700; x=1713814500; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OhmQYYxWMuudLBjdJjOGHKHYUzO1QQEhFUDY1X02X9Q=; b=HrfTteglxyjYgJrQpM/uK9qRGM3um1b+1G6AO+tbkd4NKk59ohy0rNXHP3UXv8d0NU Ym3CSmNXDvnhPA1UMrpYrOu5LaUTxuwHwvd6w0x4m0xB+Ap+6OhAhj6xusZCxXrInrae T6t6Xg/XF/iGMTS2a4ANPAmstuNwAa7rJUX3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209700; x=1713814500; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OhmQYYxWMuudLBjdJjOGHKHYUzO1QQEhFUDY1X02X9Q=; b=VUIIWNOWPlqPpuTJKKgT6eHPJoGbXivVoLhyx+jWmV/40blrBGJwF0msIEO9A5v3DO OLY2O1T1zNo58p26rrSiV9HMnpEfYUD06OfczQ4Z4U67dOsxoe/WgkSlI9WUx/XuLMWv cPecmE8UUGTZtL4Ui3D53hk+h6538tOAoumYASSNIshHzrfy16pmZ8xbCEu5BJ9CVKPQ RjNbmjXoCKNyoDTs14bkE0ugfcKLxVFvxSmkdWaAj8CrVeLR7shURZ/8JkzYJe50/eNF KLSB5u29PSN8NDb3/Jom3D/LZRK3aMRhKHxncka3IJDeuT3WKhrCkfBf/XQu1uW8Ag8n JQ3w== X-Forwarded-Encrypted: i=1; AJvYcCWfoXd2zo8uA+i9VeLcHzBxIkm9Z15JvZkktrIbaX77rZJr8meCDDNpKgm774lr0cBRGdU9C/TVPQWxVIobeeKw9cOY6+WIGV9mNTL7BEeF+i3wia4= X-Gm-Message-State: AOJu0YwtA3gPgtDAJ2gsOM3XmNEhzJo3H7FC2zHGJZGuogwLkT77EaPk PW0CYuTVpzOkIysiSJ++KQ9GMbUayZYjns8WkEbtLEmWvA5hG946P8K3VVkzIQ== X-Google-Smtp-Source: AGHT+IExc3kiGm+hEFRw+kQDfViul4woHzF6WRs96subTZ4c8qoJuWqvczLaOhJGq/Hyw06BNYyVfg== X-Received: by 2002:a05:620a:3182:b0:78e:dcc4:339e with SMTP id bi2-20020a05620a318200b0078edcc4339emr7592795qkb.11.1713209700585; Mon, 15 Apr 2024 12:35:00 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:35:00 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:46 +0000 Subject: [PATCH 29/35] media: i2c: rdacm20: Refator return path MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-29-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_123502_125056_BBEB52DB X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a nop, but let cocci now that this is not a good candidate for min() drivers/media/i2c/rdacm20.c:363:12-13: WARNING opportunity for min() Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/rdacm20.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c index b4647bda8c21..b40d40b0cdd4 100644 --- a/drivers/media/i2c/rdacm20.c +++ b/drivers/media/i2c/rdacm20.c @@ -360,7 +360,10 @@ static int __ov10635_write(struct rdacm20_device *dev, u16 reg, u8 val) dev_dbg(dev->dev, "%s(0x%04x, 0x%02x)\n", __func__, reg, val); ret = i2c_master_send(dev->sensor, buf, 3); - return ret < 0 ? ret : 0; + + if (ret < 0) + return ret; + return 0; } static int ov10635_write(struct rdacm20_device *dev, u16 reg, u8 val)