From patchwork Wed Apr 17 04:44:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13632861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8273BC4345F for ; Wed, 17 Apr 2024 04:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iVDouR+VTZu/uppt90P3FgjX9WW5Y0JynCZLFJjF1AA=; b=vNN7UD5hQNMZ0+ Ar6jfOpxvKN6Fy3xVZK6JklHaL/HpWRbG1T4w0qPBOct/IJodsGGDtEMNCd3rGI3TPVDtchKdPq/o y75xNL9uT5314Eu6J5DKkmWSYeuuqlZ9mXlsYZ1UIWHkjsZiu9oQrrZ+2jb6wmRyYhS/D6k0dhKIm k5Q+QKn764xcQia/65e9Up5aAT1u4TWTU820jleHqwDyzs1/MUrJOE6RsIs2l3kbMcUI8bNnMktNx hZuxZf7yJZhgVnm7yWqls2iFHnRAcxBawzgCI34XxIpUX4d1LtJAZF99BGVHgh3Mn6U1ZRLwsL78l t3rkEuAW5TJmhi5m98ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAr-0000000EheI-2a6h; Wed, 17 Apr 2024 04:45:33 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAm-0000000Ehas-0Ovv for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 04:45:29 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2a2d248a2e1so315571a91.0 for ; Tue, 16 Apr 2024 21:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713329127; x=1713933927; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ix5I1EmrcVwkdm6oev/n0e0cu3EKBfKkUwQi0q2AcII=; b=E8aDvejxwO57tUEfeCx85vCb0mLcIWkh4ufvh1MZaW21P7nctSNxmeAiobsnN/ldbd 8nYfg7QsbQ/50/Ew7Mm2ZDj1y1hAHWrC9qeDWHKSPyFwzsebM9h8EfoOrTlwTcQUs7NK WICQ/9XAiNnZOGFM2sOBvcuO5jd+AhpjndEAs9mtuAn4/K7HZ8YIl9SBnKf9CsXXBMpj BYfmXP/KP+OGDTWw5hRdg+oMrE/5bKIb7Ox+oPQLiHgrBDxU0I+SfcOMfn5H2Bc7Vt3H jZw35uTqZvi6u49kCE2/N+TrkqaOwnY+Dxtd3GyCl3mWyZOES4ZqfXjKBBITbHAQLjWF Wqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713329127; x=1713933927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ix5I1EmrcVwkdm6oev/n0e0cu3EKBfKkUwQi0q2AcII=; b=Lu6N31eUvsagGOagGWybaaqOnkuLRNaYr8lZgtvQkCELO3xTxoP+7RjG0DQi6INxnq SUnVCSwJjLPYB3tOXMDoY3Tt4zjyj8OaFQDJy5KpnvQNMikbEVx0sBgScxW7TlOpQBiK kH8PKMgUNXCkdg8Qgmnlak02BzzU8JyfV+b2ymlSdMaSJ55LvgSAyzvYxBCwxnP6okDC Eah0JOOsiTZmU/8o8rXALiSSrOtcD2MePuNJ677EJ2b4/pwbOpyI8DQ4GDai3WWDkxtb A/1dn2fDB8tDu7oTIHlgh4dtHerWXrAKd90ywXOIcT+lLjI8VJ5Xzr3Y22njqTzBd5lJ 3NnQ== X-Forwarded-Encrypted: i=1; AJvYcCXJnfL4OqRfZlEL5Urm3YMnSVZIN+oY1cvRQqdMV1ufDMKVy9PmKtYFw97BOxfKqOcXfluIiySMEyPy6xbZPWZZQeeVqJwb6xjQbnRhoZ2Q9zLs1FE= X-Gm-Message-State: AOJu0YykPPg+i22dM6W2HiY1CeQHV6qY8EiFi1jg9jUbOyNRwq6NPiUR yiOAlul0CXZVkvBzkdbcbP0HGkixP3Oje86Fnyq5dHsnhTodj4vQ X-Google-Smtp-Source: AGHT+IHcijOFiGcrpds/8InYTdLVg2ob8g6xgqf32vPTH6ClkmhGxpsSjcOf+6Heyl309B3TS6AIdw== X-Received: by 2002:a17:90b:3010:b0:2a5:c1ca:801 with SMTP id hg16-20020a17090b301000b002a5c1ca0801mr6393726pjb.23.1713329126906; Tue, 16 Apr 2024 21:45:26 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id z88-20020a17090a6d6100b002a2dbbbb36asm511458pjj.37.2024.04.16.21.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 21:45:26 -0700 (PDT) From: Anand Moon To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] PM / devfreq: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Wed, 17 Apr 2024 10:14:48 +0530 Message-ID: <20240417044459.1908-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240417044459.1908-1-linux.amoon@gmail.com> References: <20240417044459.1908-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_214528_180177_C414B05B X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SET_SYSTEM_SLEEP_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_sleep_ptr() to discard all PM_SLEEP related stuff if CONFIG_PM_SLEEP isn't enabled. Signed-off-by: Anand Moon --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled --- drivers/devfreq/exynos-bus.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 153340b6685f..b89e04eb8430 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -454,7 +454,6 @@ static void exynos_bus_shutdown(struct platform_device *pdev) devfreq_suspend_device(bus->devfreq); } -#ifdef CONFIG_PM_SLEEP static int exynos_bus_resume(struct device *dev) { struct exynos_bus *bus = dev_get_drvdata(dev); @@ -482,11 +481,9 @@ static int exynos_bus_suspend(struct device *dev) return 0; } -#endif -static const struct dev_pm_ops exynos_bus_pm = { - SET_SYSTEM_SLEEP_PM_OPS(exynos_bus_suspend, exynos_bus_resume) -}; +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_bus_pm, + exynos_bus_suspend, exynos_bus_resume); static const struct of_device_id exynos_bus_of_match[] = { { .compatible = "samsung,exynos-bus", }, @@ -499,7 +496,7 @@ static struct platform_driver exynos_bus_platdrv = { .shutdown = exynos_bus_shutdown, .driver = { .name = "exynos-bus", - .pm = &exynos_bus_pm, + .pm = pm_sleep_ptr(&exynos_bus_pm), .of_match_table = exynos_bus_of_match, }, };