From patchwork Fri Apr 19 09:47:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13636097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F9FAC4345F for ; Fri, 19 Apr 2024 09:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3xvoe7SQrSYQ7PC5MIbVhV7yGXq9saXfO3UgIQgCivY=; b=P2gO83Ogxg/wLh mH/bWX0Q0g0nA4ILnHBsjm8yZsukOZ/J6EGwA0KezeKplnBy4palYrL7BELoPkUqtRTiZkvneFW+H zxRqLmpzeUvmY7dopi/YYSGUZjjbMGj2YWOxvQiKqN898sVI/tk0j/sMgp5gsOORI2J3KooOxlsd6 E6CGjMGz4LR+O0jKwjwhGFS4C065l8TgIxIB+H3Ee6rWKIVvPazhJZPR6lDiIIcdAFNWGkg9RQQzB IYBBDvhVQgAskNy/lPfsHVMxta0DFGMG8RRXRPyztXyGfXtFKb5vK2k35YxLLg6RFVHI8wCqThhct 5j33gY3BpLlgRwg0aTOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxkur-00000005AcM-0QOI; Fri, 19 Apr 2024 09:52:21 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxksP-000000059CI-3lLi for linux-arm-kernel@bombadil.infradead.org; Fri, 19 Apr 2024 09:49:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=I5MK517M661jXeUTMXVPJlov9z4l8/dISyr2IlNuzMY=; b=DZDAz8U2vSviJDvksUncZOB00e Nm8xz5IEk3es6+WuFeX4QehW2suTjuwZpbyl007U3iyStTVERwbK27vuucP++I/Ybplmtf9D3Hq/+ +rBmjb0EUjti+PQnBwuOEmGdr2bdp178sz/cej614UbPOk20RpWiavl09nFE71+vaQRxgWccEzKbA H07dKR6nGlHv4pJ+ULvXQx+x/gGI+Ymf53zh4TQLpMYmT6olvFbM4nDmfQFfUPvqGniALHJCQ0Jcf /zNLvkKhMi1zY2IMR9VEZiuFzI5EQrSZyXxpSHYH6ygB935wK0idJc2EFyTYtrZFmcFVwRml3iEJM wSjDhq/Q==; Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxksG-0000000COPG-2lv3 for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2024 09:49:46 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-78efd533a00so105616285a.0 for ; Fri, 19 Apr 2024 02:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713520171; x=1714124971; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I5MK517M661jXeUTMXVPJlov9z4l8/dISyr2IlNuzMY=; b=ScfRIeWrx3GsnNewIWqYmwwb/e6wFe1c4+RE7tTAWlOa1zs2I4livsvgsOuZmEcv3C WJipY/y3G6wIEqkmj6ucDvR/r/N2kd0SG5Jpao3/opo9XqnRrqCclN6PxfcSVGj9sqf9 3qmcJGjKrXNqiWJBnr5e6ooupFFzMCK/yQbj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713520171; x=1714124971; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I5MK517M661jXeUTMXVPJlov9z4l8/dISyr2IlNuzMY=; b=ggr5vql/emC05xkI0HcfxNmhQkKvr4Zrmcxva8DTUSQ3smCSKJJ2EMbgADE4R0IdTa n5P34H7rgUAY1awRFXMrFG/seeYMWX9zzOT9J1fx0p175DNG4anpYDS0qzP4nWTEMJ9y xuvHqa8w8XBYdpzbZJQ/ANRohJUwjEVhx4/qYwommj+6rsBhnWgQjybEIdDmNqRxd3a+ tJsIZYAAGdcHO4cFtFk5Ax/T5BgUw3pE3E4ciH0nxZR32VmX5/RIirQwr/3unGZRvysT fPJSYb4GB6NsYBS5Ob19qi95uLsmWPTgxP2QRWDxd0oQJVp3SE4mE1BvxcceHSD4EIGE mAiQ== X-Forwarded-Encrypted: i=1; AJvYcCUhJ4JYV1VPWoeK6czL5uiRb2fwu4YtNTiK5Cbd51DH/4t/p1Tpfhl2IqpTwLJb+GKigweJ1KgcIyOk4v9SwpHkbzZ7U22mwU+hhrHLNdGoHRMRpvw= X-Gm-Message-State: AOJu0Yytoc0DKIXAN84Gaa60HpTob1gBBktiz5HvwQIalP8+HfEAOatq FPdwQ/iz0TIvxICrHUd06rB8PaOhTnI2jOayBygOPq1xhq7AQnOsR8YawZBdBQ== X-Google-Smtp-Source: AGHT+IGTA8hVputhy9D1xoHe1Hnr3yG2C7dQHpLq8IKH//vLRvJ+A58aCJR9JO6Y/w8HTYrMtJHvqA== X-Received: by 2002:a05:620a:1da6:b0:78d:5065:c5df with SMTP id pj38-20020a05620a1da600b0078d5065c5dfmr1596268qkn.18.1713520171055; Fri, 19 Apr 2024 02:49:31 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id dt14-20020a05620a478e00b0078d735ca917sm1434532qkb.123.2024.04.19.02.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 02:49:30 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 19 Apr 2024 09:47:56 +0000 Subject: [PATCH v2 10/26] staging: media: tegra-video: Use swap macro MIME-Version: 1.0 Message-Id: <20240419-fix-cocci-v2-10-2119e692309c@chromium.org> References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> In-Reply-To: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_104943_042637_8FE21BBD X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Makes the code simpler and cocci happier: drivers/staging/media/tegra-video/tegra20.c:324:44-45: WARNING opportunity for swap() Reviewed-by: Luca Ceresoli Signed-off-by: Ricardo Ribalda --- drivers/staging/media/tegra-video/tegra20.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c index 630e2ff987a3..7b8f8f810b35 100644 --- a/drivers/staging/media/tegra-video/tegra20.c +++ b/drivers/staging/media/tegra-video/tegra20.c @@ -317,13 +317,8 @@ static void tegra20_channel_queue_setup(struct tegra_vi_channel *chan) chan->addr_offset_v = chan->addr_offset_u + stride * height / 4; /* For YVU420, we swap the locations of the U and V planes. */ - if (chan->format.pixelformat == V4L2_PIX_FMT_YVU420) { - unsigned long temp; - - temp = chan->addr_offset_u; - chan->addr_offset_u = chan->addr_offset_v; - chan->addr_offset_v = temp; - } + if (chan->format.pixelformat == V4L2_PIX_FMT_YVU420) + swap(chan->addr_offset_u, chan->addr_offset_v); chan->start_offset_u = chan->addr_offset_u; chan->start_offset_v = chan->addr_offset_v;