diff mbox series

[3/3] ARM: dts: st: update the pwr compatible for stm32mp15

Message ID 20240425094829.3.I493dfe2bde7f40beb48455f8ff8368cc8a869cdc@changeid (mailing list archive)
State Superseded
Headers show
Series ARM: st: use a correct pwr compatible for stm32mp15 | expand

Commit Message

Patrick Delaunay April 25, 2024, 7:48 a.m. UTC
Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg",
and use the new supported compatible "st,stm32mp1-pwr-reg" in STM3MP15
SoC dtsi.

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 25, 2024, 8:57 a.m. UTC | #1
On 25/04/2024 09:48, Patrick Delaunay wrote:
> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg",
> and use the new supported compatible "st,stm32mp1-pwr-reg" in STM3MP15
> SoC dtsi.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This will break the users and is not bisectable, so patch should wait at
least one cycle. This will preserve bisectability, although users will
be affected anyway.

Best regards,
Krzysztof
Patrick Delaunay April 25, 2024, 1:54 p.m. UTC | #2
Hi,

On 4/25/24 10:57, Krzysztof Kozlowski wrote:
> On 25/04/2024 09:48, Patrick Delaunay wrote:
>> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg",
>> and use the new supported compatible "st,stm32mp1-pwr-reg" in STM3MP15
>> SoC dtsi.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>>
>>   arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> This will break the users and is not bisectable, so patch should wait at
> least one cycle. This will preserve bisectability, although users will
> be affected anyway.


Sorry, I didn't know this constraint

But Ok, I remove this patch in serie V2 and push it later.


>
> Best regards,
> Krzysztof

Regards,

Patrick
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/st/stm32mp151.dtsi b/arch/arm/boot/dts/st/stm32mp151.dtsi
index 16bd6eee32b4..702cdaa1343a 100644
--- a/arch/arm/boot/dts/st/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp151.dtsi
@@ -144,7 +144,7 @@  rcc: rcc@50000000 {
 		};
 
 		pwr_regulators: pwr@50001000 {
-			compatible = "st,stm32mp1,pwr-reg";
+			compatible = "st,stm32mp1-pwr-reg";
 			reg = <0x50001000 0x10>;
 
 			reg11: reg11 {