From patchwork Thu Apr 25 16:58:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 878ECC19F4E for ; Thu, 25 Apr 2024 16:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OubbxwNhDibWZzCfKeXDQjqMQ9K0xoGl30Zp4acWcyM=; b=gzUiqfo+anBcIt 0MnoOHLIkrQKngazVNseTq/AJEo38YEc5smJmPcljDIIX5wUwobbak+GJRwAy35qWuOnEbefnV05s v0dIr8OV8GubJUGCd7WwqdBkDcLURSGChMtU2OR0jouLdceI6M65x39zyl2ugcjmNnhoNNDBDjxA9 stc/Wy7IaZny6W0L3in33xio8Q9Kd0pi5tfJqoRwO/Dpw1Gm5/J7aYzuzH4ZHDeI2xuzVe/u+/GdD nN9kQH08o8s8xmx9NuuxiD9LUyGtRwz8IPjY0kTaBvkg1s6TJJqFzVkOYsOLTbn2PZ6yEp0pBhnH8 B6HfXDZ7sgQ8OLHaqY+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02Rm-00000009TzL-0D3h; Thu, 25 Apr 2024 16:59:46 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RO-00000009ToD-0UxE for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064355; x=1714669155; i=wahrenst@gmx.net; bh=qxbEz+OYjkfKXFV1gUswI7ZceQqaUjKdCgHNV4HXajg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=DaQj8fgkNmsbDFD7MMBtLJzeP6jCOpYZTjWj7/hfcA3odkSRvfBeTmL6V4OCOf/T 4Scv4++nX72hABDyBmkQiGplBFPc9I/eF5vgGFHLaZyermHBQww+ocOfwifSP1+lT NzcIF+rNtIVGeUvQxPCM5j+JOI3grtpsyo2wE95h4F1hRj667yBkVXqwRzhl07k5q mYT5T6NP1i1OAoeFu7Om1W0f0Gi2Ets4+nmhet65ao2FBAVVeG8BYuZ9gZJxnVTsx +zqy4hFVlnLqDh0yzJO20m7k7Uz119s4ebvfyi0CSNyq5B9eUKq6YEoXG5fhgmLtM qGkFv6XhwRLbzzrjfg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNKhs-1sJMVs3k30-00PjqW; Thu, 25 Apr 2024 18:59:14 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 2/5] staging: vchiq_core: Use printk messages for devices Date: Thu, 25 Apr 2024 18:58:49 +0200 Message-Id: <20240425165852.6681-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:cd7rHLvt5pHpDdQEbBWy4OYx1oqQcqVOfqkrjV4LM7ueZm1902V dvXGoedOggvt3H6ezl47JIY2mGwRnWXjIiGPWrE5oWXw+xJdrIY8JMw4FbPxzsamiCjWqvA PDDgD3WK5WvDVfgUPAeEZFJW7gvidgZsP4bDBEf10b/TAsZo3h0+UGP2+obdpoi6NrpeWP+ Cot2BuofRNMp7o5X3HC0w== UI-OutboundReport: notjunk:1;M01:P0:ZI1hX3BJO34=;5f0rW5JSHuGRdOKUhyOzyajOZEs PVHVzO+w4lp2bh2ByURnO+NaXIEeMUrofBc0sBwAsg93jAdnVPdkUIkGuPYtM8na1pGgmW9JV 7OMQ2Y6FPzbzaTGnDq30NaETAzxRsd7wHWGmbObomw/YOj8hh5OMXdaHaWhngnqoWwj8ke+f5 EFp6HS/WRieLyZTVuftB91k8wv9xhLiPziWvq1v1/v/JmGTbXQLL3v1GV+Wd2AcyV8QEOyWf+ fUnyuL1s8XvTfGTMGpjw5dGZFQI45XifjFizdJfkpYvlAYZzoIm040SMM76QC35Jdbz4cQLiQ k+NBMNSIdxD5V3NYJ1dLKqDE8kYPYdqeSAWQDwL/XmlL6+LrMavKkSQN5j5/mBlT4PhdJV12n oChMh1QQleaWA8PczX5QUJlWTVnGZDe1Eh+dwmIV+b+2asFi1j4nG+2R1zT0beUcwcOlrOwEN PbZKbkK6ZpGsuDFpiOlVl/CAmT1Jo/pKq9KlFNQbIpSkw+XN2QO5+hrGxPiy0rYjHi+OQ7gWN PE0UWHDI1w3boBI7nObJ93uohIeFVJeAEFqeWrfNCxV9EFep01pfwS70I0UqztOpnzJnxd+bp 2+IuqfX/eLYAolYJ/laIubzC/cJTgPGV3fa8H4K5Hj9gse63jpnt/rNrqBhWZSxx7617TDm9u XOba7IZbN4qLD0VTF8/QU90FUYhoAwIwfRM58EOUYGgvphuuk11OpTymKk3QYs2stsWuPtbj4 uhbvCrXSvu/Xjm7v6y/jeYXZIJh5LatJcX+OvT8Z4zqNAHFz9LxqfDScJmp1Z/W6otACLenx5 eQ00S+xA0Wjh4g+Y5ejV0kYeFCKfQ8yVPrOd+LTe8080Y= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095922_538127_FBFE6032 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that struct vchiq_state has a device reference, we can convert the remaining printk message helpers. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 3397365e551e..129d73fec2bf 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { complete(&state->slot_available_event); - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", + __func__, tx_pos); return NULL; } @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } if (queue->process != queue->remote_insert) { - pr_err("%s: p %x != ri %x\n", - __func__, - queue->process, - queue->remote_insert); + dev_err(state->dev, "%s: p %x != ri %x\n", + __func__, queue->process, + queue->remote_insert); mutex_unlock(&service->bulk_mutex); goto bail_not_ready; }