From patchwork Mon Apr 29 15:04:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13647231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CE5BC4345F for ; Mon, 29 Apr 2024 15:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=auH+/0ybVJ5itT50s/yXGGXADv5D4BAQIlqMGr+r+Xk=; b=FMz1OweIHOrwUO 590B6jtVSQFfSoedU+Oze96pCkxtPQ7CvpPzdKiajVfJc3l+YFTRSl1mibmR6UOo9Pc8VQx5wcfVd pv9hsrOB5QaUllQWKy0bSO7o55UdHPMtzowcJJmoyGxyjWCUCLFQ0dh9AZnd5sAr2+TB1onHZ2nnL PNFWAfglCjH9ac/PARF17SLKSzXP9jsw9dqc9KzOyYJZ1XMNbjho9yb7plSIzu8h9YijP+MfC2/zr tanp7lM90/lbhxcqhHgeZWYXVcwPJq1tI2Lt3FogNVLWbiudncOcaAP2ahHMBIKWUmSTmO+qKaDiW 5n29SxJsjZZBXXhgnJzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Shh-00000003L55-2r9E; Mon, 29 Apr 2024 15:14:05 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1ShM-00000003Ktg-0FMP for linux-arm-kernel@bombadil.infradead.org; Mon, 29 Apr 2024 15:13:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=S/QHDINTXxaHfJymmPQd1ntNOyaEtGJ2b8ypDUwyIXI=; b=eZv8ka6jzumsKwXyW8idQSILSH iBJDkL0bqH2coViQOSaUTkxPfoD7qiXj9w07oz/52EHVmVYxttjQkgpXVYgA2BiZFOzAR1+Kod8vJ CQG1vws6obJl+4cafIfJQQ0s9f5H4n306/X5UadKhgCy7fIXJTimZuAiMaIqijbR2I5sQPlS9T5Mv qMH2vFS7EK+pSy8xJEc2pFIfRXX8qxjLAmLPEucvhuYxdI6L4jWRiTmhu364rZBIenwvxDZMa7p3p z/enwLXnKTR3ylzJS2OquQsyruFUWBRspdrPLon+gDIYrdWqH3vmol7CsjTAlg0xiieCB4/Y3/s5O E6cEBY/g==; Received: from [2607:f8b0:4864:20::72e] (helo=mail-qk1-x72e.google.com) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Sd9-0000000GYLz-433H for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 15:13:31 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-78f043eaee9so279808285a.3 for ; Mon, 29 Apr 2024 08:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714403088; x=1715007888; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S/QHDINTXxaHfJymmPQd1ntNOyaEtGJ2b8ypDUwyIXI=; b=YAb06H5zh4iyWP9ItzNUWSzBjekxbhUVPnZ+MLCbM26ADVSRF12v1vsA7fM3FLeakZ SsrKZys1Tp06zaoVe1KxVtYj7o09iZweod309GNRJ1ravlzFbtRzZEoFwAu/his3DY3a xdWICO8ZuI2teAtYlnGKzljFTfTWYc7y9NaYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714403088; x=1715007888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/QHDINTXxaHfJymmPQd1ntNOyaEtGJ2b8ypDUwyIXI=; b=fOW8MM27105SLMoZJk1bSW54uXH5dKvYvA2e7tDQGKQgxcc+KT4UtlMNSe7Vf6u5Hs AVpIQOHEeHWjUS8CtVhDcDVYlM5z0GeBsX0C69AjUiNM3ZKcGljKXI4g/e2R7CeAiLWC +qWHNoEJOWdloUQLj5K9sgHEdD4fB6Y2dCx0H7cEVMFox/6y8GzwRJAikj+J0GQS4P8C cw//ancwht2LkBZoD0W1raJBhK9Wh6Fab18hBozJbag5AqTh94HAwQXMLUqFrYYWakCe g6f3NtszX1eHFcnXaM1Zb9LwkYUvn4SCY2JSoCg963ZpzQ9yLTkr6KcUYoZnM2cDiQOL zRAQ== X-Forwarded-Encrypted: i=1; AJvYcCUB47VI2m2G0k8i0dopjuMzCDeCpAOX4yqy8FJZvMs56whJjIwX6/K3zDQuMocCDvemm3x6TE3glps1FiRxA26GFyl062p/CdAUpNCbcANiAYMQ4u0= X-Gm-Message-State: AOJu0Yz4OGcHxkIJxSAd/GMbqWe++qbnOfQP/t4c9f1Lt2ygZfItQcXK QfjegKcbzC1akkRXeVKW6kX5ANwMBgMGUmEDSairZkzC1RGDbAz7qQiHPTpiUA== X-Google-Smtp-Source: AGHT+IEZLuGKR7d7W/XG/sq8LQdtDnaq4FWL5zvJstwztGqQFStkjBLrDGAeQqjGLBaD6vVb0xh5nw== X-Received: by 2002:a05:620a:21d8:b0:790:81e5:5f30 with SMTP id h24-20020a05620a21d800b0079081e55f30mr12924542qka.70.1714403088208; Mon, 29 Apr 2024 08:04:48 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a056700b0078d3b9139edsm10568591qkp.97.2024.04.29.08.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 08:04:47 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 29 Apr 2024 15:04:44 +0000 Subject: [PATCH v3 05/26] media: go7007: Use min and max macros MIME-Version: 1.0 Message-Id: <20240429-fix-cocci-v3-5-3c4865f5a4b0@chromium.org> References: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> In-Reply-To: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_161118_550657_C5E3A47A X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace ternary inline selection of f1 and f2 min max values with min() and max() helper functions for the sake of readability and to make coccinelle happier drivers/media/usb/go7007/go7007-fw.c:1292:14-15: WARNING opportunity for max() drivers/media/usb/go7007/go7007-fw.c:1293:14-15: WARNING opportunity for min() Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/usb/go7007/go7007-fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/go7007/go7007-fw.c b/drivers/media/usb/go7007/go7007-fw.c index 018019ba47d4..86ce593e0c54 100644 --- a/drivers/media/usb/go7007/go7007-fw.c +++ b/drivers/media/usb/go7007/go7007-fw.c @@ -1289,8 +1289,8 @@ static int avsync_to_package(struct go7007 *go, __le16 *code, int space) 0xbf99, (u16)((-adjratio) >> 16), 0xbf92, 0, 0xbf93, 0, - 0xbff4, f1 > f2 ? f1 : f2, - 0xbff5, f1 < f2 ? f1 : f2, + 0xbff4, max(f1, f2), + 0xbff5, min(f1, f2), 0xbff6, f1 < f2 ? ratio : ratio + 1, 0xbff7, f1 > f2 ? ratio : ratio + 1, 0xbff8, 0,