From patchwork Mon Apr 29 15:04:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13647155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9AE3C4345F for ; Mon, 29 Apr 2024 15:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Ofaw8FZbR6I9NiBS36Ui1LvKvQTx1m85Ae/gd1OsEI=; b=f+bqqDA4CDmSb6 UTCXPy4V3WSWvmaF0O99XBrzydSWWP7Mjd3louI7BoI2FyC2aCvvie3S1vzD+MwOmww7Xlt7qaCAC yyIQVh3ghkvNthaz8t8xw7e18F46/0YnRXltcSbV6AJPO/gPWvcDI6rwaJPwf5OCGRGuP4ewa6y0p juw3XTa4fNznuBb8nr1qhr4ghyV4oIxtKR1dqGtGnMf5Q6Xfmrs5qxKtM1MHbOfG8pdkS+91tIVR4 GjNrL5czEbw6MOBEEnK/UgnMuXp+QrK6r5unRfILTpf6vYa9jx/6wnnEs4YyWC0JT/SWyH7WPd3Rg 59Vp9ACpMmD/L7ldBF7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1SZs-00000003G2Z-1Lgc; Mon, 29 Apr 2024 15:06:00 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1SYl-00000003FKO-1Dpg for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 15:04:53 +0000 Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-790f4650f93so114834685a.2 for ; Mon, 29 Apr 2024 08:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714403090; x=1715007890; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/qUCWhD1zt8bKcdbs6yESnMSEdigGZ2fB7xO4uH5zQE=; b=PLIi0Cj56Q3LqJnD9UFb8RVKb4xjk66YKjTMUbPqVZ3Hhui/VPbAgdDT6hIg+76yMT aSjvAeV4twSIjC1ZgdkxfpGFmNeRrqvxrBW+m9Ado+DlepEiRQ6JdsieguxJvZkl3roE cx7HOK6M7YtBOvFX7couxpV7FK4x3vbrcI0eM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714403090; x=1715007890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qUCWhD1zt8bKcdbs6yESnMSEdigGZ2fB7xO4uH5zQE=; b=XbWvXq7oYv5sUTLfLW1kE5LEM1Wt6epbC5SWtuEKrXWR/t5yN6TjCfWTEcQbX6rA5u zGWXi19/Ksk16RP35aiDDiFPt+9SNidGPcB+A+ghn7xJYXYbHfLcFiuITzxeWC1pCgUE BoweprGwbGRNSxZQUyO4NyUOI+2uwj3FE0eS1sNw5A1slKr4l/1Grigt2wqko8cMnnO/ xu6bAt5aHoeKuzBkFGjYhimxKwhbuyiXG83QI7bLKg9/R49+L+KqaOf7OuaMpqAlTOc/ 0d9x3K9F1YDEgaRI2eDB7MzGH+yvx4Uxjct0GKBLKRftA4qrDadmUmR9uCkKKrfJA/yW LQWw== X-Forwarded-Encrypted: i=1; AJvYcCUhZEENB0ObOU4RBDUDFCcDKIIGWEs+qjbhtwlXylETBY/cCNMFlLsiPFqq9gYlYDQ9Wk4TwvZLCoSd5Kdl8lcxq253nix294x75gYC+hiOHP3vQ6s= X-Gm-Message-State: AOJu0YxAaxakIXxW/P2j81fdLVRssBiuREZY9r1L/omLH6b5/PxJ+q76 0qibTNJOA8Rb8kHAe1Pm/BiYrEaRinw9nIzqd7ph0apPW/WqzuUE/z997k341w== X-Google-Smtp-Source: AGHT+IHHKi7cqnMpYwnQDIZ9akhXG6vV1AIqNbLdBOwmjaLKTCEqbKtGqVQAHlyIVFw/U88/GLAn3g== X-Received: by 2002:a05:620a:4591:b0:790:fc14:60ac with SMTP id bp17-20020a05620a459100b00790fc1460acmr2298793qkb.0.1714403090344; Mon, 29 Apr 2024 08:04:50 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a056700b0078d3b9139edsm10568591qkp.97.2024.04.29.08.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 08:04:50 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 29 Apr 2024 15:04:46 +0000 Subject: [PATCH v3 07/26] media: staging: sun6i-isp: Remove redundant printk MIME-Version: 1.0 Message-Id: <20240429-fix-cocci-v3-7-3c4865f5a4b0@chromium.org> References: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> In-Reply-To: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_080451_483507_D230387E X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() already prints an error for us. Found by cocci: drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:389:2-9: line 389 is redundant because platform_get_irq() already prints an error Acked-by: Jernej Skrabec Signed-off-by: Ricardo Ribalda --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 5c0a45394cba..58f8ae92320d 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -386,8 +386,7 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); - ret = -ENXIO; + ret = irq; goto error_clock_rate_exclusive; }