| Message ID | 20240429061600.2723904-1-c-vankar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: ti: k3-am625-sk: Add bootph-all property in phy_gmii_sel node | expand |
On 29/04/2024 08:16, Chintan Vankar wrote: > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > index ae81ebb39d02..58b70a760648 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > @@ -297,3 +297,7 @@ partition@3fc0000 { > &tlv320aic3106 { > DVDD-supply = <&vcc_1v8>; > }; > + > +&phy_gmii_sel { > + bootph-all; > +}; Are you sure you kept proper ordering of nodes or just stuffed this to the end? Best regards, Krzysztof
On 29/04/24 12:08, Krzysztof Kozlowski wrote: > Are you sure you kept proper ordering of nodes or just stuffed this to > the end? Yes, I added this node at the end.
On 29/04/24 12:12, Chintan Vankar wrote: > > > On 29/04/24 12:08, Krzysztof Kozlowski wrote: >> Are you sure you kept proper ordering of nodes or just stuffed this to >> the end? > > Yes, I added this node at the end. Is it okay to add it at the end or it should be defined after "cpsw3g" node ?
On 29/04/2024 08:58, Chintan Vankar wrote: > > > On 29/04/24 12:12, Chintan Vankar wrote: >> >> >> On 29/04/24 12:08, Krzysztof Kozlowski wrote: >>> Are you sure you kept proper ordering of nodes or just stuffed this to >>> the end? >> >> Yes, I added this node at the end. > > Is it okay to add it at the end or it should be defined after "cpsw3g" > node ? What is the ordering for this subarch? What does the DTS coding style say? Best regards, Krzysztof
On 29/04/24 12:56, Krzysztof Kozlowski wrote: > On 29/04/2024 08:58, Chintan Vankar wrote: >> >> >> On 29/04/24 12:12, Chintan Vankar wrote: >>> >>> >>> On 29/04/24 12:08, Krzysztof Kozlowski wrote: >>>> Are you sure you kept proper ordering of nodes or just stuffed this to >>>> the end? >>> >>> Yes, I added this node at the end. >> >> Is it okay to add it at the end or it should be defined after "cpsw3g" >> node ? > > What is the ordering for this subarch? What does the DTS coding style say? > I tried to verify the order this file is following from DTS coding style documentation, but it seems it is not following the order mentioned in Documentation. Since we will need the same functionality for "am62x-lpsk" board I am planning to add this node in "k3-am62x-sk-common.dtsi". In that file I will follow the same order as it is followed in "k3-am62-main.dtsi". > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts index ae81ebb39d02..58b70a760648 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts @@ -297,3 +297,7 @@ partition@3fc0000 { &tlv320aic3106 { DVDD-supply = <&vcc_1v8>; }; + +&phy_gmii_sel { + bootph-all; +};
Add missing bootph-all property for CPSW MAC's PHY node phy_gmii_sel. Signed-off-by: Chintan Vankar <c-vankar@ti.com> --- This patch is based on linux-next tagged next-20240426. Link to v1: https://lore.kernel.org/r/20240425095448.1946293-1-c-vankar@ti.com/ Changes from v1 to v2: - Removed "bootph-all" property from "k3-am62-main.dtsi" and added it to "k3-am625-sk.dts". arch/arm64/boot/dts/ti/k3-am625-sk.dts | 4 ++++ 1 file changed, 4 insertions(+)