From patchwork Tue Apr 30 12:55:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13648986 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D3BDC4345F for ; Tue, 30 Apr 2024 12:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=18S4u2zMzPObb9vVcfcsvc0un8sOFCFzykqSwvRn42I=; b=AQdxjvUCpl9pAx mpxIC/q8a4haUNmUAhiSZ9+y/zCb1QbjS+ggfmRmv40TnmYuxIKm4BQRkKMvwa8H8yyk0kj5bCKTf z0LlSbTQQkm+QXwWQCoCMzm0P1bUXVw1UZlkogN7yMX0rOOSOSoiW53Pt0WwCTr0Gr3TASiuz/fhv pqFbH0zwnmPj6AQ3iNREVVoPmEX1O7EDaRcK/1rJ87U2GAnMh3KYicAruI4eZ2a+so5U9qZk4DT9T GF7uDg3x8TY6+R/53iNoD3lTgupgmcE3TrkWcRtJpQbDxgCEII22UsEG/xmDrnRxHACzv/uhg0DsG VdNQ/9BxQxry8z6zy4hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1n1i-00000006P4o-1mzl; Tue, 30 Apr 2024 12:56:06 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1n1Q-00000006Ov3-3Um1 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 12:55:51 +0000 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6ee2fb4ec57so1191661a34.3 for ; Tue, 30 Apr 2024 05:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714481746; x=1715086546; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cjV8GfCP2WHHQ01Aqc8mQQXzl2eD7DwGYj59FGy18+c=; b=TdMQKBF1b5WLUx+mf4auNLQrysQx0qU93I3D4rwZJgNMy8eQ7Dmds3HkZevMZsqtMD jiA69ftXXVHweUcGOLzAGWXPtdvYhiCjVgwcwRbrmUr+B7ee9Q73KNbdTcMxanGTiUxQ upB4zl8wR6LRdwzaV/v2N/w0ICeD8VxinVjPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714481746; x=1715086546; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjV8GfCP2WHHQ01Aqc8mQQXzl2eD7DwGYj59FGy18+c=; b=ZvEjo/tOI47aKuDVGA+oCRRDrGphy75NjYVwayXOcz/3/INEbeliTJGVtNpBIhz9fW p5dj12wgYs0E8NtPgmhJ4Y5yzO4dPKLRO3bF7SsKxXAOLn0jlQASrv9WMLshmwzpzdzu hsWN2jSXlMRYisFjqMmQgpmHAsUg/Ip1O2GSrNiuKm+sgYKwoPMeiruBYaOSKne0JEEA 8TdLwUGve/g8s0zhg6m7bVaYx2S4SFpCnAqf3UNb/Py/bf4ZlfY60JnvAw9R3gQp4dBp ytcpkz0yGr4DieE2GJTRsnt0ORZ8+zKlPH0/E4VQmDIu0ZEj86HbgEwmX+F3shYIi5pH ck+Q== X-Forwarded-Encrypted: i=1; AJvYcCWzq3a+FZsoPC+VeClEUFAX4oHCndSOaWnDF++LePNztC2CtVxiTONxx6vxy7nCwDsxqliLK2B9xE80jjZdW6qeyoSEt57HgAklqRwAq6RkvS3Qq88= X-Gm-Message-State: AOJu0YwAsTuxH35wX5xzjHb21peiF4Ztqx7KvZRzYESsBIX8e40CyJwl N855h9GfGlk9NLt/frrdLpCjAQurmrhB0kiIcd15sxTy6L+5q01iUX8PSBisZQ== X-Google-Smtp-Source: AGHT+IEgUWZ5sviYRGNJaeAywK807QZ4gEbNChyUYkiHWKS+u2I4svAfqrFMNl4wY8mlmeEBL/dfjQ== X-Received: by 2002:a9d:7dd5:0:b0:6eb:e0a2:bbb4 with SMTP id k21-20020a9d7dd5000000b006ebe0a2bbb4mr2938580otn.16.1714481746548; Tue, 30 Apr 2024 05:55:46 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id o16-20020a05620a111000b00790f90ffc32sm1553667qkk.22.2024.04.30.05.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 05:55:45 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 30 Apr 2024 12:55:33 +0000 Subject: [PATCH 1/4] media: bcm2835-unicam: Fix build with !PM MIME-Version: 1.0 Message-Id: <20240430-fix-ipu6-v1-1-9b31fbbce6e4@chromium.org> References: <20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org> In-Reply-To: <20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org> To: Mauro Carvalho Chehab , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Sakari Ailus , Bingbu Cao , Tianshu Qiu Cc: linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_055549_124129_6223E64C X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver can only match the device vide the DT table, so the table should always be used, of_match_ptr does not make sense here. Fixes: drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Ricardo Ribalda --- drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index bd2bbb53070e..c590e26fe2cf 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = { .driver = { .name = UNICAM_MODULE_NAME, .pm = pm_ptr(&unicam_pm_ops), - .of_match_table = of_match_ptr(unicam_of_match), + .of_match_table = unicam_of_match, }, };