From patchwork Thu May 9 10:48:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13659650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5795C25B10 for ; Thu, 9 May 2024 10:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=STHun8+Puh0vyklY+ckVfNqv3uiWnnmz4krz5ZRVHNo=; b=yjcqhOwSAHb09x i3pCU8ohl5mwHVRVkG105lZfxoCK3mF3wlGFmg076Ubet6XMaesysm98jNoyPzfdIM6jl26ge1KW5 LFmaAFBdL0BWaYSnkgk7LfTQV1wQVum52uG0jf/QA6V8bdClgJFjd38uWe1UWHKhljk0eOe1zu5Zw GbWwMLXGvhTGhX0tiJrkcsvLpUOPH4uh5B0FICB2DJkkn90he4d/DdeXmp2B/EIvpT+e2ZOpzguDj u2fDHnzlyJqTdp4d9dXCkiLkVRkPVPEE7LRWAfCkFsi0qbk9Wk/REbKLKh+5VrqsjbMcM1EvKBRQO GnytrctgK6JQ9MdJcfHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s51Kb-00000001BIT-1WYG; Thu, 09 May 2024 10:48:57 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s51KS-00000001BCC-2MA1 for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2024 10:48:51 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a59cf8140d0so163782666b.3 for ; Thu, 09 May 2024 03:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715251724; x=1715856524; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QnzQs4M8STg8v5mtXmoZjumL7kiGXFglN5V5NIOcQXY=; b=za74SbmYO4Jk5AdNPKoaVopN7VDY5m7I4uR22pGhFmjfhfnO647u/h2Y68jD3+FrC0 O+2wIxxCalVAAug+hnP2uiX3XznfD/baWiHfRnJRTeVhExSRJFw4OWeq0dmGDa96vXbn rdWqcQ8T55r60wH8aQLuEfv+jD5qw+FRGET3LId6PbYOeQOdPkfkuZ87R0v/Dw2emDxA TfiPWTMJp0Ug0pbXTRQ+9Wejzol0qnafKlq7afwxb/DBqY04J4XSE0DtZ0a2d6x+RcBM 0nmPHn+0hY76kmN2aW5/2QiBSIx9HnK6F1ef8VVv8+b3JGp+c6lFDlWgzh6DGvHWMVcB Iu5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715251724; x=1715856524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QnzQs4M8STg8v5mtXmoZjumL7kiGXFglN5V5NIOcQXY=; b=eH+YLtPqYd9l4hPjR8ZEOTKqHRXw09XFGsuwDLyf2M/W1RMUEXo0JZSO2TX2/KrYrZ Y9BEjpXFr0td1oY2A9gPg3quG8u8b0744rh4BUKjj9OLcuO9aYQVkw+3hdWVAUnaYqu7 Bac4Sf5unoELA3YN4OoPsZVK2Z8jMAwbeA/r+h5DakgcpS23QVKaX3m13e65xtVfeu5y FhaasvGTVX/4WmwSuaHq8CBkyhGL2KNLYQElr9LGM9OwURTBEeKILOAMzVUku6W0XR+n wBuxxewcLN+9ZiCwTXta6hkButG+GUaI5TFsc9EK/ESburRyUtFSYOnkthazDsesEZOU 6N3Q== X-Forwarded-Encrypted: i=1; AJvYcCXAYrMlGGKhdLcAZegXyVBvpN/KX8Fn64oKE/hN0kl7F4+t07VSd4qUAgh2BoMhoF+s7vnf6EFLSF5Z9283xiCh9mCYoZjt039S+5Wv+9x9YwljIlU= X-Gm-Message-State: AOJu0YxwV9AZ1ClK0SXDm9pWSOiH5qzxTscZWyLiUVT+NbqEJchAK4iL Rji276/iyy7rYn1dGleqm2z38x21ETKzUtYxC4PXiXxrf/f2m9d9yyZPh6J7Z2I= X-Google-Smtp-Source: AGHT+IHczS5CGAbdxg981H0G+SH61xNrLiSFw+Z1T9VXSEXNVrCC1Lb8qrk7DjDkFnik5BB2nKDB1A== X-Received: by 2002:a17:906:61a:b0:a59:9ef3:f6df with SMTP id a640c23a62f3a-a59fb941d7bmr290673566b.22.1715251724582; Thu, 09 May 2024 03:48:44 -0700 (PDT) Received: from krzk-bin.. ([178.197.206.169]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17894d85sm60195966b.72.2024.05.09.03.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 03:48:43 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/5] ARM: dts: imx: correct choice of panel native mode Date: Thu, 9 May 2024 12:48:35 +0200 Message-ID: <20240509104838.216773-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240509104838.216773-1-krzysztof.kozlowski@linaro.org> References: <20240509104838.216773-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240509_034848_651731_81AD336C X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Bindings and Linux driver expect native-mode to be a phandle to one of the timings node, not a boolean property. Correct the DTS to fix dtbs_check warnings like: imx53-m53evk.dtb: display-timings: timing-800x480p60: 'native-mode' does not match any of the regexes: 'pinctrl-[0-9]+' This should not have actual effect for Linux kernel (no real bug affecting choice of native-mode), because the first timing node is chosen in absence of proper native-mode property. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/nxp/imx/imx51-apf51dev.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx53-m53evk.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_7.dts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx51-apf51dev.dts b/arch/arm/boot/dts/nxp/imx/imx51-apf51dev.dts index f72e109342bc..de6b7607510a 100644 --- a/arch/arm/boot/dts/nxp/imx/imx51-apf51dev.dts +++ b/arch/arm/boot/dts/nxp/imx/imx51-apf51dev.dts @@ -25,8 +25,8 @@ disp1 { pinctrl-0 = <&pinctrl_ipu_disp1>; display-timings { + native-mode = <&timing0>; timing0: timing-lw700 { - native-mode; clock-frequency = <33000033>; hactive = <800>; vactive = <480>; diff --git a/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts b/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts index 87a34cbdf233..079bd3d14999 100644 --- a/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts +++ b/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts @@ -58,8 +58,8 @@ display1: disp1 { pinctrl-0 = <&pinctrl_lcd>; display-timings { + native-mode = <&timing0>; timing0: timing-800x480p60 { - native-mode; clock-frequency = <30066000>; hactive = <800>; vactive = <480>; diff --git a/arch/arm/boot/dts/nxp/imx/imx53-m53evk.dts b/arch/arm/boot/dts/nxp/imx/imx53-m53evk.dts index f0f92ee7ba95..ba0c62994f75 100644 --- a/arch/arm/boot/dts/nxp/imx/imx53-m53evk.dts +++ b/arch/arm/boot/dts/nxp/imx/imx53-m53evk.dts @@ -17,8 +17,8 @@ display1: disp1 { pinctrl-0 = <&pinctrl_ipu_disp1>; display-timings { + native-mode = <&timing0>; timing0: timing-800x480p60 { - native-mode; clock-frequency = <31500000>; hactive = <800>; vactive = <480>; diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dts index c75606fc4abd..ec806b8d503a 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dts @@ -85,8 +85,8 @@ lcd_panel: display@0 { power-on-delay = <10>; display-timings { + native-mode = <&timing0>; timing0: timing-480x800p57 { - native-mode; clock-frequency = <27000027>; hactive = <480>; vactive = <800>; diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dts index 0d86927819c2..9ec038f1d0ff 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dts @@ -36,8 +36,8 @@ display0: disp0 { status = "okay"; display-timings { + native-mode = <&timing0>; timing0: timing-480x800p60 { - native-mode; clock-frequency = <30000000>; hactive = <480>; vactive = <800>; diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_7.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_7.dts index 66271daf97d9..b3129832f471 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_7.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos_7.dts @@ -25,8 +25,8 @@ display0: disp0 { status = "okay"; display-timings { + native-mode = <&timing0>; timing0: timing-800x480p60 { - native-mode; clock-frequency = <33246000>; hactive = <800>; vactive = <480>;