| Message ID | 20240527-cocci-flexarray-v3-4-cda09c535816@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: Fix the last set of coccinelle warnings | expand |
On 27/05/2024 23:08, Ricardo Ribalda wrote: > Replace the older style one-element array with a flexible array member. > There does not seem to be any allocation for this struct in the code, so > no more code changes are required. > > The following cocci warning is fixed: > drivers/media/dvb-frontends/mxl5xx_defs.h:182:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/dvb-frontends/mxl5xx_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/mxl5xx_defs.h b/drivers/media/dvb-frontends/mxl5xx_defs.h > index 3c5d75ed8fea..512ec979f96f 100644 > --- a/drivers/media/dvb-frontends/mxl5xx_defs.h > +++ b/drivers/media/dvb-frontends/mxl5xx_defs.h > @@ -179,7 +179,7 @@ struct MBIN_SEGMENT_HEADER_T { > > struct MBIN_SEGMENT_T { > struct MBIN_SEGMENT_HEADER_T header; > - u8 data[1]; > + u8 data[]; > }; > > enum MXL_CMD_TYPE_E { MXL_CMD_WRITE = 0, MXL_CMD_READ }; > While this patch looks good to me, I'll skip it until my comment for the previous patch is addressed. Actually, I think the two patches should be combined, but I leave that up to you. Regards, Hans
diff --git a/drivers/media/dvb-frontends/mxl5xx_defs.h b/drivers/media/dvb-frontends/mxl5xx_defs.h index 3c5d75ed8fea..512ec979f96f 100644 --- a/drivers/media/dvb-frontends/mxl5xx_defs.h +++ b/drivers/media/dvb-frontends/mxl5xx_defs.h @@ -179,7 +179,7 @@ struct MBIN_SEGMENT_HEADER_T { struct MBIN_SEGMENT_T { struct MBIN_SEGMENT_HEADER_T header; - u8 data[1]; + u8 data[]; }; enum MXL_CMD_TYPE_E { MXL_CMD_WRITE = 0, MXL_CMD_READ };
Replace the older style one-element array with a flexible array member. There does not seem to be any allocation for this struct in the code, so no more code changes are required. The following cocci warning is fixed: drivers/media/dvb-frontends/mxl5xx_defs.h:182:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/media/dvb-frontends/mxl5xx_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)