From patchwork Tue May 28 09:20:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xiaolei wang X-Patchwork-Id: 13676372 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E8C2C25B78 for ; Tue, 28 May 2024 09:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IvLCFL9KcebIfduGYZdIiT1Jo/gbWRysRG3X/tkabQs=; b=3mTaI/8eqkfKfG xrCbTZINjMrg7WhTnmfotnErOh2DR4Tk2kvaYWIJwJxw9ZgXKZPQs1HZJBwZW7eFzmQfONTs60gyn Gv78sbWIAeJIlp7r3II1Xig8YxoTfWavbdyTxdelEqH0MnqUlA7i8Acm+kHgHmxq27T3bZwN42eYh 0eIA5M4drH0aae4/dqT230QeW+VWaNR08uMrSQkU2K5emOoW/EjFlQX2H8DNiJ889nWRn1VUgUFcO W7MCzv8MDwlsN+0ywTMntDALGHqNJ+0/8cCa4+gOPFxpBALbp5SH4SJPenR1QfFvlowOEN1JDU94N MlcbpEJ1no4TfujVG0Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBt14-000000002RD-0lhI; Tue, 28 May 2024 09:21:10 +0000 Received: from mx0b-0064b401.pphosted.com ([205.220.178.238]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBt0z-000000002PI-1qsh for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 09:21:07 +0000 Received: from pps.filterd (m0250811.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44S7osWE024273; Tue, 28 May 2024 09:20:32 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3yb56xatk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 May 2024 09:20:32 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CkKknr9LOwu/xy1Eds/ns//kxczXrZFaALP/JIvIN0Xvwascax4ft/FyuHm+MVAtfwqsq/XKQR0lDTDGKc5h/QrFEshzeEGSo2wxooptZtWFdMppTg5jk3lDP6Ow6tEhwR1664zSRbZlDcwoAVCMcyGAUYjW3BbcE6S+e49XhtlfZ4uSEs5jbLteQkPV8h/KdGxrWROuFrBnmTbx8+Xg/hHO7PIQ7PmpO8rB+BxJTr+qWKW5dDKRnW7TneO4xCNRaEeuDcrBM9zh15umP59peZSNJvcGmbxk3kmjhzK41LdKp0/QH0SazU22fUcIspbR+BmzHTQNwkWg1nr7ey3c6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lUp+53SPKeCuGz7fLAVdGKkiKH8oJgol1upT06qOa2g=; b=PQcT6941SyPsb0fkTHExZV3L/4ptCzfCq0PSTxTD/TqCXYBGlndnRCyxy5WpLa1+0UD66UtJolOVAAO875+Svt81kYSWBHaRQKJnINVy0gcZ+O8mn23s3/RAiYehEHWpJSr8LFP28TjjupfNRkIc2wpH6YxoGiH9R+mNKzRi0Oc81ekYNMwyQ6xHPkGyhyijA9w3G4zfkTNKBQRyf7UCz/nNnosVXq7cs+cqvnbZXnNxvieRdECODiUosp8aybDpGN6YBbv2P1zDfunNEZsl0uoVWRsnSn0FODPJGshY34MjZwHHS7wVmFYYm38USttBZh0PeNy7NI7J/MYV8/prhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from MW5PR11MB5764.namprd11.prod.outlook.com (2603:10b6:303:197::8) by BL3PR11MB6385.namprd11.prod.outlook.com (2603:10b6:208:3b5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Tue, 28 May 2024 09:20:28 +0000 Received: from MW5PR11MB5764.namprd11.prod.outlook.com ([fe80::3c2c:a17f:2516:4dc8]) by MW5PR11MB5764.namprd11.prod.outlook.com ([fe80::3c2c:a17f:2516:4dc8%4]) with mapi id 15.20.7611.030; Tue, 28 May 2024 09:20:28 +0000 From: Xiaolei Wang To: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [net PATCH] net: stmmac: update priv->speed to SPEED_UNKNOWN when link down Date: Tue, 28 May 2024 17:20:10 +0800 Message-Id: <20240528092010.439089-1-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: TYCP286CA0070.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31a::14) To MW5PR11MB5764.namprd11.prod.outlook.com (2603:10b6:303:197::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW5PR11MB5764:EE_|BL3PR11MB6385:EE_ X-MS-Office365-Filtering-Correlation-Id: 14e59872-43a4-4009-0870-08dc7ef76a17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|376005|366007|1800799015|52116005|38350700005; X-Microsoft-Antispam-Message-Info: upk4/b5svlGRPBHZBNZbP5zxBW+P9uyvDHSiqca+eeAUPdydNLp/OJxQFqXz4ql+UCVesAHPDo5CTNEN6B4It+Hgm5s1Gry9mBar6JukDoclOvVzRBerDJDjxqTdcPNmw+eOhqpCd3jbHNE14cnCTaVxtXzEQIxl/rrdrs2NySwjmMS2Sst6yyiooBE2PmTZjas9oU+RPd0rTGNS9V9oDAuaCEFyEhv7qzUrTSrbvtxfQlFciFMIrUn8jJSUYGJ/+iSQwl7U/DCUN+7j8059Dp8zcGO3HRqQC/geQoZGAVPEA2z4n/wpM6sFwdnMaK4pezSninKwUk0iVKIImK8KAD6JkUvR4/I+okKOmcdccmaMoFp3A9VlG7dgYXX/cDwYoAny2eKTt8spk8yrrpw1JbYymQPy/1KW77fqqBItH2cIIUEPpd1GcF1Iu1Urv66EPnOBXPF/karhbtKFyndqLFHoEO9q82JxqK9TU0MkXMv/UlDXILMI7+5DoHXUzd6mApDhthl85AAon7bEBwsEaSC2ZoZ3kV+1Y7Hd4a6yRsSjIAKZVMgnFURfnYyEkIV3z5xeDVuvlIIJWKqpsTPzUnaVrwfEeod1IYje8rINU2+sUiGQ9Hm5WNOTnywXhVtuCAFq/PCxEr2uDw+lLKTJxq8HdHe27j99k5JA5ojYqBiFuv0vDBlhSmxpZXvlcZPlFLuVtS2QspXEgoyAJXMJZDWkqksA2BotRtw+z+2bxmxRbblaIPr3E/DY3o0wjG8DOpkl+EcsorZ5Mwt0/l23dVq8gzlAtSaoxX7oyPov4ykj64lXcN8/HlHSEUqbTcQgv/A10I/lqUBNl0ZZuBtLonvvHnzcINeNxI9CihEOTYbko0I1iXhRx6ntbr6qQJh4wfdWfS/oRpONdJ4hic+qScrOl6obAFLUaeWTGAQngf6BXrb5FiuJhbkdn1//MicV4OY8ztwh6sgucv7b38FX6baqBZ5ujHRYEVilIWhiBcl28NUaCF/h3htULkVucGC2SOvcSOh3vPtwQ0PDaLibvlsb7aJn2cQvvhMuhMSp023ODFWlHA7dzYKc5zxBDS5nEnuPFhG73vD3vFZHYf1F7EzsGjjXOBy3wfnYm7zWVnfy8ncG20l0O2/haIhNNjrdgVub2rEb3d5OWAvNAr63kDxr1r1l7vaoXalC5MfmLbBgAVm+1z+sd+ReFcR3bOn9umsts3i7jLTMOP1vYWpiOpTl750tKyvhd01Iw4rMXj3b7T4tff+4qccmaCw65saJnSybS3WDrQHSgSo8O++tPBZcIoSc3vO8jPJFLfX+gH4Eefs+5u1ZHcDLDld7FQfHWdzz8F/8/2S1awteNR2BOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5764.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(366007)(1800799015)(52116005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XmycGIsKuRoNnB4jNipsPyX2OAbz1plMOK1iVKxlEd4JhsCukXHxJC2DJb+u0PBCi8ZhpVP39NNWAMLmlYZmQm1mnmvHcaVvftboKjNNebMjeoo2VcZrHgmddgZUCgBd7Nl+EKkeT/TDBT10kAfn4K9P5IzjLC+4+k0xVeKQb0qGpbpm/MKih8bpvFtliqV9GfbBx8xJq/0AtNv3nLLSdPflBslSkdp2VL/AmIV2UdAu3S0//5nzY8vND3rVWK3B5sHDvcYpXrYJ9fYHjZUxiXRZficPL671YQ5ARERe0ji36KpO6tgTBZ44gRBBMYHEDtR1VWCTdCY9xowz0NrlHxZUH62TgszkZ2sBRiUTqQszYoS6vVb1qlQJbBdpZCn70hXyKmrn+uFrIQFl1RGgPUF5RTOywWo75yFjerXJL/JibMJLTrGdYLO6O8TNfUNONEhMKikSsRQXv/90CVyt22YS5PD8wrIIYJvzX0KC+AuB9pBHK3tTg+vISoPoOH1LTeEzvaGC7wNa1dunsHlrApT5RR+HCrn8xFSWiDtyS6Z0qUgCC562LrTKokSyjjkZkjbpX0yb2mKz9bzfZTgXtsG0M5KCtAcxIp41+ob0/tUeduJMtqNJNv6QioUwg5GIYtiwZQ5KZt+cCvDy7SgZrIIQyfKYs6cJOJmkovYpEPEuXnagVpIto90fI1yuFN26+ZbFcWmFUK/NDLtow1BH1Bj3A+d/nthL+RNzT9nfgpOdUY5aLwHl+gyFmD6cFjqj74JnkS8A84mIFg7GmlbNQQkaNARzQh2vJvC/alZF40mNJGy7RekFnG9Y/aXXjoMMk8W2Kn6FbAVsw1YKumWuX2PnS/p8ewQlK2rKtJLK9nbLkbg/XZWfiBwrF4+P4sSY3d/W5nfqmf/K2/vAZY8XbufPCVZVd/CoGfQol0qoyU1w2+nx6zs/8FrcWSpfge3NvG885P+SoX+WJmMpArvWvyfrMsoKcaapr2WHfHUr9B2U8lvFAMYSOjaPtZ8PHrv7BIBtdHXwDL9Et1vmY0l9PV0epVYhoIAXoOtLnP4vLXex3Cb9UKxZYG4kwKvnA+wgc2ZRICQY2XwU7B2FUFRBBNE7ghP8mXc6jPbaWkeIvfoq8+fAsAxeDxJxZvjcjUWWxltS83hcfFH3d3koa3z3GHJ2syviXdxCp/pxZ2KEmUp7pXR4X8pa/dXfNQgR5WMxMnsuEZdXl59ROIIYsoK/D1dwmEjXFsksueeGDdV2rDXlYfe7PZU2MjjIKZ5CqWlf/0ZbYfg1xSE+XPKELShgFohZX9M1IHWjQlpoKNUui3m05fN3OQOkGuWQlaoc4NFqchtFpWJdkA5H8mY9t78ZHKzVimTPODJBcmFdgObVv8p1RztTTXxbVHr7NGnZdQQ3kRhPCF5JNh2YFuxq6fKcGBtZjA8Ht2091C0jhF6ixtDXC6w7fvR1XE5d8hvXcoiqt8hr/c4s/I6SpEfhO5/TtSyqTXL7NeCzKbN+sV74A6TmUA4+2JrB63KWVa/EjmCnOAtoo8RAx3EenN4mcr/j4idlvBH/qdj2h5fnla6cF8mffc4zOys2LYFBZBj0ZMqhv/hibpbwWWLU54NXyEZx7g== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14e59872-43a4-4009-0870-08dc7ef76a17 X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:20:28.3280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vqjoHqtk8rx3N3MH3anzX9aF4UWo94n0Y7MHVMMkI+j0TeDqiqJxPZZwJrkR5UaUrz6uYSiZWZuCWmqbbrUiSaIMZLir9RZkrSlTyS4ANDA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6385 X-Proofpoint-ORIG-GUID: KX2Mui1xtmH99k-_Pu95itSaJ1Fx8uN4 X-Proofpoint-GUID: KX2Mui1xtmH99k-_Pu95itSaJ1Fx8uN4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-28_05,2024-05-28_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2405280069 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_022105_620432_AA2A86B8 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The CBS parameter can still be configured when the port is currently disconnected and link down. This is unreasonable. The current speed_div and ptr parameters depend on the negotiated speed after uplinking. So When the link is down, update priv->speed to SPEED_UNKNOWN and an error log should be added. Signed-off-by: Xiaolei Wang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index b3afc7cb7d72..604e2e053852 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -995,6 +995,7 @@ static void stmmac_mac_link_down(struct phylink_config *config, priv->tx_lpi_enabled = false; priv->eee_enabled = stmmac_eee_init(priv); stmmac_set_eee_pls(priv, priv->hw, false); + priv->speed = SPEED_UNKNOWN; if (priv->dma_cap.fpesel) stmmac_fpe_link_state_handle(priv, false); diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 222540b55480..1e60033c6fbb 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -378,6 +378,7 @@ static int tc_setup_cbs(struct stmmac_priv *priv, speed_div = 100000; break; default: + dev_err(priv->device, "Link speed is not known"); return -EOPNOTSUPP; }