From patchwork Tue May 28 09:39:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13676381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FEE4C25B7C for ; Tue, 28 May 2024 09:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lQQwIDJPFklcitFdgbDUwaBK7gVu7yGvnSsfhdtaHhs=; b=KJE3rJAOXF6O/y 2/vDrG9VZa2B3GHU3K4R1LN37zhCv+rnmD3DMUFpxPh/w7aYEKLpbCQPVV+pXXoPodlz9zHXcHQxh W90CK/5DKwHsJCU6nk9zqog9jnmsJujwTrdKicXIToyYcHULXTvng6vL+raLoarvnSwVhN6KVw7lF Vujx5jEV3apkUWLaXIrKFhqgQcq2gTxrP5NFhGyfoxb94IdjIierBjAyll2yjE1+h0rEh/2DeU5AG 43OUcKcD5+rxFdW1Af5WK2ik0SkqEXB1GAiukSJoS7B1nnTuLIP7gKid2R2cbgytioYxae/lduztJ 8JMTty1aLYx9TOgvLl6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBtIz-000000004VX-1RLb; Tue, 28 May 2024 09:39:41 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBtIw-000000004Tm-1DLF for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 09:39:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1716889178; x=1748425178; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Vqve763J/fnX5w3j8DDUs6X/uVtGpHOXdGrGBsbN7qA=; b=F8285J/Pzsj0h1oZmh2nRCepN9v3jbqjN6m/JVGJHKpAldNz8g4uJ6ep 5ynCyJXTQzt5Keo2oQ6IzdDSqHtU/u4pdgrKQzUmXgs7D0V2K9xHjySH8 NdQfaQvc8UFPZZ9e+WtrXMSW/ECC5v+qltGUfK124YRCXLeqMf7O08CaO Xtu2Wnq02gSAVgSi+9Dsy5DE4GIn7Xnx/1yyaOXIL8wjQLg9GtZVcsoDr X9jG0tdto40sWYeN4PgK1WWF4oleoixTX353/afyUaQg5TqH7m5cLmfq0 98hTOFYPTxmMcweu1uGZSEhaCxqyHWmJQGxexeJeSIoHsbqFNHYXMFQIh A==; X-CSE-ConnectionGUID: 2k6GM/7jTsO5KvQ5L84hDw== X-CSE-MsgGUID: YiUP1NdXTn+RyzxY1Ae8Bg== X-IronPort-AV: E=Sophos;i="6.08,194,1712613600"; d="scan'208";a="37100349" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 28 May 2024 11:39:33 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 08CE4164806; Tue, 28 May 2024 11:39:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1716889168; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=Vqve763J/fnX5w3j8DDUs6X/uVtGpHOXdGrGBsbN7qA=; b=BJ4R6F1CzUj3NIBsbMaYLBCt2DbeFl2CI9KPvuf+j5wyxi/OuPHjHCHaViG8kabd5LMcLh 7jF9z9C1IraKLgL1hUCINKUagX4RFZ6fw5U2LC5ki2TXATySWQ5A1Hze0oYRRJCJ6IAwt2 ILnBSjQ3TqKJygFA2nBz8Y6tJCdx3o4NlvibJ8nkibKQGmAmo6pnpq0tnqZA2nf6URuua5 saW0r6Rb1CqJuRNMWHurRqXJl0vN+YsmhdGqceuiaPqMtpQ8ASbGz6ALlV//fhz+oINt2c LFwppkiU9K4XKYEIJ0IvywXEuZpmLP84MpJPmF01OY4iFBNwG/12AvRn7WCUMg== From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Alexander Stein , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe Date: Tue, 28 May 2024 11:39:21 +0200 Message-Id: <20240528093922.194684-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_023938_837485_91D77738 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible removed), it lines up with the other error paths in probe function. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c index 2347f8dd632f9..8331db3b4f054 100644 --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c @@ -841,11 +841,9 @@ static int imx93_dsi_probe(struct platform_device *pdev) return -ENOMEM; dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl"); - if (IS_ERR(dsi->regmap)) { - ret = PTR_ERR(dsi->regmap); - dev_err(dev, "failed to get block ctrl regmap: %d\n", ret); - return ret; - } + if (IS_ERR(dsi->regmap)) + return dev_err_probe(dev, PTR_ERR(dsi->regmap), + "failed to get block ctrl regmap"); dsi->clk_pixel = devm_clk_get(dev, "pix"); if (IS_ERR(dsi->clk_pixel))