From patchwork Tue May 28 12:02:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13676570 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AE98C25B78 for ; Tue, 28 May 2024 12:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=krxlnL9pbsGZDEEgnUPfJ8XyZu+LM2EFsFUoMsFsdaQ=; b=tLg9K6Oc8RpA/p e4Elw69/fEKbzMnAiYpY1LqngXZNhglqpMa8GEeLz80Il3gUk3N3F2Otl/o/TvnGRp/7jD+OKMzvP qRmJyqhk1XY7Jve/58dDJXpn1+RjvSYgFtKULYWKbOoqLb0d3hLKzCgnKy54ZldYNDP4z58MeQgvp U/VpB+amHO1xoOqC6FYui99GQ7SJ1HoeFeNWiWECkSx2BJ6Gj2s4SpesQhOH/L3D4LCI8OMaEHi1v QRmwOGRQ4CZAvhddyXHXHj3x50cWhJS+S+0usOJXlsaByhLlsiGrIfBfTpfsI9bmoronwB3UKE+z+ zFLUqSLl7zVEkCTXJfyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvXd-00000000UOa-0pmT; Tue, 28 May 2024 12:02:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvXb-00000000UNV-0gTo for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 12:02:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7048662058; Tue, 28 May 2024 12:02:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3E3BC3277B; Tue, 28 May 2024 12:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716897772; bh=8Sj9m5H66IoU8ACiyDTo30Tfi2x2L8Km6KRH00ITSdY=; h=From:To:Cc:Subject:Date:From; b=Pa6Gdsmsd3gU/YG7bvsnP0IOUy9r6KCeSrp1EIQ8uNde0Mk8fqXE2/wR2FE23xJF+ h9iV7r8pgRLViN5RF0+fYynanOkWrleRQZd6sr4ReTx3kv7t6q+Y/77rAuZ2XZl+xZ lkUNyrzWZbJtH9RV15AI/0mab3moNfHP/e9XCDptDzIZDJ720XaYqPbnbGYU9n3knQ UZzpBxLtnu9pPCdUJ8QssZoWD+ifm672wPRi8bzvxjeFDdGb8b/GGQIQ1xnMyDjwKJ IZrgGMpb5bylM4OawPncoAny19/Cxnx5keeKF/2BcoNvGEvk3u3nHpAHURlLFQ14ju EHHqKEVkdgO9g== From: Arnd Bergmann To: Jassi Brar , Michal Simek , Tanmay Shah , Saeed Nowshadi Cc: Arnd Bergmann , Ben Levinsky , "Gustavo A. R. Silva" , Rob Herring , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call Date: Tue, 28 May 2024 14:02:35 +0200 Message-Id: <20240528120246.3313723-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_050255_274173_B6A7719F X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann irq_to_desc() is not exported to loadable modules, so this driver now fails to link in some configurations: ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined! I can't see a purpose for this call, since the return value is unused and probably left over from some code refactoring. Address the link failure by just removing the line. Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI") Signed-off-by: Arnd Bergmann Tested-by: Tanmay Shah --- drivers/mailbox/zynqmp-ipi-mailbox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 7c90bac3de21..4acf5612487c 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev, return ret; } - irq_to_desc(pdata->virq_sgi); irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU); /* Setup function for the CPU hot-plug cases */