From patchwork Wed May 29 06:53:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13677938 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA84EC25B75 for ; Wed, 29 May 2024 06:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TOk8ZPYhwL/h4SG5zcFEKb187kb3r+kOBK7RXSH9X6w=; b=sU0aEIog+K9E0k ufonW1UiUON3OBkWF0FPkHAlUL8iJwiIX4zbfelxC0zJ5kmmw2PjOcgIjS5VVXx4P5oO61goE7iPV KN0NZniy3Q41FWTB9irtA1ZFllQP/EwGo+YQPVR0lgTDP7wL050B0PRGVE79Qrr2SHX7S2DnGl6V/ 3kRaZyN3wLW06vWt7KTuZahvMdLuWiMJAzZA7h0aMV7GntZH9rclTba8qxM1IUD7UvIvAdFSlrOM2 dkJYa2yjkESHAY7iNNf/aWLcDUI0Dtw0DZQj6Q9lrBd0tLLNE23NXRUVPD0fJdd01+VMLmgukZgad hPdPCqKWisQMp1NpgrXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCDCZ-000000034af-3NWz; Wed, 29 May 2024 06:54:23 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCDCV-000000034ZV-1EJs for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 06:54:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1716965659; x=1748501659; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QNRzo83mZGl9G2410HmioNDgIdVNX31t5SpCkoFYr+8=; b=Ed6YwPVuoLJieORj7ECIanU9pRJgswds8Hs+qw/ycSaRQB+aUNtH40zj 4wyObIhFWjo+TC3+M8/ENBYXIneXOigq1PboOBvjKho6420hXh27vXp91 uZJMohIDSdCJW334Y513u3ioWVuzIEBOkkAv1W6UEzWI4n8tp/dIRSbFQ 4ndTSaNIg7ZVDXY1tyxsE7YTYdcHpRcTVcz5tpCNEul0zhuvnSn2M1xol mS+R+hPTHHLxSKmP+Jd93FJoe5zhldsd40VxmmhxWYGGx4SrcMu+h7R8L P2+UTmh+6qApggEo6zc00e2Y6AD3fi2AqH8jt3RC9uJc7UVZ0krCNBXc/ g==; X-CSE-ConnectionGUID: SJwekOs4SRqwQrXOawD0mA== X-CSE-MsgGUID: DYZpWyxERPibBz6M9pvhCA== X-IronPort-AV: E=Sophos;i="6.08,197,1712613600"; d="scan'208";a="37117803" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 29 May 2024 08:54:12 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 78F8F165466; Wed, 29 May 2024 08:54:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1716965648; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=QNRzo83mZGl9G2410HmioNDgIdVNX31t5SpCkoFYr+8=; b=Bdfeg6gH84Vlbe+i8jRR2jAr7aux6uMweLpkeI7vw7sP3H2weCpr9L3pkQ/FQQFpXu67Z6 n9o2+XU0DjmRnsL6E9p7DoXxSmWDyn3kGa6UDEPKITRSPMzsm6Ay3AvRpJ0juX7uGRwerf toYPhm4AO86z2B0O51REBXe8G2/YfuNQL1l44tNk3fPT+P6v3eBG9Eb+x6g6icv0eSkCFb n1mcImCbeiR+Zue9qf2KX6iO0pXvrpjuwlcyLFE8dxhBCKhEsDb6w1/YBSsBvUNlz+rwIt MDjtTfp7Dm/CA6SesEOfykOEgvyiWeNfD7nX6yjtkO8Iv7NRLE0YEI/0pciNhA== From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Alexander Stein , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe Date: Wed, 29 May 2024 08:53:58 +0200 Message-Id: <20240529065400.461633-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_235420_130992_1437BD42 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible removed), it lines up with the other error paths in probe function. Signed-off-by: Alexander Stein --- Changes in v2: * Removed unused variable * Added missing \n at end of string drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c index 2347f8dd632f9..13025f47f3902 100644 --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c @@ -834,18 +834,15 @@ static int imx93_dsi_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; struct imx93_dsi *dsi; - int ret; dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL); if (!dsi) return -ENOMEM; dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl"); - if (IS_ERR(dsi->regmap)) { - ret = PTR_ERR(dsi->regmap); - dev_err(dev, "failed to get block ctrl regmap: %d\n", ret); - return ret; - } + if (IS_ERR(dsi->regmap)) + return dev_err_probe(dev, PTR_ERR(dsi->regmap), + "failed to get block ctrl regmap\n"); dsi->clk_pixel = devm_clk_get(dev, "pix"); if (IS_ERR(dsi->clk_pixel))