From patchwork Thu May 30 08:35:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13679921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2592CC25B78 for ; Thu, 30 May 2024 08:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HKvYy94wJ+kco2T3/844DNgse/pxxyVxBaaVlUqhvps=; b=am9jNQZw/VGsOR q1PcP6daIa12U0GNd2Rk/qdeuRUGg6hLAtTrIx0D3f1qZUmdLQXX3Q5DASx6KN9mEed/N4xomYKrt 8Y2B0g5wYnhQ5L2ka2z858LXwP2jU3pGiLFZzhLV33p2fut7oJ8OT7tUua2R8P9M++ouchudzjACh pZME2+wMtOT50222MfDOJFHTDienfr9Y+a6KZ4/TaF6VjEK+vkLaRNAlIfHhxIKAcvk8tqISz1Goq HyZHUf0ONacibEU9ANA0+ph/YfOUOxweZGJti5LE77mkFce8wLqLeYwbGxv6pAQBRUp6Vp/w0ZI+B TGp0IfAa4fr5KmOGT3gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCbGx-00000006eJi-2cGC; Thu, 30 May 2024 08:36:31 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCbG6-00000006drA-1fNR for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 08:35:40 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1f480624d0dso5318215ad.1 for ; Thu, 30 May 2024 01:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717058138; x=1717662938; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SmWglR2Ij5/TGj5MHHzWjORF1jpZWpClgT/eZSAiwmw=; b=dgdwlRSzc4MJP7IiOfmFXyojkNb1LtjAzuc+Yo13RsIwfCUVhJMdDVZ20N+TkFPd35 NRi/D9BpvQXmQQZirhMfjhz9HqRxQnAhec3p5NE67QihfFXbN7fNltcpqFyIuhwomj3a t7CigDGZVFE+1A1T29VQdY8RXlZF9EktmC12Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717058138; x=1717662938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SmWglR2Ij5/TGj5MHHzWjORF1jpZWpClgT/eZSAiwmw=; b=WYBvKfrraRv4+P3SL6K1wsmaWlWPg4kpApnm29JOHooAVw5aCJvxnHAQMkGo6S32+R RkJpQR76OwXdPN4VatiPS2lxly5wfPW9XRg4rhaRSisKTBNHCsN7cPR80GN5kwwVkKZC 5I4Oef0Q/Q9SXUqOHBP1vU80j7ynWPg972XSLx/Io8BFS2KqTqJnKAgG5dzblKxhzIih cz2E9RIC5uknc/+jZp0/8EpemHTVaUoGbUKVy3WBoKiGBnge2yQY9mb+zTIOBni4/2Xl BX8+8Tkld/osuZImTStFpPyxWOpKHHVR1yJtTSPuPO1w7hQ2DFCw2+qhmhdYKXesioB2 nyAA== X-Forwarded-Encrypted: i=1; AJvYcCVvH8etMbSU9Cfp+7donbkHBfyibvRXmZx5r+oOW+SFcd0tsD1sp62a5cntidsUWeVLx2Whc/4K2Kw1738w67eCitWeaLbURVSgqrvLdpMGkDnztr0= X-Gm-Message-State: AOJu0YyWUf5yOtLsf0tZ4BUfaPVSgXKwWR8nvGe2dN1qm1DSe5pJ3BKR emQITbzUEbgk9yxZM1tfbWXVuANqTeTeHELrYlu64S3b8iuBiY5DI1BpSfsVJQ== X-Google-Smtp-Source: AGHT+IFpzoyjS8oEHpsPco6/0czovfTG+BgxZDwOvkJUGlKruUTXsaiUOVp8Alhb12YxLjpScrPXfA== X-Received: by 2002:a17:902:74c8:b0:1f4:7f18:6d7c with SMTP id d9443c01a7336-1f61a4db927mr16665575ad.61.1717058137709; Thu, 30 May 2024 01:35:37 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:65f0:63a9:90bb:50b8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f617390fe7sm10950635ad.146.2024.05.30.01.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 01:35:37 -0700 (PDT) From: Chen-Yu Tsai To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] arm64: dts: mediatek: mt8173: Fix MFG_ASYNC power domain clock Date: Thu, 30 May 2024 16:35:04 +0800 Message-ID: <20240530083513.4135052-6-wenst@chromium.org> X-Mailer: git-send-email 2.45.1.288.g0e0cd299f1-goog In-Reply-To: <20240530083513.4135052-1-wenst@chromium.org> References: <20240530083513.4135052-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_013538_517035_114D08F7 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MFG_ASYNC domain, which is likely associated to the whole MFG block, currently specifies clk26m as its domain clock. This is bogus, since the clock is an external crystal with no controls. Also, the MFG block has a independent CLK_TOP_AXI_MFG_IN_SEL clock, which according to the block diagram, gates access to the hardware registers. Having this one as the domain clock makes much more sense. This also fixes access to the MFGTOP registers. Change the MFG_ASYNC domain clock to CLK_TOP_AXI_MFG_IN_SEL. Fixes: 8b6562644df9 ("arm64: dts: mediatek: Add mt8173 power domain controller") Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 3458be7f7f61..136b28f80cc2 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -497,7 +497,7 @@ power-domain@MT8173_POWER_DOMAIN_USB { }; mfg_async: power-domain@MT8173_POWER_DOMAIN_MFG_ASYNC { reg = ; - clocks = <&clk26m>; + clocks = <&topckgen CLK_TOP_AXI_MFG_IN_SEL>; clock-names = "mfg"; #address-cells = <1>; #size-cells = <0>;