From patchwork Sun Jun 2 12:04:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13682807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81D74C27C53 for ; Sun, 2 Jun 2024 12:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k6R94972TaPoFcUPjeGL8LJH7VLlxg1u7cqNpvQr0XU=; b=HhbNpsRizzQZPm 9NvW4fs2wKJnmIThHglbGCAEfk9XWwNpUdna4C3m1RgnHJxF3MxpVX8XOfvozjM8ZHmtKFyKS09fG Bhk441U0M50y+8OduzxPuMeVIzK3S+YmG5Qg4D6Y0cdcS+txI2s1MzK/kI73Dak5I1GdTVp0iPJE+ TRtAV+P19ia0I0IHQWXUMgl2fvVGXU5zR4P8VO7LqKBtfDAa4ZAgIWejkzo8nN3oF+Xlcl1HGKAJV qRA5o+TMbpOCXUGqGKayCKCOBRh4dJYjvvm5dP129/AIF/IdZZxNAZJFRi8UoBs10lUDamOqX+3B6 KzJZ4PLVyIRAcIcrTI/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDjxK-0000000EBQd-0amm; Sun, 02 Jun 2024 12:04:58 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDjxF-0000000EBMJ-0EfT for linux-arm-kernel@lists.infradead.org; Sun, 02 Jun 2024 12:04:54 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-52b938587a4so822664e87.1 for ; Sun, 02 Jun 2024 05:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717329890; x=1717934690; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qCmMEV20sJhl6q9JP4BtOvE1ThwKifoA/eb2lcmOX/k=; b=TQzhoztEHLvN21lsn/8GnLLZuQR7h67VCxsxaYA9QPcBC/XJowDimsQhM8FlmyV2/h uMmgPQPWxhKkONX4S9X9uLuvyqm0FlIMHtNcjBGarfl8tm8nIqtd245MYSQOcPV9jFkm zhDI91GKcI1F7ePPjU1mVpXBuXMzdNWqNO/kAx1bejRe+g2lkqJ9xTm6KtP1S/mUT4VL ZocnZYPA8IaBOgiKF0dXLc3qMhqOrmJXlfwwp6Sr6T4JCKumzUWpq+11qAjk5A1SV9W7 qzc79QEPkl+3OS/evnvSaDz0lVWV1+aCPp08yPPn6ZmYxv5eiTDw1aT1nBmbwMeTQpOD jo+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717329890; x=1717934690; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qCmMEV20sJhl6q9JP4BtOvE1ThwKifoA/eb2lcmOX/k=; b=Dketg7Gkk26eFIEweX73FZaJF1Wv7tsXNWAiMvSgvgNgml3/gR4y71MeX/YvfJLzZL EIIzq/ISkfz+WyG2s5rXCojH+ajnBAodevlfOwVCoPWGtVOY5d4tME5w0fURoT4uSe75 1IEwN4MCwNvccVahrFwiAUXnP3PGlFajNyBofuAhTBhiCgYjXm7NZlnCOqSbI5WnF/rB UkOU7tvUp4a+fNEL//zMH3C7TZLenx31KAqMzrc8EZsByw0e5P+H9VzxZKzKtWhoOUYg lsqIUIqhrcdvSgjXpZdo828TXgkgDIqyApCpzBU1kXGF7kzyXQuSuSmO+du1yzM9WX09 xGbQ== X-Forwarded-Encrypted: i=1; AJvYcCXnxfkXikdcgDmTb0m/gkzCtPHGjtp3JLESoxUs9s5Haapk4o8UqILHR4UiUh6IKWTG5pbIjugwY9rJY1i4RdAgSKArQi+6qDqb1hT/FLPGkfozAQo= X-Gm-Message-State: AOJu0Yz1/4+gV0y6319TSFFViex3vr0AhZSijEb99cz9bhcb1IfR9o3K AfvE5muNNhyxlh91Pg44sbbKugdGJXaL9PNcQJRq5UoXIkgaDPXKvXJ12vsG9xQ= X-Google-Smtp-Source: AGHT+IGCiCd1TG61yPuHP2aBTp9MSL5cxIMjf2EW/NA9zU4V8f7CT49VmAhc+8/OK+n9wpRK9ETuPg== X-Received: by 2002:ac2:58ed:0:b0:51c:c1a3:a4f9 with SMTP id 2adb3069b0e04-52b896d8790mr3599090e87.64.1717329890158; Sun, 02 Jun 2024 05:04:50 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b8b56867fsm759398e87.44.2024.06.02.05.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:04:49 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 02 Jun 2024 15:04:44 +0300 Subject: [PATCH v3 04/12] drm/imx: parallel-display: drop edid override support MIME-Version: 1.0 Message-Id: <20240602-drm-imx-cleanup-v3-4-e549e2a43100@linaro.org> References: <20240602-drm-imx-cleanup-v3-0-e549e2a43100@linaro.org> In-Reply-To: <20240602-drm-imx-cleanup-v3-0-e549e2a43100@linaro.org> To: Philipp Zabel , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Chris Healy , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2329; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=p3R84UdnZzJNiooJHROp8P8TIKNW8VASKGnwF+31z+M=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmXF/cNOEQ83ng70X09QmeKaF0NL8z0h92yMj9M 305afztkWaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZlxf3AAKCRCLPIo+Aiko 1XexCACDSDdz/1zzBjj/fpPm9P74sgM1RPvq3rFuMSGAAgAMTldnUNhsH2r3LcogCivWWmXLeQF FqDenyVNvckt6NZDDg6cToyVSWnoY0/ZPbdNrI7al6UeND2y/snsiBo+L3ozuiDfoDdPm9ntfyI kBjy+bvMhGTmH9M5MvVwx9D5yk3XRVD6h2WP7dYTK0WpupSnRdq1EMF9Tl4jmYZY5LxwM41oc0h xvy5dVsY3tkCZI0dutTeNAPMJ5H4I6LVRLSiqOob7HGMrppHtwBbxjKtIro4Lqr1zr3Co29GKT4 Kx6xBvRoI1UOucJZYh4Ditfs6oa2OpLJk1rEb2MW/QQnLOZQ X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240602_050453_141914_02874D28 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org None of the in-kernel DT files ever used edid override with the fsl-imx-drm driver. In case the EDID needs to be specified manually, DRM core allows one to either override it via the debugfs or to load it via request_firmware by using DRM_LOAD_EDID_FIRMWARE. In all other cases EDID and/or modes are to be provided as a part of the panel driver. Drop support for the edid property. Reviewed-by: Philipp Zabel Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c index 55dedd73f528..4d17fb96e77c 100644 --- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c +++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c @@ -16,7 +16,6 @@ #include #include -#include #include #include #include @@ -34,7 +33,6 @@ struct imx_parallel_display_encoder { struct imx_parallel_display { struct device *dev; - void *edid; u32 bus_format; u32 bus_flags; struct drm_display_mode mode; @@ -62,11 +60,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) if (num_modes > 0) return num_modes; - if (imxpd->edid) { - drm_connector_update_edid_property(connector, imxpd->edid); - num_modes = drm_add_edid_modes(connector, imxpd->edid); - } - if (np) { struct drm_display_mode *mode = drm_mode_create(connector->dev); int ret; @@ -312,9 +305,7 @@ static int imx_pd_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; - const u8 *edidp; struct imx_parallel_display *imxpd; - int edid_len; int ret; u32 bus_format = 0; const char *fmt; @@ -329,10 +320,6 @@ static int imx_pd_probe(struct platform_device *pdev) if (ret && ret != -ENODEV) return ret; - edidp = of_get_property(np, "edid", &edid_len); - if (edidp) - imxpd->edid = devm_kmemdup(dev, edidp, edid_len, GFP_KERNEL); - ret = of_property_read_string(np, "interface-pix-fmt", &fmt); if (!ret) { if (!strcmp(fmt, "rgb24"))