diff mbox series

dmaengine: qcom: add missing MODULE_DESCRIPTION() macros

Message ID 20240603-md-drivers-dma-qcom-v1-1-d1bd919352bf@quicinc.com (mailing list archive)
State New, archived
Headers show
Series dmaengine: qcom: add missing MODULE_DESCRIPTION() macros | expand

Commit Message

Jeff Johnson June 3, 2024, 5:06 p.m. UTC 
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma_mgmt.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma.o

Add the missing invocations of the MODULE_DESCRIPTION() macro, using
the descriptions from the associated Kconfig items.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/dma/qcom/hidma.c      | 1 +
 drivers/dma/qcom/hidma_mgmt.c | 1 +
 2 files changed, 2 insertions(+)


---
base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
change-id: 20240601-md-drivers-dma-qcom-c901844d7003

Comments

Jeffrey Hugo June 3, 2024, 5:13 p.m. UTC | #1 
On 6/3/2024 11:06 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma_mgmt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro, using
> the descriptions from the associated Kconfig items.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Vinod Koul June 7, 2024, 5:47 p.m. UTC | #2 
On Mon, 03 Jun 2024 10:06:42 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma_mgmt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro, using
> the descriptions from the associated Kconfig items.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: qcom: add missing MODULE_DESCRIPTION() macros
      commit: 8e9d83d7228f663ef340ebb339eaffc677277bd4

Best regards,
Jeff Johnson July 23, 2024, 6:36 p.m. UTC | #3 
On 6/7/2024 10:47 AM, Vinod Koul wrote:
> 
> On Mon, 03 Jun 2024 10:06:42 -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma_mgmt.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro, using
>> the descriptions from the associated Kconfig items.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] dmaengine: qcom: add missing MODULE_DESCRIPTION() macros
>       commit: 8e9d83d7228f663ef340ebb339eaffc677277bd4
> 

Hi Vinod,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff
Vinod Koul July 25, 2024, 5:51 a.m. UTC | #4 
On 23-07-24, 11:36, Jeff Johnson wrote:
> On 6/7/2024 10:47 AM, Vinod Koul wrote:
> > 
> > On Mon, 03 Jun 2024 10:06:42 -0700, Jeff Johnson wrote:
> >> make allmodconfig && make W=1 C=1 reports:
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma_mgmt.o
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/qcom/hdma.o
> >>
> >> Add the missing invocations of the MODULE_DESCRIPTION() macro, using
> >> the descriptions from the associated Kconfig items.
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [1/1] dmaengine: qcom: add missing MODULE_DESCRIPTION() macros
> >       commit: 8e9d83d7228f663ef340ebb339eaffc677277bd4
> > 
> 
> Hi Vinod,
> I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
> Will you be able to have this pulled during the merge window?
> I'm trying to eradicate all of these warnings before 6.11 rc-final.

We are still in merge window!
FWIW, this is in linus's tree now
diff mbox series

Patch

diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 721b4ac0857a..4d2cd8d9ec74 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -957,4 +957,5 @@  static struct platform_driver hidma_driver = {
 };
 
 module_platform_driver(hidma_driver);
+MODULE_DESCRIPTION("Qualcomm Technologies HIDMA Channel support");
 MODULE_LICENSE("GPL v2");
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index bb883e138ebf..4805ce390ffa 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -331,4 +331,5 @@  static struct platform_driver hidma_mgmt_driver = {
 };
 
 module_platform_driver(hidma_mgmt_driver);
+MODULE_DESCRIPTION("Qualcomm Technologies HIDMA DMA engine interface");
 MODULE_LICENSE("GPL v2");