From patchwork Tue Jun 4 17:29:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13685717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06103C25B78 for ; Tue, 4 Jun 2024 17:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IfwiXUun/PL+MgLKrv0V4XX+s4ZwW+Q123dnGFfcoQ8=; b=XWBF+e9iAEJYdV X9SFVgc8BZgTR8KwVbwXz86gQrjqImGPPZ6c8544lASpqYhJGFXNayPWfzje7UlqaoYWsndrKx+5I pj+D3UV1tQb/O/u3f6WZxcKGQqRH8AYLB1io7qxIsc4Uv1Nl+DUlj0KdNO5k71QovXaZEBQcHzANL Z4bzvP5fHpnZYWnY4hYc4dciXBKjsyMqBhA5FZ4RnBhI4h4coe6hYROT4BQ2FS6yawlFt2LNZnxU/ 9qzDMub0jZEf6CL/hcRejDnbFchxe2EZNjQxI1+d4oIuK97dRcuzop5SYfxSnkhHkB7lZN/V2ecNH fGuPy/RU2HGWchGgyl3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyv-00000003Iz9-3zN7; Tue, 04 Jun 2024 17:29:58 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyS-00000003Iel-49rQ for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 17:29:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717522166; x=1718126966; i=wahrenst@gmx.net; bh=oLnUhAfIjQvsBXkFU8uP5t4BlhGnaI3fAL0JXEynWLI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VQSrxt5UZeDVUCvvcy3VYT9EdFGXlw/+DuVjx7DJggG6soiMlbPa4Uyc7d2pzmGZ rBmydeCtV5ILIN7V8fjAW2s4rb9yrLRdKmi66Q29DMRrnbbKzNuyJ5bkmGNr5/Juh fevpJ7oQ1Gp+65lByd+UL/T1Vkbqc2jQm2Un3q4zvyLIg25bEzvENuMt73kUW+r9Q wabw0R49CTZIHBjjJswvQ68Rj9tsXwjR4QiY8Vos71wGmIH5QH91tVP0Hg46+9i2g HFTtMs52ja3fpJMVLi+3k3nGEj3oD4oP4CIg6DMAm11jsNsz4otrUJuKcMgpFOa22 ma0ECJbaFsghFbLHHw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MhD2Y-1siwlz43yU-00hvPr; Tue, 04 Jun 2024 19:29:26 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 10/11] staging: vchiq_core: Add hex prefix to debugfs output Date: Tue, 4 Jun 2024 19:29:03 +0200 Message-Id: <20240604172904.61613-11-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604172904.61613-1-wahrenst@gmx.net> References: <20240604172904.61613-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:SJfo5yqiDek4L5LZBudYlirCSzraVY5mTAlzRWetPA3So0NPwIw YIuZDmyUFMfPrBjSIDfGbfdfBfS6LqLuJ5Txp7WsDzIEGe/fkQqeOUVqUzVlMlpnDlBsXQd VkhzVIxPfGknyMJyFWf5Oc0aRboqU6i3+EjB+KBtrEltS71IQTguZewhDP4OsyttnxS0JWB W0/ox3fp6RBQqwfsXuw+A== UI-OutboundReport: notjunk:1;M01:P0:/rTqJoJHZAA=;CtAQsnvJsb0yML4lLJP+vzKbNZ9 LSQ6SFLJA2TZOJ/B0EqH0OWFT1MhNDVE7YCeNQTn4916b+wap6KQvQLiJaVkIkFsyQSVwF2Fd 30rpDmwmF1ys2As4ZVpKheT1A6y/yk8/x8XBEx6GvD9YQTobU6HStCVl1P5uIyWAslzQ7+8DT IqSSH10sJxHsgAngBcp0UksdiGbTj83Y52LpH5H9Mr0guhlmYDytu3YfPu0Z2xitpQ4UfiN3Z 4+/q/IG+97539YDbRgpUzSrz1AcsvpHmdmBVZyyHf5kbxNSsMS0BFhCQrwv8RGdI4OqWBkHk7 yHy8pydy14DTwP/DeirTbPfUh1+x864l1IJDGW44iszkbN2eEYBW3SjcVH4NOXUGeeFpLWqJp We+v3VkwaC6kur5v1j+8zClIYLHu/kplYN3bZQISD3N6xElET+c8RRk+bIa90yUQfmB6jY+ar tub+j8rCku2t6IEzoimiw9DQd5gSwIMpDA1Wn7i53RlcFIAQJtHkZ6GNoUdScDjP8MXKkngVE 0lrJ4yoGi5pbdgkAlpmdMNnSzGlesegZUGSqGsSVfR112nPcqlOBlaHNYvH3F3V1OfyUIVqfQ aGs/Z3jM1avx9CQmVtq/pimBFHXj1uO8rRmPCJp2l8SFnitAbbDWPUtBSPio6ti3fvC1J1jtw YRchb6i8eFGpU3PzeTHQIBWoaJWtsE3pcMAnvR9Ov+0P6f3NEKtNMgphOly2AQdIyrZIh0ovs 1bYGt7cy0kaO/j1OYRi5fUclr2dscLipanh9z4ImorznbVVOmGYieOCra9HQgsnYxC4a6T/lq gFN5S0vKpKkX70RnoF5tb5c3l8BfcgAFEnY1uXgLBIFBE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_102929_396739_B58637E6 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The number format of VCHIQ debugfs isn't always clear. So let's add a prefix for all hex values, in order to make things clear. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 51cfc366519b..4f65e4021c4d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3370,7 +3370,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, }; int i; - seq_printf(f, " %s: slots %d-%d tx_pos=%x recycle=%x\n", + seq_printf(f, " %s: slots %d-%d tx_pos=0x%x recycle=0x%x\n", label, shared->slot_first, shared->slot_last, shared->tx_pos, shared->slot_queue_recycle); @@ -3386,7 +3386,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, } for (i = 1; i < shared->debug[DEBUG_ENTRIES]; i++) { - seq_printf(f, " DEBUG: %s = %d(%x)\n", + seq_printf(f, " DEBUG: %s = %d(0x%x)\n", debug_names[i], shared->debug[i], shared->debug[i]); } } @@ -3414,7 +3414,7 @@ vchiq_dump_service_state(struct seq_file *f, struct vchiq_service *service) if (service->public_fourcc != VCHIQ_FOURCC_INVALID) scnprintf(remoteport + len2, sizeof(remoteport) - len2, - " (client %x)", service->client_id); + " (client 0x%x)", service->client_id); } else { strscpy(remoteport, "n/a", sizeof(remoteport)); } @@ -3475,7 +3475,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state) seq_printf(f, "State %d: %s\n", state->id, conn_state_names[state->conn_state]); - seq_printf(f, " tx_pos=%x(@%pK), rx_pos=%x(@%pK)\n", + seq_printf(f, " tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n", state->local->tx_pos, state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK), state->rx_pos,