From patchwork Tue Jun 4 17:28:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13685707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03FE4C27C53 for ; Tue, 4 Jun 2024 17:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TN+l3fy7Ujl161ff6cC+zAdr9+cTNM5Co/1PwUXap3g=; b=U0Cc8/+ddeHkvY u87mw7G6Rs6IpVvGWr48ZqP8yKMH4N154v2BnDFUqpZjgQQGOPlMj2Zauo41m7NY1Dl3rhBv5AvE5 AJyup+U4Ipc3S++eIt6paqjBB0LyBWyOXe11xiJTgNCTO7pcYdymdSjsD66Mg6r9de4XxD2X7UkvS SJZ0PLP3Avg6t5NTcm3To4BxH3dyknwOKu5bFORkrQvcicnRmpfKAxShK9W4ghBsCkUEH9DhBcQI3 Q7CQ75UDfgCDtRh0LCZDLdbyggM1D0DXMqMPf57URkCWctBP94peHJUsgHCtE2ngsHhgLhPKdql3c YoAAQStb30VhKPVIWrxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyU-00000003IhP-1Eze; Tue, 04 Jun 2024 17:29:30 +0000 Received: from mout.gmx.net ([212.227.17.21]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyR-00000003IeC-0fMp for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 17:29:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717522163; x=1718126963; i=wahrenst@gmx.net; bh=XbOIuODUCUQYgmxgmgv+5Smb6UaSNc/ht77NoSgfhL4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=hXkOXV4zp12O0pcnlYRUM+awtQ5Yv8x8tp4BQDy8rqSE8yUa874Y+PYt5NVblD9m vE1Cn9TadYBWPq7E1d+hZzUfG8bPYSn7MshA7gpnBVyIXAo5PFxaWR7j4b6gwX1wr usuc39oPYwtKW0Htdci09JCSVM6hkACGhA3S5SvnQlxQayraekQbX8tVGuTt+KWwa pv15Qp5sEf/RwKzvB76xlmi3Ejg9HTB9EeEzK+ULmoK1Nwt0b8Ei3TnFptSNE+h9q AFlyVUdN+5J2QomTpjl6j9GW5fpMhHbPBz1uTYMHwJu6ZmpKjyId1bH9KUsbaui3I R1fWDJS0tYjC8/m8yw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N9MpY-1sZYow3iUO-016ho1; Tue, 04 Jun 2024 19:29:22 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 01/11] staging: vchiq_arm: Replace variable ret with status Date: Tue, 4 Jun 2024 19:28:54 +0200 Message-Id: <20240604172904.61613-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604172904.61613-1-wahrenst@gmx.net> References: <20240604172904.61613-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:jz5E/93pwCXh4ZgHQMeQzcO2itT90CBjVQgT7cxpoqNDQjCrZeS TNft9OWaxrGU1TIeb6RKk0viqa5/YFtKJ4ox9xYCn4u04Vrah0TaXqQU9m4nxHf5BAdOTpY X69U78GyOQPIcj2uyKmXZRE4YZ4kWAGsfj3cJ5U2frQuFdcwRK57ljTWrPsjFSXDDU4O67+ sOsQzSJoa0OiV/AY+I7iQ== UI-OutboundReport: notjunk:1;M01:P0:epqMepvIfvo=;FOu7bRMMGhQRBbJ2erHC9lgxyZs 2OrYwVzSbB4JkxBsUBugpOVKoIHOIwq0GVMzi9rvYtVjCotGZzagqTPUd9t/HHgYXEWYI0Jn8 xdEj31sLZMweMVZl2Eq9fkWAyeSwHnziglVJIZQ5WAV+1d0oLhNjItJ8OLRXsGkK4Iz2oVWg3 If8m8J+wAlnFN7ZNhzOtlV3sL9ZIv/a5w9eF+Y5PRozm0A8fK0Q+bb3QjOqrCiw9VASjZ6FDb vrLH2YkWQP1riCI/SYH5fgPGlKTCUUlNYdrXxA/FY4QKZEmiIS15of8Vkocg9Q/WlrIAkodsy JcFNzuUMwpdC6sNHrkPlhvH3yCJZYjP6SXU0D//uzTmcaqapZjAGUPPmlDiNMxZ9DyIGN7grd Zb/cgYcSPpTamt0jFawccwU2kEm7XcfNVP1SG+fBmDfJTcYwtq9bqXJTtSfNEmqGuA8QnAx3k tx1ZGKj8rnHRk0j2IN0OJI4I9j4jtRxcKL17IN5PgSx032rBCEHO6l2fvScImB/ZEaB6Bwtjo 6b84PbfPZDJVXqx583B5/SiWP68y63Yc6vB30A5OYHgW9lQ9YjBdyx5i0Dcr6nSocq/gvPRU4 8YYC//bh3m/cTYU9X9PnpOLVj1WnQI+nrb32s7sao2hjxdu4XVhGINr3rE9GcmKwHpcY0c0AL sTxFr6eFtzn/OgEpmVi82qesmg3mWVhDpXCYhB9Te1SeRs+V55p6te5OIoWRO/IWsjXj/WrZj ic9IUJ8If//pD1o6uK0AhB4OMf4utEVmj+wm1weC23qS4tGru+zoaVdMGlME6nnGxHnmqy1nt btWEccPQujnharGKUggeTHVD7k+NvDNIWU6Np5EOpPPVc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_102927_672443_D25EC2E8 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The variable ret is just storing the result of last function call like the variable status. So replace ret with status and make a consistent use of this variable. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 69daeba974f2..e2f4aa00cb70 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1298,7 +1298,6 @@ vchiq_keepalive_thread_func(void *v) int status; struct vchiq_instance *instance; unsigned int ka_handle; - int ret; struct vchiq_service_params_kernel params = { .fourcc = VCHIQ_MAKE_FOURCC('K', 'E', 'E', 'P'), @@ -1307,9 +1306,10 @@ vchiq_keepalive_thread_func(void *v) .version_min = KEEPALIVE_VER_MIN }; - ret = vchiq_initialise(state, &instance); - if (ret) { - dev_err(state->dev, "suspend: %s: vchiq_initialise failed %d\n", __func__, ret); + status = vchiq_initialise(state, &instance); + if (status) { + dev_err(state->dev, "suspend: %s: vchiq_initialise failed %d\n", + __func__, status); goto exit; }