From patchwork Tue Jun 4 17:28:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13685708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C2D0C27C52 for ; Tue, 4 Jun 2024 17:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wk4fGbnShDrK/nsYCs8PHNlmJpk5Ou25dvodhWwQcAM=; b=HFQhWLwEpklOtp oDeJHI0SmifsambiPAtUQue/79sbk3/lvaWlpaS2p6+SWjSnXCUjmcB0r2lHohcIg7CuIJwC7QoTM Y9uoRPGZhCEP+7V3cl4sgmReUheElHS3hNetGCeC7/r67RStXO/wHGVHDyKzO59sFPwvLDsER6AXe YOApl58VQuRt7NDXN2lrkZ3cFgUOpROy3y1ltbUKJyZmgRRPwgqmPbVu6FBZaNqQvTva94n4teomB mvZhO/AGQogUZY6SF122quGDQe9eRgggB6nFvvEyP/n8luG9mZMPdlPCPTRNWUfk+661B+nIyXH1T 8x/0Gyi96q6zi4txbbDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyb-00000003Ikb-3SGj; Tue, 04 Jun 2024 17:29:38 +0000 Received: from mout.gmx.net ([212.227.17.22]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEXyS-00000003IeD-1UHn for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 17:29:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717522163; x=1718126963; i=wahrenst@gmx.net; bh=JtixJ+5R5VvbdeFN7ZhkNpcbzroFRKRp1CgRilsFn2M=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=lv2589fKjyH0+gDE0YdsdH9jygWKya1jkDQIzDMGAHPR1hf7oEGXrGClsyAV0Yla BBrvwRNOkpIBNuwbacocJ/6VQ8+nHIgqhQD26CdwwbiSaYGsEVydJsHniP9h3nPJH 33bWP7X447r1hqqjq6vjlJ3Za2FuyMq0L/HwIyRwWzNfSAudJQnIrubfit72iVfEN AurR/Pi8CiIDUilUhJGyQuArVWqUN8m8xeslmBGRgeYI1Mldv3nMZ1Ot6pav+D4Un 09tpQpMerW0BLb19yI/wRp/manhOQmAVO8zgxN9OjsHTWoNhwkNy2GbS4KrrWkMYN kuXb8Y22PA2h1FAPpg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N79u8-1sXLtn0rsK-014Usb; Tue, 04 Jun 2024 19:29:23 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 02/11] staging: vchiq_arm: Drop obsolete comment Date: Tue, 4 Jun 2024 19:28:55 +0200 Message-Id: <20240604172904.61613-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604172904.61613-1-wahrenst@gmx.net> References: <20240604172904.61613-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:UiTW8i4Vxx4YciNN+DR/pxONHQX84OJ0/p2PYv0tvzZ+nJDq+Jz 3llboV9XV4JYd8F2b1S+NIHbV1uT5U+jgzDT5RAkGOQ85YE9dXUyNuiTSEZwpBlKn1vc6Fc NhFvoqjzUPMKNKr6A6xH2pWgzJu/YwsMkJf+QbiJQK3sU7KjKTKrsrRgN+ivkgi60F7kcCH RFCklZijdwlZSlnta9BzA== UI-OutboundReport: notjunk:1;M01:P0:k99gOYlTekU=;fQVuznd4pmdhdpmP/ILtZCkQ1DR yJyMQp+7gbputmJmVbV8xTMGC6vSKfcjWUObDFo2lZoxeqTWyPfPjGB1azVT6UtR0gzMoTKVP bdZB+3XE8hpivLU4c776M3qzITGUKYUNqqfHY3K6+qX/uI7FVE6vQBoDVUiSNVs9RTUl0IhuO DIsL2dOV+ApMNAI6WOTeq55mHNgBDmYmraRiiWfLvVOWx2nh/d3DRdblU42fQdF3IbycmmV5/ RKXgnDQsFUf0CEb8YadoURsvdvVuqf3oxLS2yfQdEy1xfoiGQSqBxx8wVN6V2Y1Bo8OxVmmhr TaXTggnKL1toI2KZQQi5GZBt1915iYJaEAS1rejop/QFaNNW0HbosYOF5EYwl3fG/qV0Ko4qt CNSXjEjiICMg0yqVsmsLAddw810CAtODF93Qm77pyhep4r6uwjQZI3FQuDfv5KvrdPNupvdtc deefjXVdDFDMzui9Ov0yve5M6XFx+qUf8G3HS8C+S47OIY6abEPHmItzajRucQjxcybPHV3jg ccO1A/wQET5XZdNaLnmL+lrFdvwzaZfMQyFuQRPkKnqeqXXgk58wMdE9TMi9AlFZPrmp5su4G OkTj47q0PXwLaJOMK+L3yQt/nx7V14G0j18GpSruW+F32M0jSHpO0M1sbrqU1hzgKROvfkosS cMH8xjtXC8ilR2Ydbt0XUw+2hKikhLDyj7n6bfxyCwPLxwiXofbsWY6XNaCdeZDkU+G4FOlZY Z9rQfE05yDqLbMjVyX3qbPVl4JZ9eWLS05PHdOC4biMGNrVa4UYUl1ncQ8QXDjOK8H7diqJBP x5x9FC2jOthr0qWOhIYZUMMDRtgBdRRiJfvbu98XYGZzU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_102928_756076_6DF6164C X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The BUG_ON has been replaced with WARN_ON. So we can drop the comment. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index e2f4aa00cb70..515cdcba043d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1451,7 +1451,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) write_lock_bh(&arm_state->susp_res_lock); if (!arm_state->videocore_use_count || !(*entity_uc)) { - /* Don't use BUG_ON - don't allow user thread to crash kernel */ WARN_ON(!arm_state->videocore_use_count); WARN_ON(!(*entity_uc)); ret = -EINVAL;