| Message ID | 20240605210049.232284-3-knaerzche@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SFC support for RK3128 | expand |
On Wed, Jun 05, 2024 at 11:00:46PM +0200, Alex Bee wrote: > CLK_NR_CLKS should not be part of the binding. Let's drop it, since > the kernel code no longer uses it either. What about other operating systems etc, e.g. U-Boot or barebox?
Am 06.06.24 um 18:09 schrieb Conor Dooley: > On Wed, Jun 05, 2024 at 11:00:46PM +0200, Alex Bee wrote: >> CLK_NR_CLKS should not be part of the binding. Let's drop it, since >> the kernel code no longer uses it either. > What about other operating systems etc, e.g. U-Boot or barebox? For u-boot: RK3128 hasn't been switched to OF_UPSTREAM yet and it still uses it's own (dated) copy of the dt-bindings headers [0] and besides this macro isn't used there. Barebox doesn't support RK3128 at all and I'm generally not aware of any other bootloader/OS does which does and especially none which uses this macro. [0] https://github.com/u-boot/u-boot/blob/master/include/dt-bindings/clock/rk3128-cru.h
On Thu, Jun 06, 2024 at 07:26:06PM +0200, Alex Bee wrote: > > Am 06.06.24 um 18:09 schrieb Conor Dooley: > > On Wed, Jun 05, 2024 at 11:00:46PM +0200, Alex Bee wrote: > > > CLK_NR_CLKS should not be part of the binding. Let's drop it, since > > > the kernel code no longer uses it either. > > What about other operating systems etc, e.g. U-Boot or barebox? > For u-boot: RK3128 hasn't been switched to OF_UPSTREAM yet and it still > uses it's own (dated) copy of the dt-bindings headers [0] and besides this > macro isn't used there. Barebox doesn't support RK3128 at all and I'm > generally not aware of any other bootloader/OS does which does and > especially none which uses this macro. Okay, thanks for looking into it. Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/include/dt-bindings/clock/rk3128-cru.h b/include/dt-bindings/clock/rk3128-cru.h index 1be455ba4985..420984fc2285 100644 --- a/include/dt-bindings/clock/rk3128-cru.h +++ b/include/dt-bindings/clock/rk3128-cru.h @@ -145,7 +145,6 @@ #define HCLK_CRYPTO 476 #define HCLK_PERI 478 -#define CLK_NR_CLKS (HCLK_PERI + 1) /* soft-reset indices */ #define SRST_CORE0_PO 0
CLK_NR_CLKS should not be part of the binding. Let's drop it, since the kernel code no longer uses it either. Signed-off-by: Alex Bee <knaerzche@gmail.com> --- changes since v1: - new patch include/dt-bindings/clock/rk3128-cru.h | 1 - 1 file changed, 1 deletion(-)