From patchwork Mon Jun 10 21:02:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13692437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03189C27C65 for ; Mon, 10 Jun 2024 21:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BkDAX0Iyp45+4lwjOJDr4gQ0WnijnqYrNrmC7HD2Y7s=; b=iUjzuE4Z80RLze SFdRU6sy9BA18LI2Y7R/2D+I/BAuxMN+woGjjoWQmpkUdtz87L2SxWMWvaewGivYXYp56ZvMkbBxv GdkhfttLXRyMQB2R8vHORnbdTKlnxKEotIPYbGntPv6GhMWhM3FXnOPNBhV9HArz3VD/xf7uHaJMN OFaePrjpJBVEuQTqQRDB44HfIsU61vsBHs1HZwSva9jRT0Y/cbJWXosIA63JFlReUhyz2aIz07EW3 Dq0iT2oJJXY3uoQrdlNKac+7/ekLTWRXwfc4cQwjrRz8nVLmYmCpzuKDMslB6Sug2hSbbNIRYA7Ue 55ex4ugdG3p2auiuq4Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAS-00000006TzL-3e3l; Mon, 10 Jun 2024 21:03:04 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGmAB-00000006TmX-1o1z for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 21:02:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718053364; x=1718658164; i=wahrenst@gmx.net; bh=uX+rS5G3W7Xd5WyDA9MnftLeq1vdmexAme+rSO6wfwE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=CiMaZlggEI1ID+F1arwj5TyrGB7YeHeyhxkCW+/91fyAO3RjDsDl5b475vUTGhRQ AMFikK1yFDEIdJA7nfkuvmhYIPs2gfnLruetghxLVCkJ4NNqpkvh2JTFbsB9ahoUg zbvwv+hSb992LJ6N1r3uruFJ2/wA8aldd2tk1ixBMsSxCZwcx/L6N+cRVJte4Q20F 4CzhVbDFhzZFjciD/bZecbjTXt98OKCt7ybndP0oAOx47u/mJb/wDGzr51H+loZao pzEDgS5NNPdgmCXPRfURI6tCO8XPzdTeUQpk61O/yQr8QwwEZvbx+iD5F5LjsU5Cu AjmbOfoIVXbJzSIKxA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhU5R-1sthg703dL-00kfO1; Mon, 10 Jun 2024 23:02:44 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 08/10] staging: vchiq_core: Add hex prefix to debugfs output Date: Mon, 10 Jun 2024 23:02:18 +0200 Message-Id: <20240610210220.95524-9-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240610210220.95524-1-wahrenst@gmx.net> References: <20240610210220.95524-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:7B7vRjXXi/8U92n6c0z2aO25TjW1C9858voYxu2gVzM30RHzC20 Dzk8X3juqyZMCCyvVjdeea5kNbMQOiBfSWP+IAdoaL+Whd37siozPflMYO/W/JFE5rlI/nJ y1Qma2UKMRl03cFJqrtP1dOs7bOHgRNet8NECRwrTilnctdULjgukph39Glh6cw0uMLB9oF 4htsNVA0mdQ9xPuyNHCHw== UI-OutboundReport: notjunk:1;M01:P0:IfE+h6N/QFo=;5gG5hzUNDBciy4YaMOff3u73qzC 6W/TRDM4CIaqVCvlo3CgOS22lXenRAEstkqGzZr3rde7Y8sjS300XbNitSlblgadBjH3NnP2c aTluQzcQlXTjX1BpL3hDXzsxVPCZ4QF4DE7kDE5RgUxHZ4FEUc4QPpWDtpLFXbVkbqYGrSB/H REm91n6iqRx/+EPeYqDXnW7K2zWqIWVV71V3W7kYD7ZzQa3VnoSJMBDWFr94gv7+CzzbOp5Z5 GmDDdxyoOJaZs2+FkMLZW4fiUxNCLsu8/V6GQ4UB/oTUEmnJrtWym8An0LsgJd+g5DvCmLuIg MJ1ooDR3/1kwdJYTXMA3dhZAZlKxpbPV3e4xyW6zGYbHp2sX8nF9nSBt+2q48imwm6k88Cwvc V5aRECtzrwTQlAFQHW/wXGRP5apmMz+NrG9+jErO9958HyEJCY8YPlB1Sh9TethqR7iPHl0LE 53JqJKcjMSOqg5Llw3zv8LNUzRD6tS2vLTRdJXexYkcr2WtLMpOZHdosjVh06exMtORi2ezMb P057t+2N0tLARA8FbspjyvKlnA1RCHomoPpq1gP1iQQE5J39unH3YaFYhq+E7br4zga/mIe2r TtC7bxUtY4QVG8upNz3R7KxCKjKsNZbVc4zt72Pb6j/qj+JyEOCM8c9VxNQZ7Hj+EOuYlYTjV 0SGjF+kqc2o7hSQi5OcPKq9hrXnd6WIx5cYkWt7HQT3Fn4FqawGfbSkitsjHMLTahPbqEYWJo YOwtNvvhrQKRjcMtFZHwlDEq+8u/iMa8qLdCO/FgPX43UrDlC6ApKdmom+hRWJ+XD5rJAZc/h vqLXHu85w0/sftVdXROqMHfqQTovWqjJBawdOBndwxr5s= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_140248_313109_84D5B2C3 X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The number format of VCHIQ debugfs isn't always clear. So let's add a prefix for all hex values, in order to make things clear. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 51cfc366519b..4f65e4021c4d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3370,7 +3370,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, }; int i; - seq_printf(f, " %s: slots %d-%d tx_pos=%x recycle=%x\n", + seq_printf(f, " %s: slots %d-%d tx_pos=0x%x recycle=0x%x\n", label, shared->slot_first, shared->slot_last, shared->tx_pos, shared->slot_queue_recycle); @@ -3386,7 +3386,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state, } for (i = 1; i < shared->debug[DEBUG_ENTRIES]; i++) { - seq_printf(f, " DEBUG: %s = %d(%x)\n", + seq_printf(f, " DEBUG: %s = %d(0x%x)\n", debug_names[i], shared->debug[i], shared->debug[i]); } } @@ -3414,7 +3414,7 @@ vchiq_dump_service_state(struct seq_file *f, struct vchiq_service *service) if (service->public_fourcc != VCHIQ_FOURCC_INVALID) scnprintf(remoteport + len2, sizeof(remoteport) - len2, - " (client %x)", service->client_id); + " (client 0x%x)", service->client_id); } else { strscpy(remoteport, "n/a", sizeof(remoteport)); } @@ -3475,7 +3475,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state) seq_printf(f, "State %d: %s\n", state->id, conn_state_names[state->conn_state]); - seq_printf(f, " tx_pos=%x(@%pK), rx_pos=%x(@%pK)\n", + seq_printf(f, " tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n", state->local->tx_pos, state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK), state->rx_pos,