diff mbox series

[3/5] DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible

Message ID 20240612-ti-opp-updates-v1-3-3551c31d9872@ti.com (mailing list archive)
State New, archived
Headers show
Series Update OPP table and add entries for AM62Ax & AM62Px SoCs | expand

Commit Message

Bryan Brattlof June 12, 2024, 4:41 p.m. UTC
The JTAG_USER_ID_USERCODE efuse address, which is located inside the
WKUP_CTRL_MMR0 range holds information to identify the speed grades of
various components on TI's K3 SoCs. Add a compatible to allow the
cpufreq driver to obtain the data to limit the maximum frequency for the
CPUs under Linux control.

Signed-off-by: Bryan Brattlof <bb@ti.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley June 12, 2024, 4:51 p.m. UTC | #1
On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> various components on TI's K3 SoCs. Add a compatible to allow the
> cpufreq driver to obtain the data to limit the maximum frequency for the
> CPUs under Linux control.
> 
> Signed-off-by: Bryan Brattlof <bb@ti.com>

$subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible

Okay, if this isn't for merging then I won't Ack it.

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 7ed12a938baa3..ab1fcbe2148f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -88,6 +88,7 @@ properties:
>                - rockchip,rv1126-qos
>                - starfive,jh7100-sysmain
>                - ti,am62-usb-phy-ctrl
> +              - ti,am62-opp-efuse-table
>                - ti,am62p-cpsw-mac-efuse
>                - ti,am654-dss-oldi-io-ctrl
>                - ti,am654-serdes-ctrl
> 
> -- 
> 2.45.2
>
Bryan Brattlof June 12, 2024, 5:54 p.m. UTC | #2
On June 12, 2024 thus sayeth Conor Dooley:
> On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> > The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> > WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> > various components on TI's K3 SoCs. Add a compatible to allow the
> > cpufreq driver to obtain the data to limit the maximum frequency for the
> > CPUs under Linux control.
> > 
> > Signed-off-by: Bryan Brattlof <bb@ti.com>
> 
> $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
> 
> Okay, if this isn't for merging then I won't Ack it.

Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
few hours.

~Bryan
Lee Jones June 13, 2024, 12:09 p.m. UTC | #3
On Wed, 12 Jun 2024, Bryan Brattlof wrote:

> On June 12, 2024 thus sayeth Conor Dooley:
> > On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> > > The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> > > WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> > > various components on TI's K3 SoCs. Add a compatible to allow the
> > > cpufreq driver to obtain the data to limit the maximum frequency for the
> > > CPUs under Linux control.
> > > 
> > > Signed-off-by: Bryan Brattlof <bb@ti.com>
> > 
> > $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
> > 
> > Okay, if this isn't for merging then I won't Ack it.
> 
> Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
> few hours.

What's the point of all the DONOTMERGE nonsense?
Conor Dooley June 13, 2024, 12:20 p.m. UTC | #4
On Thu, Jun 13, 2024 at 01:09:23PM +0100, Lee Jones wrote:
> On Wed, 12 Jun 2024, Bryan Brattlof wrote:
> 
> > On June 12, 2024 thus sayeth Conor Dooley:
> > > On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> > > > The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> > > > WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> > > > various components on TI's K3 SoCs. Add a compatible to allow the
> > > > cpufreq driver to obtain the data to limit the maximum frequency for the
> > > > CPUs under Linux control.
> > > > 
> > > > Signed-off-by: Bryan Brattlof <bb@ti.com>
> > > 
> > > $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
> > > 
> > > Okay, if this isn't for merging then I won't Ack it.
> > 
> > Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
> > few hours.
> 
> What's the point of all the DONOTMERGE nonsense?

AFAICT, TI live in fear of subsystem maintainers merging the dts patches,
so they do this.
Krzysztof Kozlowski June 13, 2024, 1:13 p.m. UTC | #5
On 13/06/2024 14:20, Conor Dooley wrote:
> On Thu, Jun 13, 2024 at 01:09:23PM +0100, Lee Jones wrote:
>> On Wed, 12 Jun 2024, Bryan Brattlof wrote:
>>
>>> On June 12, 2024 thus sayeth Conor Dooley:
>>>> On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
>>>>> The JTAG_USER_ID_USERCODE efuse address, which is located inside the
>>>>> WKUP_CTRL_MMR0 range holds information to identify the speed grades of
>>>>> various components on TI's K3 SoCs. Add a compatible to allow the
>>>>> cpufreq driver to obtain the data to limit the maximum frequency for the
>>>>> CPUs under Linux control.
>>>>>
>>>>> Signed-off-by: Bryan Brattlof <bb@ti.com>
>>>>
>>>> $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
>>>>
>>>> Okay, if this isn't for merging then I won't Ack it.
>>>
>>> Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
>>> few hours.
>>
>> What's the point of all the DONOTMERGE nonsense?
> 
> AFAICT, TI live in fear of subsystem maintainers merging the dts patches,
> so they do this.

And want some strict timeframe of merging bindings (via subsystem) and
DTS (via SoC tree), which causes all weird submissions like this above
or sending bindings without users.

So far I can live with it but if more such peculiarities come up, then
sorry, fix your process/tools instead of putting burden on maintainers
and community.

Best regards,
Krzysztof
Lee Jones June 13, 2024, 5:30 p.m. UTC | #6
On Thu, 13 Jun 2024, Krzysztof Kozlowski wrote:

> On 13/06/2024 14:20, Conor Dooley wrote:
> > On Thu, Jun 13, 2024 at 01:09:23PM +0100, Lee Jones wrote:
> >> On Wed, 12 Jun 2024, Bryan Brattlof wrote:
> >>
> >>> On June 12, 2024 thus sayeth Conor Dooley:
> >>>> On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> >>>>> The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> >>>>> WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> >>>>> various components on TI's K3 SoCs. Add a compatible to allow the
> >>>>> cpufreq driver to obtain the data to limit the maximum frequency for the
> >>>>> CPUs under Linux control.
> >>>>>
> >>>>> Signed-off-by: Bryan Brattlof <bb@ti.com>
> >>>>
> >>>> $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
> >>>>
> >>>> Okay, if this isn't for merging then I won't Ack it.
> >>>
> >>> Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
> >>> few hours.
> >>
> >> What's the point of all the DONOTMERGE nonsense?
> > 
> > AFAICT, TI live in fear of subsystem maintainers merging the dts patches,
> > so they do this.
> 
> And want some strict timeframe of merging bindings (via subsystem) and
> DTS (via SoC tree), which causes all weird submissions like this above
> or sending bindings without users.
> 
> So far I can live with it but if more such peculiarities come up, then
> sorry, fix your process/tools instead of putting burden on maintainers
> and community.

FWIW, if I see DONOTMERGE in the subject line, I tend to skip over them.
Bryan Brattlof June 15, 2024, 2:43 p.m. UTC | #7
On June 13, 2024 thus sayeth Krzysztof Kozlowski:
> On 13/06/2024 14:20, Conor Dooley wrote:
> > On Thu, Jun 13, 2024 at 01:09:23PM +0100, Lee Jones wrote:
> >> On Wed, 12 Jun 2024, Bryan Brattlof wrote:
> >>
> >>> On June 12, 2024 thus sayeth Conor Dooley:
> >>>> On Wed, Jun 12, 2024 at 11:41:52AM -0500, Bryan Brattlof wrote:
> >>>>> The JTAG_USER_ID_USERCODE efuse address, which is located inside the
> >>>>> WKUP_CTRL_MMR0 range holds information to identify the speed grades of
> >>>>> various components on TI's K3 SoCs. Add a compatible to allow the
> >>>>> cpufreq driver to obtain the data to limit the maximum frequency for the
> >>>>> CPUs under Linux control.
> >>>>>
> >>>>> Signed-off-by: Bryan Brattlof <bb@ti.com>
> >>>>
> >>>> $subject: DONOTMERGE: dt-bindings: mfd: syscon: add TI's opp table compatible
> >>>>
> >>>> Okay, if this isn't for merging then I won't Ack it.
> >>>
> >>> Ha! Nice. If I don't hear anything from anyone else I'll send a v2 in a 
> >>> few hours.
> >>
> >> What's the point of all the DONOTMERGE nonsense?
> > 
> > AFAICT, TI live in fear of subsystem maintainers merging the dts patches,
> > so they do this.
> 
> And want some strict timeframe of merging bindings (via subsystem) and
> DTS (via SoC tree), which causes all weird submissions like this above
> or sending bindings without users.
> 
> So far I can live with it but if more such peculiarities come up, then
> sorry, fix your process/tools instead of putting burden on maintainers
> and community.
> 

Yeah my worry was all the DTB additions filter in would require a lot of 
coordination between the maintainers of all the different trees.

Having a few DONOTMERGE patches gave the driver maintainer a full look 
at the outcome of the series without having to worry about DTB conflicts 
when another tree picked something up, however I guess if everyone 
participates in -next it shouldn't be that big of a problem. 

~Bryan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 7ed12a938baa3..ab1fcbe2148f7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -88,6 +88,7 @@  properties:
               - rockchip,rv1126-qos
               - starfive,jh7100-sysmain
               - ti,am62-usb-phy-ctrl
+              - ti,am62-opp-efuse-table
               - ti,am62p-cpsw-mac-efuse
               - ti,am654-dss-oldi-io-ctrl
               - ti,am654-serdes-ctrl