diff mbox series

[v5,1/8] dt-bindings: counter: Add new ti,am62-eqep compatible

Message ID 20240612135538.2447938-2-jm@ti.com (mailing list archive)
State New, archived
Headers show
Series Enable eQEP DT support for Sitara K3 platforms | expand

Commit Message

Judith Mendez June 12, 2024, 1:55 p.m. UTC 
Add new compatible ti,am62-eqep for TI K3 devices. If a device
uses this compatible, require power-domains property.

Since there is only one functional and interface clock for eqep,
clock-names is not really required, so removed from required
section, make it optional for ti,am3352-eqep compatible, and
update the example.

The clock-name also changed for TI K3 SoCs so do not allow
clock-names property for the new compatible.

Signed-off-by: Judith Mendez <jm@ti.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: David Lechner <david@lechnology.com>
---
Changes since v4:
- Drop the new example from binding
---
 .../devicetree/bindings/counter/ti-eqep.yaml  | 27 +++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

Comments

William Breathitt Gray June 26, 2024, 10:42 p.m. UTC | #1 
On Wed, Jun 12, 2024 at 08:55:31AM -0500, Judith Mendez wrote:
> Add new compatible ti,am62-eqep for TI K3 devices. If a device
> uses this compatible, require power-domains property.
> 
> Since there is only one functional and interface clock for eqep,
> clock-names is not really required, so removed from required
> section, make it optional for ti,am3352-eqep compatible, and
> update the example.
> 
> The clock-name also changed for TI K3 SoCs so do not allow
> clock-names property for the new compatible.
> 
> Signed-off-by: Judith Mendez <jm@ti.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: David Lechner <david@lechnology.com>
> ---
> Changes since v4:
> - Drop the new example from binding
> ---

Hi Krzysztof,

Are you satisfied with the changes made for this version of the patch?

Thanks,

William Breathitt Gray
Krzysztof Kozlowski June 27, 2024, 7:31 a.m. UTC | #2 
On 27/06/2024 00:42, William Breathitt Gray wrote:
> On Wed, Jun 12, 2024 at 08:55:31AM -0500, Judith Mendez wrote:
>> Add new compatible ti,am62-eqep for TI K3 devices. If a device
>> uses this compatible, require power-domains property.
>>
>> Since there is only one functional and interface clock for eqep,
>> clock-names is not really required, so removed from required
>> section, make it optional for ti,am3352-eqep compatible, and
>> update the example.
>>
>> The clock-name also changed for TI K3 SoCs so do not allow
>> clock-names property for the new compatible.
>>
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> Reviewed-by: David Lechner <david@lechnology.com>
>> ---
>> Changes since v4:
>> - Drop the new example from binding
>> ---
> 
> Hi Krzysztof,
> 
> Are you satisfied with the changes made for this version of the patch?

I did not check, because it already has an Ack from Conor. I am usually
not double-acking, but FWIW:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
index 85f1ff83afe72..c882ab5fcf1f2 100644
--- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
+++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
@@ -11,7 +11,9 @@  maintainers:
 
 properties:
   compatible:
-    const: ti,am3352-eqep
+    enum:
+      - ti,am3352-eqep
+      - ti,am62-eqep
 
   reg:
     maxItems: 1
@@ -21,19 +23,35 @@  properties:
     maxItems: 1
 
   clocks:
-    description: The clock that determines the SYSCLKOUT rate for the eQEP
-      peripheral.
+    description: The functional and interface clock that determines the clock
+      rate for the eQEP peripheral.
     maxItems: 1
 
   clock-names:
     const: sysclkout
 
+  power-domains:
+    maxItems: 1
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - ti,am62-eqep
+    then:
+      properties:
+        clock-names: false
+
+      required:
+        - power-domains
+
 required:
   - compatible
   - reg
   - interrupts
   - clocks
-  - clock-names
 
 additionalProperties: false
 
@@ -43,7 +61,6 @@  examples:
         compatible = "ti,am3352-eqep";
         reg = <0x180 0x80>;
         clocks = <&l4ls_gclk>;
-        clock-names = "sysclkout";
         interrupts = <79>;
     };