| Message ID | 20240616-dt-bindings-mfd-syscon-split-v2-3-571b5850174a@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description | expand |
On Sun, Jun 16, 2024 at 03:19:23PM +0200, Krzysztof Kozlowski wrote: > intel,lgm-syscon is not a simple syscon device - it has children - thus > it should be fully documented in its own binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
On Sun, Jun 16, 2024 at 03:19:23PM +0200, Krzysztof Kozlowski wrote: > intel,lgm-syscon is not a simple syscon device - it has children - thus > it should be fully documented in its own binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Context might depend on patch in Lee's MFD tree: > https://lore.kernel.org/all/171828959006.2643902.8308227314531523435.b4-ty@kernel.org/ > and also further patches here depend on this one. > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - > .../bindings/soc/intel/intel,lgm-syscon.yaml | 56 ++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index af442767aa96..b9bf5bc05e92 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -77,7 +77,6 @@ properties: > - hisilicon,pcie-sas-subctrl > - hisilicon,peri-subctrl > - hpe,gxp-sysreg > - - intel,lgm-syscon > - loongson,ls1b-syscon > - loongson,ls1c-syscon > - lsi,axxia-syscon > diff --git a/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml > new file mode 100644 > index 000000000000..0a73b7616a60 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/intel/intel,lgm-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel Lightning Mountain(LGM) Syscon > + > +maintainers: > + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> This email is bouncing FYI.
On 17/06/2024 18:47, Conor Dooley wrote: >> +--- >> +$id: http://devicetree.org/schemas/soc/intel/intel,lgm-syscon.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Intel Lightning Mountain(LGM) Syscon >> + >> +maintainers: >> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > This email is bouncing FYI. Eh, indeed. I'll figure out something, but in general platform looks abandoned. Best regards, Krzysztof
On Sun, 16 Jun 2024 15:19:23 +0200, Krzysztof Kozlowski wrote: > intel,lgm-syscon is not a simple syscon device - it has children - thus > it should be fully documented in its own binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Context might depend on patch in Lee's MFD tree: > https://lore.kernel.org/all/171828959006.2643902.8308227314531523435.b4-ty@kernel.org/ > and also further patches here depend on this one. > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - > .../bindings/soc/intel/intel,lgm-syscon.yaml | 56 ++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index af442767aa96..b9bf5bc05e92 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -77,7 +77,6 @@ properties: - hisilicon,pcie-sas-subctrl - hisilicon,peri-subctrl - hpe,gxp-sysreg - - intel,lgm-syscon - loongson,ls1b-syscon - loongson,ls1c-syscon - lsi,axxia-syscon diff --git a/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml new file mode 100644 index 000000000000..0a73b7616a60 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/intel/intel,lgm-syscon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Intel Lightning Mountain(LGM) Syscon + +maintainers: + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> + +properties: + compatible: + items: + - const: intel,lgm-syscon + - const: syscon + + reg: + maxItems: 1 + + ranges: true + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + +patternProperties: + "^emmc-phy@[0-9a-f]+$": + $ref: /schemas/phy/intel,lgm-emmc-phy.yaml# + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + chiptop@e0200000 { + compatible = "intel,lgm-syscon", "syscon"; + reg = <0xe0200000 0x100>; + ranges = <0x0 0xe0200000 0x100>; + #address-cells = <1>; + #size-cells = <1>; + + emmc-phy@a8 { + compatible = "intel,lgm-emmc-phy"; + reg = <0x00a8 0x10>; + clocks = <&emmc>; + #phy-cells = <0>; + }; + };
intel,lgm-syscon is not a simple syscon device - it has children - thus it should be fully documented in its own binding. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Context might depend on patch in Lee's MFD tree: https://lore.kernel.org/all/171828959006.2643902.8308227314531523435.b4-ty@kernel.org/ and also further patches here depend on this one. --- Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - .../bindings/soc/intel/intel,lgm-syscon.yaml | 56 ++++++++++++++++++++++ 2 files changed, 56 insertions(+), 1 deletion(-)