From patchwork Mon Jun 17 13:49:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50C3DC41513 for ; Mon, 17 Jun 2024 13:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DyBlb3Ba1k/jlth0MsPpVigCEg60zHZmfggBIvSR+YQ=; b=RvFc8rblyzj/ZErFznXzclPxuJ VZlSsDN0HLZtFckup3OAKPyVpwRK+2wBWmV708qWmvMRevNXtm5dbOHqALhS+j99zl1mjMXFWBWV4 34NHihfLfMQH4Ows+G2nmsGwj3b2SYnCcQu5OGkIQRtg6WueBMeH1Jc07HKFZROP1W1fSnbl9+AeR 3bQASPbKGmNVz4L5/Ktq+cQro/cJcNmXvjZP7ke/sqRNl+a0SIyka+TmWJhYLscLjC9rH+KcdUFPk dWuEnjI8yKpQKDuCqRzaO+dl2z3IhkmJBwNogmo31fzFrw6QSdhIWoay1K4sSzHlL0YZX3a0vjAb/ ElcXNWdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCmg-0000000Ayk8-29TP; Mon, 17 Jun 2024 13:52:34 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkN-0000000Awyj-3mZL for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:50:17 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7955841fddaso361885985a.1 for ; Mon, 17 Jun 2024 06:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632210; x=1719237010; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DyBlb3Ba1k/jlth0MsPpVigCEg60zHZmfggBIvSR+YQ=; b=SIB/YZ5EL9WTjFOX0NhJG1I8ywfsqImD9AwpVfHikf3PXxGQBNnCjxEdI1oyLXs5iy nTiceQriXx2wCw1UCw8BBTjXtKqcRPbNBTE3Pw2FXwJHsDxWP/bEZavE/YIVCGICnFGO m26qua77bB9MUZb3AUELEsVxEDWpTbDFkaM/vjiuh73JXBLIrH3laepYcxPu21kbjEY+ 65Num2UO9DFmQQJwgchmJWXsSVFNgBdzuYsM35B1C2dkBMP+y5VvOtPbPKiEa+my5Wdv YyQq68y+ooDICwtDTG++v1Dok5kqNyVoBqBEmRPl6jhCvPjogZCEHu0sIdXRGeA3mvdt FhXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632210; x=1719237010; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DyBlb3Ba1k/jlth0MsPpVigCEg60zHZmfggBIvSR+YQ=; b=qxttuZ68bJ+mq6yyTMI+DMvEitv+ECcSpV0jDx6m9T0LQpDQz2Lx0msXMHxpR/7AKD NFukLOhUwAZu8D2GarqEPK1n7tboko6QjUJ1LOsNOsr0NDnhO5tpazhmZ8BI3Lek+w33 xXEfYaFo6OpYL/uvRvpuMy3UTCEjiTpJijlBk8pmW7cZYY53Kebap20jxUPLHxWD8sPe 11ekWOPKbO/gSRfU/qVYTf17ZwetZqdU2AWvi66C67LkCXkQRtf7MkljMNcghUMxlvTK jfyI52aau+SE9bBw1qDJc6Argdih3rEOQaAjAxPxwA11mT2fMvrm6swJH/HxRLlDAyz+ dCnw== X-Forwarded-Encrypted: i=1; AJvYcCVqSPUVusRk7JYbPN5R9xoRsBCcYgGWNliIHFQ7uJUlm32crWs5h0/pO4pjahiB5n4gSeBm4qPoXlO7ZTpPS44/QrRy04YcpflK4yYFrpTxT4d+XX0= X-Gm-Message-State: AOJu0Yxj5Nz5SdLVoXzlKHlYcRwXHNRa9DwE5mtl8TBo83JVuLhR5p9z yVfaS6KIjsv4GGmODWzfuPRChPM7WOws8jrlON2g24gwxBCLpfmyd0B+pqC5Mn8= X-Google-Smtp-Source: AGHT+IHWmg+UOH3erM5jeRd6l80OV3UNPvKSawdtaAa099apOKn54lBrRboJnTNNmboBsmxvynve5Q== X-Received: by 2002:a05:620a:408a:b0:799:b171:b1fe with SMTP id af79cd13be357-799b171b5f4mr1409403885a.14.1718632210646; Mon, 17 Jun 2024 06:50:10 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:10 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:49:52 -0400 Subject: [PATCH v3 12/41] iio: adc: intel_mrfld_adc: make use of regmap_clear_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-12-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065012_430063_502DA8B3 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/adc/intel_mrfld_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/intel_mrfld_adc.c b/drivers/iio/adc/intel_mrfld_adc.c index c7f40ae6e608..0590a126f321 100644 --- a/drivers/iio/adc/intel_mrfld_adc.c +++ b/drivers/iio/adc/intel_mrfld_adc.c @@ -81,8 +81,8 @@ static int mrfld_adc_single_conv(struct iio_dev *indio_dev, reinit_completion(&adc->completion); - regmap_update_bits(regmap, BCOVE_MADCIRQ, BCOVE_ADCIRQ_ALL, 0); - regmap_update_bits(regmap, BCOVE_MIRQLVL1, BCOVE_LVL1_ADC, 0); + regmap_clear_bits(regmap, BCOVE_MADCIRQ, BCOVE_ADCIRQ_ALL); + regmap_clear_bits(regmap, BCOVE_MIRQLVL1, BCOVE_LVL1_ADC); ret = regmap_read_poll_timeout(regmap, BCOVE_GPADCREQ, req, !(req & BCOVE_GPADCREQ_BUSY),