From patchwork Mon Jun 17 13:49:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700797 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89246C27C79 for ; Mon, 17 Jun 2024 13:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Zs4CGtswXRcL4r5zLR2D5+LAoG+l8N82wbiM+7ownU=; b=FSj/osHxnXVCSm+VRR3kekpca2 CR/4rnUbhk1MKnmTFnqvp2LAd9GMnqpFrMccTFxKOsv5OPpcJD1/YeqJ7k6OxleHTugZTt049fvpl qv3psJNkG4RK0//A2++97kQt1L1LiKvEwFLk4HMIHN+fjqLhM2rkb6/2VNJwtoQsfQvMW2dU2l7W/ j1pau3gVXuyOPDGLHx29HeH3ACm3syCjRvI8fzPts3EzeNyDba0gMjZW1V2Ub+B0iZkIIxPQHUx2r wZaiBvu4LIGEz2Wlw1IL7M1m9tMxZRh57cDyfM6Uf7uGZTDSXwhTdsyxk8b7/jZFauvKGKHG9vt5n QpPpWkUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkH-0000000Awsp-20K8; Mon, 17 Jun 2024 13:50:05 +0000 Received: from mail-ua1-x92c.google.com ([2607:f8b0:4864:20::92c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCk3-0000000Awhx-4BZI for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:49:53 +0000 Received: by mail-ua1-x92c.google.com with SMTP id a1e0cc1a2514c-80d6534e302so1379891241.0 for ; Mon, 17 Jun 2024 06:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632189; x=1719236989; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8Zs4CGtswXRcL4r5zLR2D5+LAoG+l8N82wbiM+7ownU=; b=qY0q55DHIUhO0iGnnmUPAmyPbfIpDj4DS+8DQ2Jbut6PZGk1gtIIMWVLfZ3IcMS2DT QjSbCEHiEFdLoNQiMbB3uDeShDPidD/7/yAJ9QlWwGKA/Gn8iCarX1Qf1+XThsZjwLbD 1emZA3G9UmvTzne+PmhjcdgV4mhpN7yAq016mu2YoePRMd7fSdGh3aLTfdHefFp91J0S KZQgrH5Bf+mSbVt2UGKKtSKGZWiHJdghncDUdGTo6MRQXFioENdZJBcSkiJjTHEK7BfN TbqWlSfHMaexCnrKz/dghX2z5FbgmhAmhgVxb+lDr9HdP/F7V4M5Z2s7GcPhsVDnSlk7 cDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632189; x=1719236989; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Zs4CGtswXRcL4r5zLR2D5+LAoG+l8N82wbiM+7ownU=; b=FFwf1rFKFulsnClZTX4n/v8q5H4vrsmUtOWlsEpB3ECti7pr702nfcEPEtNX/nvqSG 1RCrmkCcJPCWQ7fuyBDItwVj/bONJ+lknyRRKit/udi+qaGFSnKigAF34YN4GBVZxWWS 8rnrW00Ll+kpR54YYndFbEIamgjFLLPxsI1Wqeonr9TbfCTmNGc2e70E/gvk+BfbXGST Zmciz0eJPwYKZzJIxVZ3ibmSJkuCBg4y46HX9+zLLmKMK69NaHGiC9iVmWufMQoEdE0T L6+X7cwo/kL7w4neGq17FStQILIXOCVtm43Cu75FlkOjVrc1e92yzFGrylcL7aKmxjCX sbLg== X-Forwarded-Encrypted: i=1; AJvYcCX4d3t0TZxk5lGKV9J2w8sFQSmrwWpZRfgfkGsz9Aq89kkorkeC6ah1Kg1ccczTsk9FnVwQ14d2UiNicxUv4CzS3v2SoT3ejUOo7PQa9fHeIEQ92Eg= X-Gm-Message-State: AOJu0YxTSawVDvMCUgGMGOxi1viyqvFPbdl7tTnobCNr302W4JSql5eQ XRBr7XPNLFvl5X2DKloat2ZyFg3pVcTpiUJhBT1wSYHXIyRtI5ZLj1IeEmCW5K0= X-Google-Smtp-Source: AGHT+IEFmgHtaGyOVxmPD/zpG+S8mAUnggR0FqGzztaCLAyq4bVNR5GtCNAnJm1CQv7c1xou1ffjIg== X-Received: by 2002:a67:b902:0:b0:48d:7702:99e2 with SMTP id ada2fe7eead31-48dae3e00c7mr8793212137.31.1718632188950; Mon, 17 Jun 2024 06:49:48 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:49:48 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:49:42 -0400 Subject: [PATCH v3 02/41] iio: accel: kxsd9: Make use of regmap_clear_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-2-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_064952_242003_3317AF96 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin Reviewed-by: Linus Walleij --- drivers/iio/accel/kxsd9.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c index ba99649fe195..03ce032e06ff 100644 --- a/drivers/iio/accel/kxsd9.c +++ b/drivers/iio/accel/kxsd9.c @@ -370,10 +370,8 @@ static int kxsd9_power_down(struct kxsd9_state *st) * make sure we conserve power even if there are others users on the * regulators. */ - ret = regmap_update_bits(st->map, - KXSD9_REG_CTRL_B, - KXSD9_CTRL_B_ENABLE, - 0); + ret = regmap_clear_bits(st->map, KXSD9_REG_CTRL_B, + KXSD9_CTRL_B_ENABLE); if (ret) return ret;