From patchwork Mon Jun 17 13:50:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0306C2BA15 for ; Mon, 17 Jun 2024 13:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DerxFnnoYXb7MP4GOUVN2xlgxjAao77OyLSOrDCydO0=; b=C3Kk+S5vIHe3dyKe2d9vhNMceR Yc+OUlsjFzqRAIRcCxNnC6DjamdjoeNJXreezys7sbVdXW+vwRNJoniTXRk97qof41/RzyKoLBkkg IXOvHT/YgWhH/gcpmJ9JNgdE6m6cyJMLis0ZVsCehnjMS9VFZVLlMIkQ7jF2ykcLUGxOaAwr+PbJs /FMqyyUv3wDuAp2JXnF28Oh89XmSt47HjMB+QJa8z3ETfI9qK57KiqIO42wEvHoben8tSbtPKoKd+ spxvftQkEp2ZKBTWCSnXnQsFEvhigRpHV82TiXu6cny2QswXeRhYIltCDWtEiN+CBVYz7mjK+GW2z Z9qwMMjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCmd-0000000Ayi0-0BF1; Mon, 17 Jun 2024 13:52:31 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkh-0000000AxHl-0nmJ for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:50:41 +0000 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-7953f1dcb01so389062785a.3 for ; Mon, 17 Jun 2024 06:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632230; x=1719237030; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DerxFnnoYXb7MP4GOUVN2xlgxjAao77OyLSOrDCydO0=; b=WQGmHoQ0VS2USINi7Db71fhi0FwycK1OXvADlvH7nTeTN4iyVVjc7/0lt9SRfx+5LT foNYHsuEDzO6fH/K3Auxbr0qUrFCfjWGJMmqhV6oNtsAF/SQBlSH+KJ2oCTzNetHFz2X Lqu622pNUhcjGnJf2lbRiQ/2rMsLoMgw84N1n5438eozidEnRanfdDRp0DQ9GlcERMcN JBProYA0f6IBMl7QhgCTfX83hdsF1M6Tr5gb7psdlkmU9N1Znl48MtwLgNZUcCKoXwhu 3nyLErGLifk2vxudySutCeiJA0hQf8qiEsVKT7ghXJspSZi9ZqypJFqC2ZkLxRVkEi6p 9INg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632230; x=1719237030; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DerxFnnoYXb7MP4GOUVN2xlgxjAao77OyLSOrDCydO0=; b=CC4Yxu21WnqM6cVSysY4C4RYY5n3JBDRcEwkHod96diIZ5CIzUXV4ZOP/gZtkhS3GW kdDoiUsBwli+QRsK8V4XTbxpFW4TOvWJlF/kCDmWi7h3T4gUqwry5YRX+3J58a2nFjHa ieywlBZajkN06dgSORfe9QkMruPZNqNdUiMeMGgjF8H0cYyKkPO9sroBMs7hUb5Tolgy CZ5MGO6JXgE+UkqH3glv1whplhL0GFfZAy3sZQtigqj6m6ODg6VRPZ0/Y5MjyPMkod4L OFrnPFf8cwVnwYeQAPuhN8E1BofD0KHy3PP+vel1fxTozDEdV3OA3Z30sNRGAon+a+kU 7Rjg== X-Forwarded-Encrypted: i=1; AJvYcCV3xN/+RbFYAwOgOYYrgqC+TYVkRPKmOF8FY38lAp7yMych6QMEuC/ktG9bWcsOBRy7JwRMoYOoCENp6PesCinur3ahNGm98mCXA5B6JQv7GEzrdag= X-Gm-Message-State: AOJu0YyAjdQ5TxKi7Qy3SLoKvOFcUUg82S5f60fyHm1lixU1sE4mP9bW nxbZPEnYIJjpGW5cO8NibPKBSVF7SWDcujCO9qSfICES84k3fc5hU1UMVmUZUTw= X-Google-Smtp-Source: AGHT+IHxtzkdFJwlDchh8tO2N+M/GUfc/zgUMeSNzO08CBN63HSCP+uPJVwg8RWxzdMRcwiKU/TPZA== X-Received: by 2002:a05:620a:2443:b0:795:4e2c:eabf with SMTP id af79cd13be357-798d240dcf1mr1259752585a.26.1718632229931; Mon, 17 Jun 2024 06:50:29 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:29 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:01 -0400 Subject: [PATCH v3 21/41] iio: gyro: bmg160_core: make use of regmap_clear_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-21-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065032_199294_8A5A05B7 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/gyro/bmg160_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c index 0e2eb0e98235..10728d5ccae3 100644 --- a/drivers/iio/gyro/bmg160_core.c +++ b/drivers/iio/gyro/bmg160_core.c @@ -285,8 +285,8 @@ static int bmg160_chip_init(struct bmg160_data *data) data->slope_thres = val; /* Set default interrupt mode */ - ret = regmap_update_bits(data->regmap, BMG160_REG_INT_EN_1, - BMG160_INT1_BIT_OD, 0); + ret = regmap_clear_bits(data->regmap, BMG160_REG_INT_EN_1, + BMG160_INT1_BIT_OD); if (ret < 0) { dev_err(dev, "Error updating bits in reg_int_en_1\n"); return ret;