From patchwork Mon Jun 17 13:50:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF033C27C79 for ; Mon, 17 Jun 2024 13:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fGWBtK2gGzg6dOcIkV68NwvgEBcr/hA30WsTyKyEtwo=; b=hpZL39QOKgOafjfV0xy71tnsdK O1SW/DffNIdqBsLYvAzZgBDe4XtESP+6y+2V3ZHQSIAedFp2JOBqhPzHK7noh+u5fKtVTyjw5uGS/ 3LhrJ7JSqw8NCwjoLe/vGWgl88lNPd9QeD9u2k8rDcVX6ZKKAH1AKYEch0i49GFQOeYlW54WAk9dR OVbOeUnoTlLL7NCyHuN3/T+j3Hijp0aQGqiCiDCBy9K4vbyr/AkZ+1aZQKP8eC02q0PHh8hUhBO+S f/HMZrp6Ang3bLOfwuEp3+35hyhVd/P6xbeAK42cGyg7ZnULT8S2b3cinsUS2CEdsNcpmPkUPqjVo 23xVFibQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCn2-0000000Az2i-1jg7; Mon, 17 Jun 2024 13:52:56 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkn-0000000AxMv-26J1 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:50:44 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3d24a231342so1952105b6e.1 for ; Mon, 17 Jun 2024 06:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632236; x=1719237036; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fGWBtK2gGzg6dOcIkV68NwvgEBcr/hA30WsTyKyEtwo=; b=agdx/ZVnEa91hR8XzFNY+x3QAA+PPy8FUm9bUqm8SAqrbQQWT3DXrwoaDyc2r1TuUk I8+ZT2KAljjJsYtUPBA5MJBHfLzyMCQTlqDdtibKfAzc3F7U64fvb5/OHeFeb5XWJfrk POZf75oRfD+j+C4po3YED2LZSjYzDna6EV94XfZrplSUTnyT/Y8ybwjPKNRTR/I/qOSC wIPiuL6abanTTP0SUVZwdyNVJjK7QTzbSuuxD6Wnis7XTPyiJMwoXyFDd5/qCEwi3KW3 YJwdaWMIxUmOSdWHcy0rUQgSJwZ5ian3ucvBzziyUps6B3oC1EUlaAYh+w/6cYMO7paP h1tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632236; x=1719237036; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fGWBtK2gGzg6dOcIkV68NwvgEBcr/hA30WsTyKyEtwo=; b=Tc9I4U/4aS4638rALNsSkox//QtOJOKT0vnbRSlf7pC9mBbJ+FTbxNf5h0dZh9929J p9Ee6fNO8ChkJgmg0ymJh+p0ucjgvNQ3iFzbHlnkhrtZsU2XmM2/1eUWRIp3xYNbYSBI pT4oBXOVhEs5n0700aKwLvDj9gouhgzVkuO7YohbW5OEyoXGbDgBVjLGUG4HWHrf3fIn soeo3e5BiAGFhR7EF7Q3FzBtVhi5O48PhV1WpWcq92FUDxeR8h/K3AfzUF4kZ/y8yHD6 Zx+5JZR7+fA0g+3ScYrACUujnfcrdRXCc5GukQ/+kO3Zyazo0aD0y3AZvHnLOPWxA0KO 5W8A== X-Forwarded-Encrypted: i=1; AJvYcCVFhqewyG0TXUwkfM/1uLZ35GmjmLWSftyWInql/EJYs+Na6A8bX+rjPX/SA7gIQ4/YBhySBnS7SfRoF0UX5QPVRHGE30An0lTa5447vp3oPhqEeP0= X-Gm-Message-State: AOJu0YxYpc+XFqY0AQx6y99mfvFRNFPbt16ZI1rxSSoONiJa13DrHnAp UwLsaqGsHa8AKRwVnnQYd2bDIdOIccbuf5ThZjAISfhVAhckvJDwH0/l47tbFmw= X-Google-Smtp-Source: AGHT+IENHYKm3NgqHa1MPYUPJeZqzEGABKtYhMj6CIPi8s9CW+uIlwWgMeUoLMPd9TX2TqZf6pVe1w== X-Received: by 2002:a05:6808:e83:b0:3d2:27d3:2928 with SMTP id 5614622812f47-3d24e8f5deamr10493207b6e.28.1718632234195; Mon, 17 Jun 2024 06:50:34 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:33 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:03 -0400 Subject: [PATCH v3 23/41] iio: health: afe4403: make use of regmap_clear_bits(), regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-23-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065038_029160_D6D4D0F0 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/health/afe4403.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c index 1dbe48dae74e..52326dc521ac 100644 --- a/drivers/iio/health/afe4403.c +++ b/drivers/iio/health/afe4403.c @@ -422,9 +422,8 @@ static int afe4403_suspend(struct device *dev) struct afe4403_data *afe = iio_priv(indio_dev); int ret; - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, - AFE440X_CONTROL2_PDN_AFE); + ret = regmap_set_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret; @@ -449,8 +448,8 @@ static int afe4403_resume(struct device *dev) return ret; } - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, 0); + ret = regmap_clear_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret;