From patchwork Mon Jun 17 13:50:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 033DEC27C79 for ; Mon, 17 Jun 2024 13:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ia4Z2qLqqNhVaFO8MtaqZtGEmhpmvSbj7T0WFgyfsq8=; b=JH3BUlHcf8CfLlvA/qJQLT3Xu/ +1hWbaDp4iub+2OZ8c4EYj2yV7jeMv9Ge8oIhw/yYaLjzIBoVZVngRJi2QEY8FZg6Akjav7yRXAeJ 4NUsJwr9WcTWUxmNGCnK8Gv+utc0IHXdjpEiHtJJTGHiBElX+GRJ+jLkw/H+dwtB2pv56Xfmiiycf 6xRt8t+sAKW19WWRpboAlkw+FOboWyIicHf7AAJQML0aLpTXdupEL6K8zcGqXruNLCMUnmYAkjNNp 9XS+kmxqJTptYmPsj5kZIvybCteu6BgtjnGjLm52ciNpZPo/DWqS43BrBuklh/+crhcV0Nz+H7grZ lwHKu3bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCoI-0000000B07V-2xDw; Mon, 17 Jun 2024 13:54:14 +0000 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCl6-0000000Axg7-3iHB for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:51:00 +0000 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-796df041d73so313416185a.3 for ; Mon, 17 Jun 2024 06:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632255; x=1719237055; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ia4Z2qLqqNhVaFO8MtaqZtGEmhpmvSbj7T0WFgyfsq8=; b=wngAor7BnaQyPzSHvwXGdPIc3JMqy6/6TBk82G5G6YB2XH9Foat4jH9whiEudDB9YB o+wpcDb0VIv2i4kihQmgwGMZh3ysAKHHgeUVtuO+4nXqYPVvxJt7TO9lt9m1xzRXz3QF PXdpMkEC53SVMXaCqAx0mouWYaAWBlDx98HKEQVaEzEZ/PpXNn5BRCoT9CoJZ8NZ3BOW //xjcGfaM78pA545PRfaCdtg5ASRBdwiNVAxsj5EcCMRdWyg95VIj9aOIouhAAHfV+Zz b3P+G1bazUlp51aVW1kXQLXscjbhmcwX+b85HXehDumI62dS60I59HZMGs19KkiQf8yh H/NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632255; x=1719237055; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ia4Z2qLqqNhVaFO8MtaqZtGEmhpmvSbj7T0WFgyfsq8=; b=Vj2bcSW8nKB3C9DV2XmTNIHEMBbCdVasab65/zZEwXfCFyNrqwYEDyrF+2H9ekqaVX It6OaewNT+CAP857yDm0TGz0wxHsQjZiyskgp9JO6foUqqKTktSqcBIJqBX3QlMKGdlk PcS0wdgyRjMb3Nfst/Soe77VZxKK89B2OMYiTB7iiv7kHdIuCnEwYTKbQrKkCkVuGkGk TxM4lRWELPhJS4KPViZ2hUAdWjUbGvNI6B/qmSYUAt3VNFAjqaBv/lIYSLyyVgEY8Xsn I5Mw2a+89j3BB28LuZRJbaVmgLAyd7kS8R93LTIODQ5UQWkmbuqFlMqIw9qmxW9/gLsS 6rTA== X-Forwarded-Encrypted: i=1; AJvYcCWSKNhQcqU3rgkzAOQ2kl8KAE/lfMOOw0mVa1UZ2rNv7XLxDUe0lLcKmj4Zq/axSjovgu/wDmKBihvBjSksUPMhBN44evfsU/VfBuys5A6gBExRMtE= X-Gm-Message-State: AOJu0YygUhi/i4yi5QVudhI6rwoNu5K2CRsLlyW1JhY52nE+kLUfiqa3 ov5co2Dt023orQHfWcHyaJ7rdSRkqUyJqYzHSD8LckSBf4DVXVbyulGc9mQD+bc= X-Google-Smtp-Source: AGHT+IEp5RQjN3OqXqNMmTgCMp6Y0MDh6HV8RUCzW71+lzqdiGZxksmwSY5WI1Xptssn8y0vJEqwfQ== X-Received: by 2002:a05:620a:1921:b0:797:74ba:8ab with SMTP id af79cd13be357-798d26b4a64mr1132760985a.73.1718632255523; Mon, 17 Jun 2024 06:50:55 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:55 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:13 -0400 Subject: [PATCH v3 33/41] iio: magnetometer: ak8974: make use of regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-33-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065057_575394_F5D60AEF X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin Reviewed-by: Linus Walleij --- drivers/iio/magnetometer/ak8974.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c index c74d11943ec7..70172b918e16 100644 --- a/drivers/iio/magnetometer/ak8974.c +++ b/drivers/iio/magnetometer/ak8974.c @@ -327,10 +327,7 @@ static int ak8974_trigmeas(struct ak8974 *ak8974) } /* Force a measurement */ - return regmap_update_bits(ak8974->map, - AK8974_CTRL3, - AK8974_CTRL3_FORCE, - AK8974_CTRL3_FORCE); + return regmap_set_bits(ak8974->map, AK8974_CTRL3, AK8974_CTRL3_FORCE); } static int ak8974_await_drdy(struct ak8974 *ak8974) @@ -438,10 +435,8 @@ static int ak8974_selftest(struct ak8974 *ak8974) } /* Trigger self-test */ - ret = regmap_update_bits(ak8974->map, - AK8974_CTRL3, - AK8974_CTRL3_SELFTEST, - AK8974_CTRL3_SELFTEST); + ret = regmap_set_bits(ak8974->map, AK8974_CTRL3, + AK8974_CTRL3_SELFTEST); if (ret) { dev_err(dev, "could not write CTRL3\n"); return ret;