From patchwork Mon Jun 17 13:50:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 029ACC2BA15 for ; Mon, 17 Jun 2024 15:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bd9TIH+WbKUd6xwGH770DEQhZI10Wa7zRAAyumCALaY=; b=34RwSG/Q/37mdWqSnPaRTC3j9L VyCtd5kjYf3G3RjsbEZ2ZZTuxgqkc/2srZ5mY/v2WBAsNl95OFM4i8W4nKPo5XQiwkP+B5Vg2aDMy Qs7XaPOKlJCyq1xlSXUFp5F5JY70WnF44YBWO10DZMe/4p4c2io8FWIFkbX5ujp2w++YWxLSaXkC8 yGnPpPMRzcxEqjPJ3ZsSPU9dR71tGvA7nTt7N/MawGjuyjObQszx1YKW8Pow/tXfcW24z2EB858ld GB4qFM8IKZG+jNZC16F+dU2pWHfLk2wisSuBM1hPiAtXKbniqmOf1/Onjt9AEmMwEFhz/AjPGqre6 l24iJ1LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJDrK-0000000BKTs-23fu; Mon, 17 Jun 2024 15:01:26 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCl9-0000000Axi6-1295 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:51:04 +0000 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-797a7f9b52eso343354285a.2 for ; Mon, 17 Jun 2024 06:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632258; x=1719237058; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Bd9TIH+WbKUd6xwGH770DEQhZI10Wa7zRAAyumCALaY=; b=MWz7Dyl+VRGMT3tw8aEE19MSPG7Dt7nlCbHV61JNrfNYNw8IiwKuhyCo+/UBbvh7VR lxUvV6WjF3rTSDEnRj6ltNiAdCejOQGvXmLlj6SATGGirdK6RDhDnxqFGgD1OoyqU1sm gJ9GeWYNQeHmBYqbZe+OGpSldR2a7gLbTBptyQfE6Irf20i3e2YcSwvlD5LL1ZPcZtOM EFxZccu1puuFG8kSrcRmFTJXttrm94t+f25+oRKyHTYeaY/IjDHNfPxRY5YKrb7tmDRH TxzyeDIW0NaTGfGhNMpZjVA8mFfLyb0MRkHsNZ8xcdA3fWZHwSl2s8ZJi882fgC9/k+I wcDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632258; x=1719237058; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bd9TIH+WbKUd6xwGH770DEQhZI10Wa7zRAAyumCALaY=; b=FLs61569VSxStkqQzQiUZcb3KkPk15rZ3+unrnRJM+DH4nujhKsywss7WqcUWan0A1 Vq33MeWcVMGt01/t7IByu6pRnDSG5cAwFGKV0SEMwc/UFtMHgfz3KLJPH5S2FgawkiHS cKo1HMg7uj0cLanHOOtfRCk0RRkSLNBiEgOMtu2r97DfjCxL7b6qaRNFhGJu53UD3ywW aTsmpX0FW2m24udPdhtfahJv7ra09DrtFkUvOfyx30pATvXlz8m/LFOJ41/5fozjAYoo WUDvhNmfGrlYkSXKdWJFFHaxqj1DsK7DqJdoQQI+EiBBWmgXhsx5ZPFVzSx/GXIgOX5N gBkg== X-Forwarded-Encrypted: i=1; AJvYcCXc2lgTocLzn2EYyPZbabYz1QsEaBHZHNlZznPiYTk8gLfAQR4BJmb4fWsw9GEzBtGBANnnXCTuijMQ+WDFK1OnWln4x6A9m7cbnB0vRHU1/gNUGUg= X-Gm-Message-State: AOJu0Yx4exG7DDNSfgPyUUnfqZH2dGK4LW00ISc5solKjA3kSVeYjkQK GaYKcfQEqLATrO26amdv9UOO5vpwbepkxolpQcATDxWuLV0XwmPzm794mMDzU0I= X-Google-Smtp-Source: AGHT+IHIgplKyy0pftg/5a2SG9pITo7fxr5SdNNjpCXiI/wTi4jbCSV+DPabl4pWpKgzNJgkUownfQ== X-Received: by 2002:a05:620a:2684:b0:797:8ee3:9f01 with SMTP id af79cd13be357-798d2437ce1mr1017310785a.34.1718632257705; Mon, 17 Jun 2024 06:50:57 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:57 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:14 -0400 Subject: [PATCH v3 34/41] iio: magnetometer: mmc35240: make use of regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-34-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065059_524405_614A7942 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/magnetometer/mmc35240.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c index 6b9f4b056191..ec35e9543a96 100644 --- a/drivers/iio/magnetometer/mmc35240.c +++ b/drivers/iio/magnetometer/mmc35240.c @@ -186,9 +186,8 @@ static int mmc35240_hw_set(struct mmc35240_data *data, bool set) * Recharge the capacitor at VCAP pin, requested to be issued * before a SET/RESET command. */ - ret = regmap_update_bits(data->regmap, MMC35240_REG_CTRL0, - MMC35240_CTRL0_REFILL_BIT, - MMC35240_CTRL0_REFILL_BIT); + ret = regmap_set_bits(data->regmap, MMC35240_REG_CTRL0, + MMC35240_CTRL0_REFILL_BIT); if (ret < 0) return ret; usleep_range(MMC35240_WAIT_CHARGE_PUMP, MMC35240_WAIT_CHARGE_PUMP + 1); @@ -198,8 +197,7 @@ static int mmc35240_hw_set(struct mmc35240_data *data, bool set) else coil_bit = MMC35240_CTRL0_RESET_BIT; - return regmap_update_bits(data->regmap, MMC35240_REG_CTRL0, - coil_bit, coil_bit); + return regmap_set_bits(data->regmap, MMC35240_REG_CTRL0, coil_bit); }