From patchwork Mon Jun 17 13:50:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE19BC27C79 for ; Mon, 17 Jun 2024 13:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cCh+HIY0adNQEnDSauX7K8bw5POFZegMypjkhgGy1wk=; b=Ho/cSjnuKk9IAV+Cf7JjPpMN0+ m5E28AlcecLyP/u2vkGj5XzzcHgm9grT7mzJOKzlw5JR0gKtJkQNDzOv7cl7FiUiFoZyZBuWHtv2y h88JURt20/mTCewDBwvNC7CZrqIwdPV7nT4e8zYla+C6NcrAogmXCEEkKGVt2yiN/4JkGqe1fjcYe yI3jjuH95i8yyVObhNDPney1fuNFlq/YIqlmkxfsNlvuhDW087q9UuwQr76j0i8klPO58OEeW9OTw PxyZ6mNmqMGGGrncoq6YPBpEQidxUW5Vc/FtVrOqGAmq96wZQRW0gqRyT1W1yzrvVnFPkPe1tDfBj eOT8ZjVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCoT-0000000B0FD-2jRV; Mon, 17 Jun 2024 13:54:25 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJClB-0000000Axjr-1ObO for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:51:06 +0000 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-7955e1bf5f8so275176285a.0 for ; Mon, 17 Jun 2024 06:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632260; x=1719237060; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cCh+HIY0adNQEnDSauX7K8bw5POFZegMypjkhgGy1wk=; b=UucAIcqaQDHcTui/8kfQO9B7fUrlHFBR6fw9wBwxsvmfjjtUm4ei3HLdMMPia6HMGR 6KbWvjUgFBf7SYh8AeFM632r3+d8YGnRChecDwUkVE6i8c6WF42xsq1EJwJfDFGi7c0N JC6Z5BAAhgTvKa5v41Z681Ga8ddwunIVMq0BDw2YElGSEorEgFHunXlSBRVCNNnvBLky rTlu8cRbj5yf0MoCu3DhmSCe17WP3YSLdtXP8vsH2hRnLYZKbRy48N6yn7JOW7UiTGUn C+0DkEv/+UQHBqPAyxvKO0pKK9XYWLi4oUHYUQe0/VXSdXYWNWozLPEs3E5w6j5hjN2/ XQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632260; x=1719237060; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cCh+HIY0adNQEnDSauX7K8bw5POFZegMypjkhgGy1wk=; b=awBKmV21LjCmXEFNgIdyaeFw2SJfcUkGEeKiyZcRpVMJIuHluR+VR328tTYK+3kiyS PQxHjcMXoEWDl9sw6Wn+/cTmECmo3GGNYPvnU2PtvCFIvbxeXj0oSDLT98kltgiqE/v1 mg4ynhk7Ja5uH9i8MneZfGdu0JxDA5fWldSXlYd/TstJHN92L1jDfytrunOA9PBzeiCc 7BimUClniKJZu2Tj5T/hka063+4OCIG6oOS75FHrTjlddF5JgGYPxV3rfgRvxSBQb4Ov YiSsfU8vTXDgxL+ZJYhm3vRs6kGIBNUrOE6UzDv3BDkb0Eg24sY4qyWndgneJv7kchkh fKHQ== X-Forwarded-Encrypted: i=1; AJvYcCXOyT2tVECMzXpQIX/ZgoMIjVvOcmkJkT8ycHB2eD3jqzyzwZa9cbNOo9u1nqyCVJTGUVbWw62YWCJnmt7yq+FSl81nl6OYhXpleuvJAugXj9b9lJI= X-Gm-Message-State: AOJu0YzeB21Ci41Xcfyf3gGT+Odj/yhe9YCBFjZQo+2MIdfmHVl1oSUS x5LYaKUse1vYItNCabdy6sTNZSlNZdeT1GJ9xnIszDO218l1ppWhtSXZ3wvtVIY= X-Google-Smtp-Source: AGHT+IENId7QjpgihvaST50kcENjvnWyxdiSnte4lhDV+Skn20e41tG2cguOi5hNHA7+JrD8WB9kUA== X-Received: by 2002:a05:620a:1a29:b0:795:50fa:c0be with SMTP id af79cd13be357-798d243ab42mr1258423585a.39.1718632259895; Mon, 17 Jun 2024 06:50:59 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:59 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:15 -0400 Subject: [PATCH v3 35/41] iio: pressure: bmp280-core: make use of regmap_clear_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-35-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065101_758830_1B22E4B4 X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin Tested-By: Vasileios Amoiridis Reviewed-by: Linus Walleij --- drivers/iio/pressure/bmp280-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c index 09f53d987c7d..ef7f546839e4 100644 --- a/drivers/iio/pressure/bmp280-core.c +++ b/drivers/iio/pressure/bmp280-core.c @@ -1566,8 +1566,8 @@ static int bmp580_nvmem_write(void *priv, unsigned int offset, void *val, goto exit; /* Disable programming mode bit */ - ret = regmap_update_bits(data->regmap, BMP580_REG_NVM_ADDR, - BMP580_NVM_PROG_EN, 0); + ret = regmap_clear_bits(data->regmap, BMP580_REG_NVM_ADDR, + BMP580_NVM_PROG_EN); if (ret) { dev_err(data->dev, "error resetting nvm write\n"); goto exit;