From patchwork Mon Jun 17 13:50:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 267D6C2BA15 for ; Mon, 17 Jun 2024 15:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MWd9RIrs8wL0I/TcIsG/QAgGB9T5+fxOkhv6E/dAdZI=; b=CyWU6j5g0KESA1hktA+2x413B9 SHPe11q4xWvBfhLU4mFjjGdbWsxzU/+GR8CGhOLDrIJx+ldW4nk4urdN17z4EVv2vqBfEmBEfPQSr iRXCl9X7IiLe1yb8StIi+DuGdeRiKzEoCYq3BZQiYfUkPOOl/ZRkZ6Ao/Z3DKK48WXjMQetz7nQnu tPkjOu1o2yW6EEAClLo4rerMFQhVgVxnxtNQTP2qXOgGAUht+VqM8Os97DbRRM1aTD1LP9AmpZ9zT Gh89WP5DkLSbEL1/bmfNW1e3+k3j2aufNyOZnAEuWcLhggGtE2DamSJm7Wps05vk0gCKKRXshf2jo NryEndJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJDrP-0000000BKYF-31xi; Mon, 17 Jun 2024 15:01:31 +0000 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJClF-0000000Axna-0T1h for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:51:11 +0000 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-24c9f630e51so2184994fac.1 for ; Mon, 17 Jun 2024 06:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632264; x=1719237064; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MWd9RIrs8wL0I/TcIsG/QAgGB9T5+fxOkhv6E/dAdZI=; b=zR8DSh2FKFTPPZt6rehf2AgFByGKGrBv1pG8uJEZTBSdfHGnObpry5sW0/mI2jB2q8 2W3ecplnTLFYf6LCrkJxArno6PIMUe23SjbibSIKNnHbbGaTkmIiHEGn08lImu9DSyk8 t/BC4IMNbYuurJ9/vRWffGo3adj+GpNAPh8uJPef5GAFqwu82E38/Is6fhcRuS43M784 KZ6BSRODVssg3tsFj6bsR7/u4kiYviCr7FDk/UfUuvYRuD16ysHh/S6TVfdJPsn496vy 9faAMv67zmYGjxMkmtwf49uvLPhxLDgD/ZyxlJzv0rqBLhxwNB00bn0rzQtUs8YgQWvP ryAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632264; x=1719237064; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MWd9RIrs8wL0I/TcIsG/QAgGB9T5+fxOkhv6E/dAdZI=; b=MPJ8Aq5q01PHCKtwkul63e2BseVEPqeLnmJ1Ab1PmCAgIqsQ2jHtI/RT93vj+KROJX zfQmfaIbRwzPgudbaLVv/xdVTm8l+fIIxkA4v4QvyxegX+ahsC3SCOFu3hNVIv8J/Fav 73vFMEz2T/0wUOwBgpx4fs0+/zvc3XfhlYYOy0vpdyNw4Y9OLT5x0XBbNsxOXPsFsSxz XZ78km2IND15cY8YBl/p4m53e0iE5u1AUjql0349hBwVHRJYyclHgv9CvKXN8Cu9rvly 57AlwXSfUnW3j5AijuuR8+c44VdzAw6G2f7NIy552FS37ddBh0A+qtq/urmS6XPhhzL9 969A== X-Forwarded-Encrypted: i=1; AJvYcCVADrgc2q0l9uGGK25MOo2flZLp/FdZLS+p7rRU60Ds+C7OGOv10Fx8g58144Ao42z/xnYyKMe5AtuiZ7AeQ9Q/mSnnE/vFo+Sda+2bCPD5I8tdyT0= X-Gm-Message-State: AOJu0Yynw7acnVIEWyDW5t0NJe01qShSqsyDKlI7mfe0/9r+3OA2bubf /n2ho/gZc8W9CoeO52FW2MlyDVWgCe+oakfH+v5it0zp6HL8rbC902lIAhK5M78= X-Google-Smtp-Source: AGHT+IH8uTWV+X4VQg+Hvv7+Ss0V04PvnK1VdmrqhUaV/+VFOL4UdwUlA2xHiJMwUxJKiw4xuPCudA== X-Received: by 2002:a05:6870:15d5:b0:254:8bb9:d0bf with SMTP id 586e51a60fabf-2584298505cmr11157462fac.32.1718632264185; Mon, 17 Jun 2024 06:51:04 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:51:03 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:17 -0400 Subject: [PATCH v3 37/41] iio: proximity: sx9360: make use of regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-37-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065105_467734_F6C28C96 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/proximity/sx9360.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/proximity/sx9360.c b/drivers/iio/proximity/sx9360.c index 75a1c29f14eb..2b90bf45a201 100644 --- a/drivers/iio/proximity/sx9360.c +++ b/drivers/iio/proximity/sx9360.c @@ -672,9 +672,8 @@ static int sx9360_init_compensation(struct iio_dev *indio_dev) int ret; /* run the compensation phase on all channels */ - ret = regmap_update_bits(data->regmap, SX9360_REG_STAT, - SX9360_REG_STAT_COMPSTAT_MASK, - SX9360_REG_STAT_COMPSTAT_MASK); + ret = regmap_set_bits(data->regmap, SX9360_REG_STAT, + SX9360_REG_STAT_COMPSTAT_MASK); if (ret) return ret;