From patchwork Mon Jun 17 13:50:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A555C27C79 for ; Mon, 17 Jun 2024 15:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DYef8rADT2ijxxEcxYPLN7/oRY6yNh5EaRUGzmb2a/I=; b=G8ViZMEB+iWRPcYiCHUviB2ws0 BFK7JjqoVemoUFsJMUbSAFJK7EIiJPIWgrU9khHkFUa4uRBHPN3Y6M2b8Jjca/3Ewysb/+NuaUXqz 6N+xMqQJ4BR5Y8LGGWNDR6o7CjuxAiLBtlZq2X46D3aRhC96MgprciJw/4cKsZ1Gt+C7DO9kaSPrX EEsRCU+3i48KysZCk1m+owR/yioC1nzYgzpnAnOCJ1ihRo3wzumg0K7EPlZO58aE2mGuHfVSgxlOu VKEXqJ/qb3IMY3BRHbCV/mPBKRnxhFeS+vnFn9ig0wDC41jnI4p8P2snt8Q+1DuE97LNVmFsjfz0V JgKsWgwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJDrr-0000000BKva-3dL2; Mon, 17 Jun 2024 15:01:59 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJClL-0000000AxtU-2zRt for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:51:22 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7954f8b818fso290944185a.1 for ; Mon, 17 Jun 2024 06:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632270; x=1719237070; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DYef8rADT2ijxxEcxYPLN7/oRY6yNh5EaRUGzmb2a/I=; b=ipqFRZIl5dKVVXrBpKc5Qx7KQ3C2WGQnvnK5YVsydmN/vE8DXjxWRC/MXuB2f9O6W3 JU4sJ2z+qMnWj2kWAS5tDlAGxJ3WvRZ1pFZmMpn2cGqlFg6a5ODBJ2SlwEkwR11TiETt scZOSwXr0szHS+6b9dzkRvLgTjDHbP8MGbaoXDPUFkpzika+hZkYy+1KtP0wNJxN3qaL IwNXQokCeROeFqy29NrrwN7aNRRDMBu0xb0SLmIiZcWC3vtn3AqAluZ9WYPNtQG5rXfc boDTUZc9e4n/O+/Rz3Sw0TTEH6XjjkFx3wXLzB6rZtcEnhzdJmKtWdL7ftwOIoe6PhlY wnQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632270; x=1719237070; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DYef8rADT2ijxxEcxYPLN7/oRY6yNh5EaRUGzmb2a/I=; b=FkiSTti+eSWpXkRhw5vAQe/g6sjyXpGm4B3vArmengJNda4BhSdF35axZmIRStr4d0 OhL5X5jFkrYvKc5xnh2RrdPjDhi09wBVkWoYAZWolQQq2dFgcd4Yol8sxXHj1ijX/Qrc 1b39q+GmLbXbHJ09+VEpYTx573VFGw6ft9sIlsaOmZwqrmEZo0lvwqEoTTG3bvT8e9Yi O44MG6UYUEJtdZCEnhwz9+JyYvsoZDl530NvBoH4f3WSmlUvCwTJJkZ9vtQ+cy3g+xfu HaoBZtiKmM/sBmX1s0npTrdYOu8PVh1Dm8njtfoOhKBfNZ+8cltPpIygiNrTxQWrE31R j/yw== X-Forwarded-Encrypted: i=1; AJvYcCVj/Vw+0DIofk+VWt37+rfB7cGk+vmkMU3wytpgqv0wdJyl2l2HpcznHNdgTi5+P3RGOuoAp/1g+5r//SNuuAL+N6EQpCk21akDLtGcfep9IonCdVY= X-Gm-Message-State: AOJu0Yysq88feHl31JspY2CCGD3Qw1V0r8d+JCF0kOgPJ1iwjcLyCKHa ZXd2FX3IxgVJexg9GaNY8qFZLPdYZQvhj2IqntcZrbLecyCsUCSgEB9xdz7/hXc= X-Google-Smtp-Source: AGHT+IG+NTpXbmfTtgLV5kgHRYZJqicJgvBNrkkmD2PI5YKClqNlpZ4QFEOEqllRaBP9Jcn3G+Ldqw== X-Received: by 2002:a05:620a:24d5:b0:795:50ef:4030 with SMTP id af79cd13be357-798d242f345mr1050763085a.41.1718632270523; Mon, 17 Jun 2024 06:51:10 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:51:10 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:20 -0400 Subject: [PATCH v3 40/41] iio: temperature: mlx90632: make use of regmap_clear_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-40-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065112_055448_437E3837 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Acked-by: Crt Mori Signed-off-by: Trevor Gamblin --- drivers/iio/temperature/mlx90632.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c index 8a57be108620..e7de30f613d2 100644 --- a/drivers/iio/temperature/mlx90632.c +++ b/drivers/iio/temperature/mlx90632.c @@ -334,8 +334,8 @@ static int mlx90632_perform_measurement(struct mlx90632_data *data) unsigned int reg_status; int ret; - ret = regmap_update_bits(data->regmap, MLX90632_REG_STATUS, - MLX90632_STAT_DATA_RDY, 0); + ret = regmap_clear_bits(data->regmap, MLX90632_REG_STATUS, + MLX90632_STAT_DATA_RDY); if (ret < 0) return ret;