From patchwork Tue Jun 18 20:45:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 13703007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D57BC2BBCA for ; Tue, 18 Jun 2024 20:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0aRxOAD2Qgk5Lly7g3t86NVGFyqjyCN/MyLZiIAVgHs=; b=M/rw18BqQ4zTjr2PUgy1F2RVXl 4umoIRlh1VjZ6dOKdBVyXKeqRox+db0Uh5MQrYtzX1QK6oPWF48rhu0gHm6S0gE6GmxoIRJdlnaqu o75vdWKAztc44Fn/uNG2WDGbWuG7Y8AlHhcWj/f+y8UjCCIAY8Z+7RpVktDnPauMR7FSwUnPsLAwZ EdDeEmFJdf63oMwVpzkL31hHklOhiMtNkonEsCRi8pyVcbHchGOh645ubP8Cyl3y6trxeUDHaJmq5 cg88UD4j7FWQMG9KxtdMHE1XIn9rAXKN6jo/VjYpzKj47TfzBnw6vYIi9cyyebSSR3MOQ5MQGyMHZ vJvFeM+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJfi4-0000000GX0n-2zYv; Tue, 18 Jun 2024 20:45:44 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJfhn-0000000GWtJ-2tqU for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 20:45:30 +0000 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6f8d0a00a35so4917465a34.2 for ; Tue, 18 Jun 2024 13:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718743526; x=1719348326; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0aRxOAD2Qgk5Lly7g3t86NVGFyqjyCN/MyLZiIAVgHs=; b=t7dPOfQuI3OmSoSj1mzfH48K8FkTleWbziiG0EKg2+2dPc4W9LSCGrTDzgrTuW0Axc 63r4ieJlJOI7AWCWE4mS4SNGLYuI15Eh5rZT4lTIwBnfz15xxXPd6Ti8gvrKKr2VNlQg AJu01op2MP7iCbw+Q0Dfl19fu/3kMfoLu9x403vH0nJzUuvYKlHP93wMQ7E91x4zQQXH dwaO0J92v2TdjzVA1JcoMdAuIuai2Veq4Jjeq6GHfuklKgHboeWu2jyrhfXKkcxY7NpW YUY0x2lWo2smq7/lzBdckwiz7Te7uplZQNHVa4ehsfLWp++kI7sLD36nWTAOVMV1rZV4 hpmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718743526; x=1719348326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0aRxOAD2Qgk5Lly7g3t86NVGFyqjyCN/MyLZiIAVgHs=; b=CE3uF+2AjU7NjeZhoyox/GhEojZRwWEGgrgpyf0X+oxgpuqMkd+pT0DK1OoC+PEiUo kpweE3infaWP/jE6b7uYVASMapnJDfH4a9dnDEcg6vFUjHMmw+xFQ77sBpMEi4spL+0k bCQ+s4FoVgi3/otrUwerqoMr6ywmQzVp8Eg9erHdNN4wnNAQcIu9ShrGH0aWxoe33k+R J+cU7+XXCymUzHopQNpMgi+bA9gAFNIVAHckg/nTtEK6CT/+Pry+2vf8iGX0S3nhthXR PvUxGwN4taMVV23Lj8k/1vHlGkZju5V8ibg9rAb27Nb8sv91nz3+rQS9fU1pSe3CLd7D IM1Q== X-Forwarded-Encrypted: i=1; AJvYcCXiM/R8Pa0d6NIWK789+h+h8JjjIhODe0fm7BpU3FInMZHURLr6TFrEqlTCmuCo0QZLd/ZR8R1sMz2uAzx4VVEtY8AtQq+YvBlpjjnCQeZp0AGmZz8= X-Gm-Message-State: AOJu0YxuSkBYYHccIHtMwz+ptXFJf1L41crJZkIFbg6HH9rm1c+m0IeI 6eaJNx7g/ANpcvy/pptDpD3zqCARcXTAdH635+7pMWrsWKIwaisMQ3J1dzQt/Bs= X-Google-Smtp-Source: AGHT+IFsyuXPTcRk/B3lUM1O8/TQZfkRs+GDfXqj2NsRA9yWpG9ZWVrUspoi5rnxH+NBKKi8Gu9VmQ== X-Received: by 2002:a05:6830:1d91:b0:6f9:c989:261c with SMTP id 46e09a7af769-700766349damr883708a34.33.1718743526611; Tue, 18 Jun 2024 13:45:26 -0700 (PDT) Received: from localhost ([136.62.192.75]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6fb97051e68sm1692599a34.80.2024.06.18.13.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 13:45:26 -0700 (PDT) From: Sam Protsenko To: =?utf-8?q?=C5=81ukasz_Stelmach?= , Krzysztof Kozlowski , Rob Herring , Conor Dooley Cc: Anand Moon , Olivia Mackall , Herbert Xu , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/7] hwrng: exynos: Use devm_clk_get_enabled() to get the clock Date: Tue, 18 Jun 2024 15:45:19 -0500 Message-Id: <20240618204523.9563-4-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240618204523.9563-1-semen.protsenko@linaro.org> References: <20240618204523.9563-1-semen.protsenko@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_134527_764495_8C9215AF X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use devm_clk_get_enabled() helper instead of calling devm_clk_get() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. Also use dev_err_probe() to handle possible -EPROBE_DEFER errors if the clock is not available yet. Signed-off-by: Sam Protsenko Reviewed-by: Krzysztof Kozlowski Reviewed-by: Anand Moon --- Changes in v2: - No changes (it's a new patch added in v2) drivers/char/hw_random/exynos-trng.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 88a5088ed34d..91c210d80a3d 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -134,32 +134,23 @@ static int exynos_trng_probe(struct platform_device *pdev) goto err_pm_get; } - trng->clk = devm_clk_get(&pdev->dev, "secss"); + trng->clk = devm_clk_get_enabled(&pdev->dev, "secss"); if (IS_ERR(trng->clk)) { - ret = PTR_ERR(trng->clk); - dev_err(&pdev->dev, "Could not get clock.\n"); - goto err_clock; - } - - ret = clk_prepare_enable(trng->clk); - if (ret) { - dev_err(&pdev->dev, "Could not enable the clk.\n"); + ret = dev_err_probe(&pdev->dev, PTR_ERR(trng->clk), + "Could not get clock"); goto err_clock; } ret = devm_hwrng_register(&pdev->dev, &trng->rng); if (ret) { dev_err(&pdev->dev, "Could not register hwrng device.\n"); - goto err_register; + goto err_clock; } dev_info(&pdev->dev, "Exynos True Random Number Generator.\n"); return 0; -err_register: - clk_disable_unprepare(trng->clk); - err_clock: pm_runtime_put_noidle(&pdev->dev); @@ -171,10 +162,6 @@ static int exynos_trng_probe(struct platform_device *pdev) static void exynos_trng_remove(struct platform_device *pdev) { - struct exynos_trng_dev *trng = platform_get_drvdata(pdev); - - clk_disable_unprepare(trng->clk); - pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); }