diff mbox series

[v3,7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module

Message ID 20240620083115.204362-8-antonio.borneo@foss.st.com (mailing list archive)
State New, archived
Headers show
Series irqchip/stm32-exti: split MCU and MPU code, allow module build | expand

Commit Message

Antonio Borneo June 20, 2024, 8:31 a.m. UTC
Drop auto-selecting the driver, so it can be built either as a
module or built-in.

Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
 arch/arm/mach-stm32/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Gleixner June 23, 2024, 5:27 p.m. UTC | #1
On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:

> Drop auto-selecting the driver, so it can be built either as a
> module or built-in.

How is the driver selected then? Has this to be done manually now?

If so, doesn't that break things when starting from an empty config?

Thanks,

        tglx
Antonio Borneo June 23, 2024, 5:38 p.m. UTC | #2
On Sun, 2024-06-23 at 19:27 +0200, Thomas Gleixner wrote:
> On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:
> 
> > Drop auto-selecting the driver, so it can be built either as a
> > module or built-in.
> 
> How is the driver selected then? Has this to be done manually now?
> 
> If so, doesn't that break things when starting from an empty config?

In patch 6/8 it is already selected through:

+	depends on (ARCH_STM32 && !ARM_SINGLE_ARMV7M) || COMPILE_TEST
+	default y

Regards,
Antonio
Thomas Gleixner June 23, 2024, 10:15 p.m. UTC | #3
On Sun, Jun 23 2024 at 19:38, Antonio Borneo wrote:
> On Sun, 2024-06-23 at 19:27 +0200, Thomas Gleixner wrote:
>> On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:
>> 
>> > Drop auto-selecting the driver, so it can be built either as a
>> > module or built-in.
>> 
>> How is the driver selected then? Has this to be done manually now?
>> 
>> If so, doesn't that break things when starting from an empty config?
>
> In patch 6/8 it is already selected through:
>
> +	depends on (ARCH_STM32 && !ARM_SINGLE_ARMV7M) || COMPILE_TEST
> +	default y

Missed that. Thanks for the clarification!

       tglx
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
index a401a991fe088..630b992f32b16 100644
--- a/arch/arm/mach-stm32/Kconfig
+++ b/arch/arm/mach-stm32/Kconfig
@@ -11,7 +11,6 @@  menuconfig ARCH_STM32
 	select CLKSRC_STM32
 	select PINCTRL
 	select RESET_CONTROLLER
-	select STM32MP_EXTI if ARCH_MULTI_V7
 	select STM32_EXTI if ARM_SINGLE_ARMV7M
 	select STM32_FIREWALL
 	help