diff mbox series

reset: meson-audio-arb: Use devm_clk_get_enabled()

Message ID 20240621-reset-devm-clk-get-enabled-v1-1-8408c7962b6c@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series reset: meson-audio-arb: Use devm_clk_get_enabled() | expand

Commit Message

Philipp Zabel June 21, 2024, 3:28 p.m. UTC 
Use devm_clk_get_enabled() to reduce a bit of boilerplate and to
disable the clock in case devm_reset_controller_register() fails.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/reset/reset-meson-audio-arb.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)


---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240621-reset-devm-clk-get-enabled-ddf3b61fe2c2

Best regards,

Comments

Jerome Brunet June 24, 2024, 6:58 a.m. UTC | #1 
On Fri 21 Jun 2024 at 17:28, Philipp Zabel <p.zabel@pengutronix.de> wrote:

> Use devm_clk_get_enabled() to reduce a bit of boilerplate and to
> disable the clock in case devm_reset_controller_register() fails.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
diff mbox series

Patch

diff --git a/drivers/reset/reset-meson-audio-arb.c b/drivers/reset/reset-meson-audio-arb.c
index 7891d52fa899..894ad9d37a66 100644
--- a/drivers/reset/reset-meson-audio-arb.c
+++ b/drivers/reset/reset-meson-audio-arb.c
@@ -129,8 +129,6 @@  static int meson_audio_arb_remove(struct platform_device *pdev)
 	writel(0, arb->regs);
 	spin_unlock(&arb->lock);
 
-	clk_disable_unprepare(arb->clk);
-
 	return 0;
 }
 
@@ -150,7 +148,7 @@  static int meson_audio_arb_probe(struct platform_device *pdev)
 		return -ENOMEM;
 	platform_set_drvdata(pdev, arb);
 
-	arb->clk = devm_clk_get(dev, NULL);
+	arb->clk = devm_clk_get_enabled(dev, NULL);
 	if (IS_ERR(arb->clk))
 		return dev_err_probe(dev, PTR_ERR(arb->clk), "failed to get clock\n");
 
@@ -170,11 +168,6 @@  static int meson_audio_arb_probe(struct platform_device *pdev)
 	 * In the initial state, all memory interfaces are disabled
 	 * and the general bit is on
 	 */
-	ret = clk_prepare_enable(arb->clk);
-	if (ret) {
-		dev_err(dev, "failed to enable arb clock\n");
-		return ret;
-	}
 	writel(BIT(ARB_GENERAL_BIT), arb->regs);
 
 	/* Register reset controller */