From patchwork Fri Jun 21 13:19:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13707594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F047C2BA1A for ; Fri, 21 Jun 2024 13:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WGwqd975to9Nc6K92tWIbNW9GhNoaX3gZDD9jZNa8gI=; b=o9K3xpwXSxK3rLikXWD6vEFM9y 8jN9T4I2ODUYmxiydt89hlow8Lq4uCw8aGg8gXzcnrwccfRwxJzEiKy7WWqew3sPX9DqGlDTW3c56 Sk446yUdRKYW9LLh+FD5KjIQHwC6hnu1jjlEAnWQycCcW7541dogli2eVh2AjTBnnvc6PjLBu66zh gPvKzRX/87giRVfv2YZv+ThVGZZ4w2LK7E/dGqqMyOwSxmU/nHcQiT6JExdhwyoBneL0LAjFhtiqE JDFHzgOsxTZIK3f0qwTluq0/QxFZTdowC0gFEjCeTa3vPNLZokKipFScMgdnUnKP2o3jNzuI3G2qn mbO3mfwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKeBn-00000009J6y-2j8Q; Fri, 21 Jun 2024 13:20:27 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKeBh-00000009J1F-14vi for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 13:20:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718976016; x=1719580816; i=wahrenst@gmx.net; bh=WGwqd975to9Nc6K92tWIbNW9GhNoaX3gZDD9jZNa8gI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ns9jXKmHLPYukUOp5ya/7OVOXVA3Qb6IFCv9XWZJlbStb66DLgxPFgGvA3uHxkoO MLExLk+FYpFDwSnlggYYSsdoFvGpdK0Q5oPNtE6cZ7Ab2IZ5bf5TcWhX8D2q+Ph8g brwV66GwEqjdzqLe0jjIhhIIiPaG86bWVlfIai8Pvn8yrJpmEEtMojsO8NW9aW+CC lqFwBBIvlWwnnlWD3aSO8rlxP2V9ZW8G/s5yLsbqVGeX6ljMQBX6vyzWpndgOxhtn hQLNJdG/DMsB02doFRYo0PaX5J3TTW3AzchJSG+Ppu6b7AHa90BW1YRr4sogHrleV hkyIuto8/L8QE0461g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQ5rO-1ryYxz3zpQ-00NnBk; Fri, 21 Jun 2024 15:20:16 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V3 02/10] staging: vchiq_arm: Drop obsolete comment Date: Fri, 21 Jun 2024 15:19:50 +0200 Message-Id: <20240621131958.98208-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240621131958.98208-1-wahrenst@gmx.net> References: <20240621131958.98208-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:yEdTAysFKPgx1duXtm089Ojkf1CVkI3ARW1c5Zue+KWtHQKkfJI ed8HhV3h54/weFMWYUxLZwXeO4buQBIvnSnBu7L54lPas0uv1Tnh9b4Um6vTiPEj81jzoYh 4Bk4CYAT1sgWS3XBR1nfYwNSJbo8KsuNBRFQKEbbF+G2KswjSlPOQxjRlPs0qVqSuJmlwc5 KOX4//JMVGzHuL7l3qAFg== UI-OutboundReport: notjunk:1;M01:P0:MMcm+CF4pFs=;2DCv13Wi91wJyXr887gncArKqtz Nrwujct9SM+k1yk1Qe3Tz+F67uGwsxEMixnPZPcg2Q/amNo0f9daHQupsn/gSNbUR+O516uIa /PvrudaDl1gDtuiR7rJ19/3HrSJWxonhKjKQMB2IklNcRKHpPExaMw2hZEGWOrbqzWhg9uay3 Mx3DcWGafV6hmHbbCXUdY/lGYr/WfNe4USJyXx8rcvdBHrb2ytLISK1Qre1VtO+NdrcFuxjoM JRP4J/XaG1Pe0MJVdGZh8s6ajwZ8a70kmHWTHfSaoeaW//JpjwbMXJMLFMxXrKCiCBjs0u6ux 19EeHaVLKQPy1XQbsY93n7wJhTVyB1dDVLj2LTal7jwdj6ngQn0M38MXZdK3sgMLBXnQHdkHh OCq2TzukSkzvVbUvoS99OkC5Uc6No7Ue/nqsKSiTqXnkGCu4xUZK4PXNHuKZJ37Cph7Euiia0 183IFYDiqmFocqBGyOke4kZl3VgqNbMQXLFnEy9hinO32sIUaWFrQ1pcRNx7L79UpavHB2C5R NAeD8vwAs5X5aOXiv87/i70ts/zKFsQ8d7bDyBIQn7zd7FzeAgQRBCw1gAUPlbeXEWGLH//I+ 8m321hNbT6Yv4G5lrp8dm2zFovrziLDwMyr2enR0IXhfWJ46sXtmf3WInh8oz+2Y2nWJU62Ij x2V7chqyG3KVJPiMUGZ627BOKRR113MPb1t92EF3vJUyuRHXhpsXkgeG9TBUsUZeNgrBzV0IZ aQZFm1CZW7SbBW0JjBjjpqLI/PNPVd/qDWUwZwXFPqu7ot+GW3WLZ1tNUPneyacYxk67wI+Fw 3InvhBy8uIDZput6Y1DN5vHL+QduPng2KHPw3eGWcnCUU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_062021_636979_DD5BE555 X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The BUG_ON has been replaced with WARN_ON. So we can drop the comment. Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 2357402f8ab9..6cfc5a769b8a 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1448,7 +1448,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) write_lock_bh(&arm_state->susp_res_lock); if (!arm_state->videocore_use_count || !(*entity_uc)) { - /* Don't use BUG_ON - don't allow user thread to crash kernel */ WARN_ON(!arm_state->videocore_use_count); WARN_ON(!(*entity_uc)); ret = -EINVAL;