From patchwork Mon Jun 24 10:31:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13709300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13803C2BD05 for ; Mon, 24 Jun 2024 10:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Y79rUxm3lgbaqaUYltDlAHQT1o1yNbGd4AJC95vHYik=; b=JLkpwqe9IyWhwiiZ0/fB2+CcPh A3BS70+r4H8KUaM6HYiMYjH/Zu/X+O8CdZ7z2xZS2vXaKseLz5Mog5MZXXCW4gqEsshOTUKTi3arq KC3kROJYoSF4VMa5IBBmEJmafwi/hLgcbNd+ptrte2nLSARxEMONliYr4mdOOfm9pJ4jauJxtc2vC F3YmzpB/YeYdtYxx7SCYgcFeF5ox5uQUFI54UCNLVudwzS3Q9qUQcEECCoHkd2EXR9KwY2OpiKhsz EFHMvxoG+fkzUbwI+zaMuzz6wNX6FaN6jTKLGwF9wocVW5zMrAIoHbd3/o4DlROwhgLgqq6HGnq8j 6pcyaErw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLgzK-0000000GQp1-18z1; Mon, 24 Jun 2024 10:31:54 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLgzF-0000000GQoC-1K9G for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 10:31:50 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ec61eeed8eso8199151fa.0 for ; Mon, 24 Jun 2024 03:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719225107; x=1719829907; darn=lists.infradead.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Y79rUxm3lgbaqaUYltDlAHQT1o1yNbGd4AJC95vHYik=; b=w6xhGRBGoLRebMEDXveGp04dPwws3dIrDP8M7V6QOnisfOzoWaF9vwc4OMZki6/y0w 7GtaVuWYO2ZgIbh/gJEdvXR8K5fyZbkQGcCxaWf0+vjJWlpMoA6NoOOX3JxenDidOGf3 Wqp/K8CVwdeTCHwVpbXDS1uNvb6r1VJoylWu0E5Epxfg3bIcvpASHsrnvWNxabTNtZAZ KEZBsBebqifEIE9gicOfK63po2cWvH4J3kuTPyRDs5YQAOAC1R09IQX1x8kFWssIMDoD aPyTwTP2KQzdFyNBQaDJ1FNuxZdBxM2fCxXE1CQm1XU8/s60XjrjyoXJtQbeaQesSl1+ lYRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719225107; x=1719829907; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y79rUxm3lgbaqaUYltDlAHQT1o1yNbGd4AJC95vHYik=; b=vMPmpB6uRZWZbyAyVESql21fu4VkMcDR4dWnS8I9b9OzRqAl7ct0Mlz/lriVN+eqxH CVJ77qqgrEIIheM0smdMJ+jFhfdaR8fXZDUq9Ge7C4hVTi+6hefKj9bpupSHSUxbD6Vu DlbSaEHCR6rTW2VEDtqTPMk5jweoOrWoYaCx0CdHZdiaNggr/Vey69+6yYDU6AplDm4h 2mPqsBRTQz0mwWX6+s18X8fJyWrFLlZ3GxJqCuybOdXGIvx7tSnkOkRNHsYN+raOgC+1 b0UrlCEMlH347D7pMVwL3i9m8TFgvPCxoHENF7sNuMhfF3RsrsejPJshZO2lCk2mJ6Y/ Vhkw== X-Forwarded-Encrypted: i=1; AJvYcCW9LwQCjzEvdYJhWOp5bRizizgc3EbPqOKAJ9bwpQwfEdRtrMgvtPy3mO/8UTff3N0t7ZlNVJWHmcmcH4XwmHiueW7RgC6WPX0SEqh0U6sBviWzlFA= X-Gm-Message-State: AOJu0YwnFCu9hwsES0W6R9Zdwg9IbcQvtIzz5MNNRb4FCQBYe4zA0JH0 //ROr6zpCTGLFdMo4doSQ7m5RmihiC4/XOpugfcyRtum4AKu5U8Zucqh0/8sOeQ= X-Google-Smtp-Source: AGHT+IGQ8/4ij15CkMhnOaWlVH+mAJ1XYx0sN2OLk0VHtmIAIuWQqIv+pbQOI4C4fD5y7Z7z3JFAOw== X-Received: by 2002:a05:6512:138e:b0:52c:e08c:a0dc with SMTP id 2adb3069b0e04-52ce185f753mr2722847e87.51.1719225107235; Mon, 24 Jun 2024 03:31:47 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd63b46ecsm953874e87.10.2024.06.24.03.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 03:31:46 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 24 Jun 2024 13:31:46 +0300 Subject: [PATCH] drm/lcdif: switch to DRM_BRIDGE_ATTACH_NO_CONNECTOR MIME-Version: 1.0 Message-Id: <20240624-mxc-lcdif-bridge-attach-v1-1-37e8c5d5d934@linaro.org> X-B4-Tracking: v=1; b=H4sIABFLeWYC/x2MWwqAIBAArxL73YJZ2OMq0Yfpmgu90IhAunvS5 zDMJIgUmCIMRYJAN0c+9gxVWYDxel8I2WYGKWQjlGxwewyuxrLDObDNXl+XNh6VqFXXiXaWrod cn4EcP/95nN73A0Xa3slpAAAA To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Alexander Stein Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2092; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=eCJNHKpOFyvKm0QEDNLeKYcgJDFGN4EGDIDzjHn6FlM=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ1qlt9Ar59KYH7VRt3+sPjXB/Fev0SbNiiz7/1tLfh+y4 Z14d3JaJ6MxCwMjF4OsmCKLT0HL1JhNyWEfdkythxnEygQyhYGLUwAmolDP/r+g47nFmZ9R22/5 efi9nXuhhTE82Suct/H5aV5J9oMrpbZ7L7Waes+VrWm2tc15L9m9AncYm8PiVHtsVBXLjiTN3WE lHnctvr2BX0f+9R69+eeKW9UZRKyfaqsxz37umtKgdfCFxaKe+cX5C3Ly0l8mSjyZciVaSlhVWV zN5Nj2F2nHQs6I7X/5we3MsobNQW1X7I83GSV6pIvwfmVr27dlGuMdRwazhu+Pvu2r+bXI8kpjI cen9qTndWkzN0S4MW3/ZTmpYp3d9X9Ts93q47wvJ1uKOSj95vyuuPZJzsYQg1ivGnmNRbr3pVfd Y+LY2nzepa339YqjPd1M+3jzv8o2rO65sYglaLXs8Z/5AA== X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_033149_415960_0254BD48 X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Existing in-kernel device trees use LCDIF with the dsim + adv7533, dsim + tc358762 or with ldb + panel_bridge. All these combinations support using DRM_BRIDGE_ATTACH_NO_CONNECTOR for bridge attachment. Change lcdif driver to use this flag when attaching the bridge and create drm_bridge_connector afterwards. Signed-off-by: Dmitry Baryshkov --- Note: compile-tested only. --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) --- base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7 change-id: 20240624-mxc-lcdif-bridge-attach-60368807b2f9 Best regards, diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index 0f895b8a99d6..1d5508449995 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -48,6 +49,7 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) { struct device *dev = lcdif->drm->dev; struct device_node *ep; + struct drm_connector *connector; struct drm_bridge *bridge; int ret; @@ -96,13 +98,23 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) return ret; } - ret = drm_bridge_attach(encoder, bridge, NULL, 0); + ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) { of_node_put(ep); return dev_err_probe(dev, ret, "Failed to attach bridge for endpoint%u\n", of_ep.id); } + + connector = drm_bridge_connector_init(lcdif->drm, encoder); + if (IS_ERR(connector)) { + ret = PTR_ERR(connector); + of_node_put(ep); + + return dev_err_probe(dev, ret, + "Failed to create bridge connector for endpoint%u\n", + of_ep.id); + } } return 0;